Commit graph

138 commits

Author SHA1 Message Date
Reinier Balt
e2eb31cfcc Merge pull request #206 from mmozuras/refactor_unless_blanks_into_presents
Refactor unless blanks into presents
2013-09-13 06:08:16 -07:00
Mindaugas Mozūras
25e764b21a Refactor "unless blank?" into "if present?" 2013-09-13 15:40:09 +03:00
Mindaugas Mozūras
962b4fa5c9 Use respond_to { |format| format.any } to reduce duplication 2013-09-13 14:58:28 +03:00
Reinier Balt
fee1e3b504 fix failing test on timezones and remove debug message 2013-09-05 12:23:26 +02:00
Matt Rogers
96777c2e3a Replace User#time with UserTime#time 2013-07-30 16:21:04 -05:00
Matt Rogers
8512e8db3b rename DateUtils to UserTime 2013-07-29 21:51:15 -05:00
Matt Rogers
a1aaa283f1 Remove User#at_midnight
Replace it with a class called DateUtils with a method called
`#midnight_for` that takes a preference instance and date to convert to
midnight.
2013-07-29 16:34:23 -05:00
Matt Rogers
883ea2b968 Move Project#create_from_todo to its own class
The point of this is to keep as many things out of the ActiveRecord
objects as possible and use them as just a thin database abstraction
layer.
2013-05-02 22:30:24 -05:00
Matt Rogers
036c34f266 Rename RecurringTodo#inc_occurences to increment_occurrences
This clarifies the method name and fixes a typo.
2013-04-26 16:20:42 -05:00
Matt Rogers & Katrina Owen
a1b270699d Extract creation of todos from recurrings todos 2013-04-25 20:45:14 -05:00
Reinier Balt
85fc82d494 refactor done todos view and tests 2013-03-18 12:36:40 +01:00
Dan Rice
dc311221f1 Render notes using RedCloth without formatize
Removes the outdated bluecloth dependency
2013-03-13 17:03:58 +02:00
Matt Rogers
053e3fc8d6 Guard against the case days stale can be negative 2013-03-10 22:48:27 -05:00
Matt Rogers
43275e064e Refactor the calculation for staleness
Provide the number of days that the todo was stale instead of a class
name to use in the view.

We'll use the number of days stale in the helper to determine the class
name
2013-03-10 13:46:22 -05:00
Matt Rogers
ccf5323588 Encapsulate the concept of staleness into its own class
Extract it from a single helper method and wrap it in a method object.
This lets us add tests around it and then (later) split the domain
concerns from the view concerns.
2013-03-09 22:38:38 -06:00
Dan Rice
34e0c2b13a Revert "Use db:schema:load instead of db:migrate"
This reverts commit 3c5f28869b,
which did not function properly on the continuous integration server.
2013-03-05 01:00:24 -05:00
Dan Rice
3c5f28869b Use db:schema:load instead of db:migrate 2013-03-04 12:50:30 -05:00
Reinier Balt
ef91dd0c64 another set of dynamic finder migrations. All non-cucumber tests pass 2013-02-27 11:50:49 +01:00
Reinier Balt
7eccf79ab6 fix regressions and use timecop to fix time in tests. Thanks Dan and Hans! 2013-01-06 16:04:07 +01:00
Reinier Balt
796685072d finish updating cucumber scenario's to the stricter capybara 2013-01-01 17:38:59 +01:00
Reinier Balt
b18b222834 another set of fixes for the cucumber scenario's 2012-12-24 15:36:47 +01:00
Reinier Balt
da2bee2e53 start fiingx failing cucumber scenario's and some small fixes
new capybara introduces some failing scenario's
2012-12-23 23:16:22 +01:00
Matt Rogers
4d2f25ab20 Refactor the fetching of done todos
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.

This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.

The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
2012-11-27 23:07:46 -06:00
Matt Rogers
63711edba8 Don't run the cucumber features as part of the ci task.
They take too long to run.
2012-10-09 12:47:53 -05:00
Matt Rogers
17f2648bf9 fix the migration task name for the ci task 2012-10-09 12:36:03 -05:00
Matt Rogers
e1bae5a2de run the database migration as part of the ci build 2012-10-09 12:29:06 -05:00
Matt Rogers
fc8ad0f7b8 set up Travis CI for Tracks 2012-10-09 11:53:46 -05:00
Reinier Balt
ff06f418e8 Make sure that changing tags (i.e. toggle star) touches the taggable (todo) to invalidate cache. Make sure _context is cached different for _context of active todos and _context of tagged todos and _context in tickler 2012-09-02 15:13:29 +02:00
Reinier Balt
1cdf6c8b8e fix #1325 by applying the patch of Dan Rice. Thanks Dan!
Also add a test to catch regessions
2012-08-25 17:18:22 +02:00
Reinier Balt
885ee7d1d1 refactorings for recurring todo model 2012-07-13 00:31:11 +02:00
Reinier Balt
82bb67f518 small refactorings 2012-07-12 13:14:21 +02:00
Michael Witrant
017e1761ca added script to rewrite locales utf8 2012-07-07 11:35:10 +02:00
Reinier Balt
005723cb4f get login, mobile and notes features passing 2012-05-12 13:37:36 +02:00
Reinier Balt
c9d64e6f4b get the first cucumber feature running: calendar 2012-04-30 13:56:42 +02:00
Reinier Balt
96db48dd86 get project integrations and login controller tests running 2012-04-30 13:56:40 +02:00
Reinier Balt
59a4d5ede0 make functional tests for context controller run 2012-04-30 13:56:39 +02:00
Reinier Balt
76340b780c Getting functional tests running. 2012-04-30 13:56:38 +02:00
Reinier Balt
86afd42148 Work in progress: has_many_polymorphs does not work with rails 3.2 because of intrusive changes in rails internals. I think we need to rip out this dependency... 2012-04-30 13:56:34 +02:00
Reinier Balt
a83c8b3f92 initial upgrade to rails 3.2.3 2012-04-30 13:56:33 +02:00
Reinier Balt
1d1031dd55 fix #1280. Thanks Christian and Darian 2012-04-16 13:25:28 +02:00
Reinier Balt
12d8915eda Get all non-cucumber tests passing 2012-04-12 12:47:25 +02:00
Reinier Balt
bb8b5a4c72 store rendered notes of todos in database to avoid costly rendering when you load a page 2012-04-12 11:34:08 +02:00
Reinier Balt
b2e6253b4c restore all associations for tags. All tests are passing 2012-04-11 11:37:22 +02:00
Reinier Balt
b2e34d4694 remove has_many_polymorphs 2012-04-11 11:37:22 +02:00
Reinier Balt
dcb155d90d fix #1271. Don't block an already blocked todo. Create tests for this case 2012-04-08 15:19:42 +02:00
Reinier Balt
d8b5c7d0d2 cleanup old selenium initializer stuff and migrate edit_a_todo 2012-03-19 14:06:33 +01:00
Reinier Balt
4a8fdbabc2 migrate context and context_list features. Drag and drop is still WIP 2012-03-19 14:06:32 +01:00
Reinier Balt
906ff11633 fix failing test and make sure that you can supply 'starred' tag. Refactor todo model 2011-11-16 16:37:04 +01:00
Demian Gemperli
fafbdae079 Logut user after password change, Closes #1047 2011-10-24 21:47:15 +02:00
Stefan Richter
78e3109c91 fixing bug #1187 - dependency is no longer needed 2011-10-06 00:04:59 +02:00