Commit graph

313 commits

Author SHA1 Message Date
Jyri-Petteri Paloposki
86e36b07a6 Fix syntax errors for upgrade of Rails version 2024-06-06 01:43:48 +03:00
Jyri-Petteri Paloposki
d4c9041ccd More code style fixes 2021-01-06 03:47:35 +02:00
Jyri-Petteri Paloposki
45f5c1d3a4
Merge pull request #2535 from TracksApp/bug/2534_calendar_due_fix
#2534: Fix setting the due date in the calendar view.
2021-01-05 07:33:26 +02:00
Jyri-Petteri Paloposki
680fc3df8b #2534: Fix setting the due date in the calendar view. Reverts abad8c7 partly. 2020-12-27 17:15:15 +02:00
Jyri-Petteri Paloposki
03ab384b9c Fix the tag-specific listing to fetch the user's specific tag instead of the first one in a multi-user environment. 2020-12-11 17:55:54 +02:00
Jyri-Petteri Paloposki
371f8d5adf Coding style fixes 2020-10-27 21:00:19 +02:00
Jyri-Petteri Paloposki
67a426a2e9 More code climate style fixes 2020-10-10 15:24:01 +03:00
Jyri-Petteri Paloposki
d8acf60049 Code style fixes 2020-10-10 05:14:24 +03:00
Jyri-Petteri Paloposki
abad8c77ee #2472: Fix fetching calendar ID on task update. Didn't figure out when this has been broken – could be c66ce02cb, but not sure how. 2020-09-06 14:06:57 +03:00
Jyri-Petteri Paloposki
e3b064638c #2471: Fix a syntax error probably caused by c66ce02cb when @original_item is nil 2020-09-06 02:25:22 +03:00
Jyri-Petteri Paloposki
bbb9fc8809 Make LIKE searches case-insensitive also on PgSQL 2020-09-05 02:17:32 +03:00
Matt Rogers
c2a882ceac
Merge pull request #2301 from ZeiP/feature/#2072_tag_sanitize
#2072: Remove needless sanitisation of tags. The sanitised version is…
2020-01-03 11:54:05 -06:00
Jan-Yves Ruzicka
c66ce02cb6 Refactor todos_controller and todos_helper to use @original_item
Project uses properties of @original_item over a number of similar-named
variables (eg. @original_item_description, @original_item_was_pending, etc.)

Have left in @original_item_due_date and @original_completed_period as these
are more complex, and not simply properties of the todo item.
2019-11-17 16:03:40 +13:00
Jyri-Petteri Paloposki
e0aa0ac69e #2072: Remove needless sanitisation of tags. The sanitised version is only used in DB queries, which handle escaping themselves; the actual UI XSS sanitisation is handled separately. 2019-11-14 02:16:59 +02:00
Jyri-Petteri Paloposki
f6d1f243c5 #1955: Use existing user parameter in taggable models instead of passing it 2019-06-26 00:19:32 +03:00
Jyri-Petteri Paloposki
5394973346 #1955: Migrate tags to belong to named users for enhanced privacy. 2019-06-25 11:37:34 +03:00
Jyri-Petteri Paloposki
e66511c34e #2249: Add space between sentences 2019-06-10 20:43:00 +03:00
Matt Rogers
8bf0627d41
Merge pull request #2210 from ZeiP/bug/2032_api_filters
#2032: Use context and project filters in API also when not requestin…
2019-05-12 13:52:19 -05:00
Jyri-Petteri Paloposki
8c5edd2dcf #2032: Use context and project filters in API also when not requesting only done items 2019-05-04 22:47:39 +03:00
Jyri-Petteri Paloposki
d3ba80c84e #2203: Allow using REST API with token 2019-05-04 20:31:32 +03:00
Jyri-Petteri Paloposki
b9a80a385e #2036: Change empty XML responses to have the correct base element 2019-05-03 11:47:05 +03:00
Matt Rogers
d08608c755
Remove the query code from TodosController
It has been completely replaced with our new query object
2019-04-11 14:38:56 -05:00
Matt Rogers
df091c7ec5
Use the results of the new query object
This confirms that we've successfully extracted the code and now we can
start removing the old code.
2019-04-07 20:08:11 -05:00
Matt Rogers
eb7c34e973
Run both the new query and the old query
Throw away the results of the new query for now. Now that we know it
will run without raising exceptions, we can replace the old query with
the new query.
2019-04-07 20:04:28 -05:00
Matt Rogers
f2647e3f94
Remove deprecations printed out in the test suite 2018-11-20 19:57:02 -06:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
Use a constant to look up a mime type is deprecated.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
b5faedb4ff
Use reload to reload AR models
Passing a boolean to the model method will stop working in Rails 5.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:12:23 -05:00
Matt Rogers
5805c511bb
Convert render :text to render :body
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter to before_action
`before_filter` has been removed in future versions of rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 12:55:27 -05:00
Dan Rice
1ba829e960 Merge branch '2.3_branch' 2016-10-15 13:13:02 -04:00
Matt Rogers
c2296b5b99 Use Arel to generate case insensitve tag searches 2016-08-25 23:10:40 -05:00
Carsten Otto
f26f72272b remove TODO from code, migrated to #2018 2016-05-29 23:03:58 +02:00
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Matt Rogers
3468d1ec13 Merge branch '2.3_branch' 2015-12-08 20:14:33 -06:00
Reinier Balt
5092b388fe Fasterer: Parallel assignment is slower
Parallel assignment is slower than sequential assignment.
Only got the low hanging fruit. There are some functions that
have multiple return values. Fixing this needs more refactoring.
2015-08-19 15:12:52 +02:00
Carsten Otto
e0143cf435 move actual activation to model
fixes #1881
2015-08-09 13:47:17 +02:00
Matt Rogers
f393afb69f Merge branch '2.3_branch'
This brings the master branch up to date with the 2.3 release branch
2015-08-07 20:27:14 -04:00
Matt Rogers
258528460d Merge pull request #1873 from C-Otto/default-context-choice-2.3
(2.3) in tag view, do not use more-or-less random context for the form
2015-08-07 20:02:01 -04:00
Matt Rogers
1c0a70df75 Merge pull request #1903 from lrbalt/fix-test-errors
Fix failing tests for non-UTC timezones
2015-08-07 19:50:58 -04:00
Reinier Balt
f2c6c2d3af show attachment in view and make it downloadable 2015-08-05 16:05:56 +02:00
Reinier Balt
e58379e81f This fixes failing tests when the timezone is different than utc
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
  date verbatim
* calling a controller will set the timezone to the preference of the
  current_user. So it could be changed while you do not realize this. I
  fixed the failing test, but problems could be elsewhere
2015-08-05 11:50:33 +02:00
Dan Rice
8dd4970b0c Merge branch '2.3_branch' 2015-06-14 18:20:08 -04:00
Dan Rice
ebec4f089d Merge pull request #1875 from C-Otto/tracks-1836
(2.3) Provide data needed for partial views
2015-06-14 18:15:59 -04:00
Carsten Otto
4ce7c6bcd4 Provide data needed for partial views
The partials for context and project need to compute the
context's/project's id, which is done based on @context/@project.
Provide this data.

Fixes #1836
2015-05-22 23:02:41 +02:00
Carsten Otto
bba13194fd show dependency validation errors in action edit form 2015-05-22 20:51:27 +02:00
Carsten Otto
fd8f4e2b32 Fix syntax 2015-05-22 20:51:27 +02:00
Carsten Otto
82ac4e22b0 fix syntax 2015-05-14 15:51:49 +02:00
Carsten Otto
dd21e7466c in tag view, do not use more-or-less random context for the form
See #1834 for a discussion
2015-05-14 15:38:37 +02:00
Carsten Otto
a29009d3da replace 'None' project by empty string, fix #440 2015-05-10 14:08:20 +02:00
Dan Rice
1dbef179a7 Revert breaking commits
This reverts the following commits:
319d4b00cd
403cc1015e
37485013a0
d08ffb3806
2015-04-14 23:28:18 -04:00