Commit graph

495 commits

Author SHA1 Message Date
Reinier Balt
77933f8908 get rid of spurious <p> that messed up output of functional tests 2010-07-27 23:03:52 +02:00
tim madden
f200739bb5 Making context name a link to the context view 2010-07-27 14:46:14 +08:00
Reinier Balt
6334a3f7d7 set defaults right when adding a new action on the mobile interface from the context or project page. Fixes #1051.
We need tests for this :-)
2010-07-26 22:09:22 +02:00
Reinier Balt
ceb4529a7c Add warning that deleting a context will also delete all actions within it. Fixes #1049. Thanks edgimar for reporting this. 2010-07-26 21:36:48 +02:00
Eric Allen
e2443dace4 Get rid of some autocomplete leftovers 2010-07-05 09:58:35 -07:00
Eric Allen
1cd748d7a2 Fix #1041 2010-07-05 09:58:25 -07:00
Eric Allen
d9d08fac35 Various improvements to context drag&drop
-Don't botch other fields on context change
-Better status message
-Flash context title on drop
-Drop target close to context name
-Bolder drop target border

Closes #1033
2010-05-17 11:36:41 -04:00
Reinier Balt
cfc6d117b8 fix #1027. Several tests were broken because of the more strict validations on the recurring_todo model 2010-05-13 18:24:26 +02:00
Eric Allen
86d7724b75 Revert "Move dependency drop target into image"
We decided that the small drop target was harder to hit, and the
justifcation for the change wasn't worth it.

This reverts commit ec68e04f27.

Conflicts:

	app/helpers/todos_helper.rb
	public/javascripts/application.js
	public/stylesheets/standard.css
2010-05-09 18:57:56 -04:00
Eric Allen
fa98c0865e Override AASM's initial state if specified
Fixes #977
2010-05-08 19:30:58 -04:00
Reinier Balt
0a95d430d4 Merge branch 'vacation-work' 2010-05-05 15:27:39 +02:00
Reinier Balt
73631e6083 Merge branch 'selenium-migrations' into vacation-work 2010-05-05 13:02:27 +02:00
Reinier Balt
0d7980e87b migrate selenium for users to cucumber 2010-05-03 21:26:48 +02:00
Reinier Balt
dc0dab9863 Merge branch '997-stats' into vacation-work 2010-05-02 18:34:10 +02:00
Reinier Balt
5c25e4569e fix #1002. every nth week was off by one week for recurring weekly todos. Thanks Thomas for spotting this.
Updated the wrong test too.
2010-05-02 18:16:29 +02:00
Reinier Balt
8bc3a484b2 fix 1018. Added validations for the recurring target of recurring todos 2010-05-02 16:41:45 +02:00
Reinier Balt
9d5503a91e fix #997. The chart with the visible actions now excludes pending actions. Also some cleanupt to use named_scope 2010-05-01 17:19:28 +02:00
Eric Allen
0c161be466 Fix recurring todo autocompleteion
* Enable rich interaction on edit (to trigger autocompleter)
* Don't try to reset autocomplete lists, since they come from the server now

Fixes #1022
2010-04-27 11:17:04 -04:00
Eric Allen
23977f3f0e Don't include completed projects in autocomplete
Closes #1026
2010-04-27 11:07:28 -04:00
Eric Allen
e1a92ced7c Don't substitute lt and gt symbols
Closes #824 (hopefully once and for all?)
2010-04-27 11:03:50 -04:00
Eric Allen
f782e0f4d4 Activate deferred todos before initting @todos 2010-04-27 10:18:07 -04:00
Reinier Balt
06ac3067d3 fix validations for daily pattern and fix disappearing target fields for recurring todos 2010-04-23 17:13:03 +02:00
Reinier Balt
38f0cf1b7a adds extensive validation to recurring todos. Fixes #967 2010-04-23 16:51:35 +02:00
Reinier Balt
33af53c313 make sure tracks does not crash on missing every_other2 for recurring todos 2010-04-19 14:05:02 +02:00
rverchere
c769b2a7eb Closes #1024. Do not create user with ldap auth if wrong password 2010-04-16 04:29:29 +08:00
rverchere
b9f1f57740 Closes #1023. Display login form when ldap is the only auth system 2010-04-16 04:29:29 +08:00
Reinier Balt
e15425d546 if every_other1 is not filled in for recurring patterns, things start to fall apart. Added basic checks. 2010-04-14 09:15:02 +02:00
Eric Allen
67df223488 Drag todos between contexts
Closes #1020
2010-04-10 16:08:09 -04:00
Eric Allen
6e65435895 Fix failing tests of context deletion
The notice causes the test to think the context name is still displayed.
Fixed by looking for the name plus an opening parenthesis, which doesn't
occur in the notice.
2010-04-10 15:14:56 -04:00
Eric Allen
a022f449c1 Fixed failing tests
- Some fixtures added by Erik Ordway broke tests
- message:// links had an edge case I broke with 68701ada
- One test had a hard-coded id that changed

Closes #1019
2010-04-09 09:34:57 -04:00
Eric Allen
68701adaca Sanitize output well, but entity-ize < and > in notes
Coming from a rich message or API call, notes can contain HTML and it
will render to the browser. Coming from a normal todo creation, though,
all < and > characters will be replaced with the corresponding entities.
This preserves HTML emails, but prevents users from breaking the layout
by entering broken HTML for todo notes.

Closes #765
2010-04-07 10:06:46 -04:00
Reinier Balt
c3b3e3ea04 Manual apply fix from 1.7_branch. Preserve database integrity for recurring todos when deleting project or context. Fixes #880. Fixes #895 2010-04-04 18:20:07 +02:00
Eric Allen
c79d1c964a Autocomplete lists should be based on "q" parameter
If you don't filter server-side, the user sees the full list until
another character is entered.
2010-04-02 13:36:59 -04:00
Eric Allen
9ab69adb38 Dynamically load autocompletes
This cuts something like 100ms off of page load times!

Closes #1011
2010-04-02 13:24:21 -04:00
Eric Allen
8de74939ea Kill HTML tags in todo notes
We still want to preserve quotes for textile, but tags of any sort
shouldn't be able to mess up the output.

Fixes #765
2010-04-02 12:53:29 -04:00
Eric Allen
d682d30e6d No reason to sanitize if we're already h()'ing
Fixes #824
2010-04-02 09:46:20 -04:00
Eric Allen
205c4e7ed4 Much smarter project note truncation
Fixes #780
2010-04-02 09:46:19 -04:00
Reinier Balt
3146fa6bd1 refactor dependency cucumber feature to use css. This saves us the extra id on the todo element that I added in the previous commit. 2010-03-25 16:34:01 +01:00
Eric Allen
4f66e463bd Move integrations JS into application.js
Closes #1016
2010-03-25 07:53:34 -04:00
Eric Allen
3c82b88720 Replace conditional with rescue's
Closes #1015, although this should really be taken care of by
finishing #1011.
2010-03-25 07:53:34 -04:00
Eric Allen
d8c477eb54 Clean up stale JS
Closes #1014
2010-03-25 07:53:33 -04:00
Reinier Balt
8dbf790810 fix cucumber story for drag and drop for dependencies. Was broken since last change of drop target to a hidden img that appears when dragging starts
not a trivial one to fix :-)
2010-03-24 17:58:15 +01:00
Eric Allen
35e15d6608 Get rid of in_place_editing plugin
Using jQuery jeditable plugin
2010-03-14 16:50:24 -04:00
Eric Allen
8b642e6b91 Get rid of auto_complete plugin
Using jQuery autocompletion now
2010-03-14 16:48:28 -04:00
Eric Allen
25f0f3dfd9 JavaScript working for subdir 2010-03-14 16:39:11 -04:00
Eric Allen
a0d12c95e9 No more bundle-fu
Using Rails 2's built-in bundling instead

I believe this closes #978
2010-03-14 16:18:13 -04:00
Eric Allen
a2f8327da4 Correct walking of entire predecessor tree
Fixes #972
2010-03-14 12:29:43 -04:00
Eric Allen
2b7d5e7a89 Re-enable rich interaction on todo edit
Fixes #1008, Fixes #1007
2010-03-14 12:23:28 -04:00
tim madden
fe978e350e Made some format edits the mobile edit screen. First, I put a size in for the description textfield. As it was, the field caused my blackberry view of the form to be tiny. putting a size in makes this field similar to the rest. Also, I expanded the notes textarea to 40 columns by 3 rows and made the tags textfield size 50 like the description 2010-03-09 12:37:52 -05:00
Eric Allen
42c4c199a9 Move edit button out of dropdown menu
Closes #976
2010-03-07 16:54:17 -05:00