Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-27 12:28:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
2536 commits 32 branches 36 tags 32 MiB
Commit graph

423 commits

Author SHA1 Message Date
Reinier Balt
b21697ed05 fix #1404. This error seems not to occur for master. 2014-01-03 15:58:22 +01:00
Reinier Balt
bd94135a5b Hopfully fix #1434 by updating selectors first. Same fix as #1431 but now for update 2013-09-05 20:09:39 +02:00
Reinier Balt
4e4c9a51af fix #1406. fix #1431. set recurring_period first before setting other attributes 2013-06-19 16:41:44 +02:00
Reinier Balt
9a6ab05eef fix #1429 by correctly handling tags with dots 
This was a very old regression. This used to work before the rails 3.2 upgrade... Added tests 
to prevent future unnoticed breakage
 2013-06-03 15:17:38 +02:00
Reinier Balt
575341bf93 Introduce #onsite_redirect_to helper for onsite redirects 
Prefer #onsite_redirect_to to #redirect_to when using untrusted input (e.g. cookies) in the redirect destination

Thanks @brynary
 2013-05-07 09:44:32 +02:00
Reinier Balt
55cc030cb7 Do not symbolize arbitray locale params 
* Validate locale is valid before assigning it
* Don't convert invalid locales to symbols (creates DoS risk)

thanks @brynary
 2013-05-07 09:44:24 +02:00
Reinier Balt
858e197c51 Disable #yaml_import action for now 
This was dead code anyway

thanks @brynary
 2013-05-07 09:43:11 +02:00
Dan Rice
7e432887dd Use default context sort order when returning autocomplete 
Fixes #1403
 2013-03-18 15:11:01 +02:00
Reinier Balt
1aafe82471 fix #1393 by calculating todo count for hidden projects too 2013-02-20 20:07:31 +01:00
Reinier Balt
7860edd369 fix #1397 by changing syntax to 1.8.7 compatible 2013-02-20 20:05:46 +01:00
Reinier Balt
28bfbe6f1d fix #1395 and speedup context.autocomplete a lot 2013-02-18 16:39:43 +01:00
Reinier Balt
1a82f68d4b fix updating dependency trees when changin a name. Including invalidating cache when 
necessary
 2013-02-17 17:37:15 +01:00
Reinier Balt
1d359b22d4 fix timing issues on failing scenarios. Fix deprecated jquery functions and update jqueryui 
Signed-off-by: Reinier Balt <lrbalt@gmail.com>
 2013-02-15 20:51:35 +01:00
Reinier Balt
e4cdf75f8c invalidate cache for both context when you drag-and-drop a todo from 
one context to another
 2013-02-13 09:07:52 +01:00
Reinier Balt
e59fa387fa fix regressions and use timecop to fix time in tests. Thanks Dan and Hans! 2013-01-06 16:01:53 +01:00
Reinier Balt
4b7bd1c414 include predecessors and successors in xml export of todos. Fixes #1377 2013-01-01 23:08:47 +01:00
Reinier Balt
bd656ee1c7 fix #1350 by removing admin_email from preferences model and add it as a site option in 
site.yml.tmpl. This one needs running migrations
 2012-12-23 21:03:37 +01:00
Dan Rice
c838272622 Fix redirect to home page after open signup 
Fixes #1349
 2012-11-29 16:27:28 -05:00
Matt Rogers
4d2f25ab20 Refactor the fetching of done todos 
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.

This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.

The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
 2012-11-27 23:07:46 -06:00
Dan Rice
504d03f989 Fix wrong page title when adding a user 
Title still says "admin user" even though subsequent users are not admins.
Add a new string to correct this.
 2012-10-26 17:19:40 -04:00
Dan Rice
5b6cbf566a Don't sort todos when counting them 
Grouping isn't as lax in PostgreSQL as it is in MySQL or SQLite. All
sort fields also need to be in the GROUP BY, or be aggregated. The order
isn't relevant when counting, so simply don't order in that case.

Fix #1336
 2012-10-04 10:43:22 -04:00
Matt Rogers
b89062913f remove code duplication 2012-09-08 13:31:22 -05:00
Matt Rogers
f9bd923205 Use a local variable instead of an instance variable 
@all_actions_per_context is not used anywhere except for in the
StatsController. It's only used in two functions and it's not used by
anything in the view.

Make it a local variable instead.
 2012-09-08 13:12:35 -05:00
Matt Rogers
d9f4226fbe Use a constant for seconds per day 
Using an instance variable for this just seems wrong.
 2012-09-08 12:55:06 -05:00
Stefan Hacker
e6afd0ac0a Fix max_actions being nil when actions_open_per_week list is empty 2012-09-03 20:43:25 +02:00
Stefan Hacker
7f4065b16b Remove explicit mentioning of application layout where not needed 2012-09-03 20:24:20 +02:00
Reinier Balt
8a8dc47ab8 Try the cache_digests gem for Tracks 
cache_digests will be part of Rails 4
 2012-09-02 15:13:28 +02:00
Stefan Hacker
27adccb6e9 Remove unused layout and clear up naming 
* scaffold.css is only used by login -> rename to login.css
* standard.html.erb is the default application layout -> rename to application.html.erb
* scaffold.html.erb is unused -> deleted
 2012-09-02 14:20:17 +02:00
Reinier Balt
10b6a9ea69 fix ordering of completed todos in context view 2012-08-12 11:27:37 +02:00
Matt Rogers
306d501e20 remove duplication in mobile cookie handling 2012-08-15 22:14:00 -05:00
Matt Rogers
b01c7878d1 Push conversion of a todo to a project down. 
Refactor the conversion of a todo to a project and move it from the
TodosController to the Project model.
 2012-08-14 19:33:54 -05:00
Reinier Balt
a37d10f57a fix #1314. Fixed security issue too 2012-07-18 12:26:46 +02:00
Reinier Balt
4e29bf69f7 fix failing tests and small refactorings 2012-07-18 11:42:26 +02:00
Reinier Balt
7c1cd2a144 fix #1310. Add test for this 
Found that I had a lot of tests commented out. They have some regressions I will fix later
 2012-07-15 21:28:42 +02:00
Reinier Balt
82bb67f518 small refactorings 2012-07-12 13:14:21 +02:00
Matt Rogers
7d0c716366 Fix a few typos in the comment 2012-07-13 20:55:53 -05:00
Reinier Balt
23b92d853a Merge pull request #84 from sukima/fix_projects_api_crash 
Fix projects api crash
 2012-07-11 06:36:51 -07:00
Reinier Balt
bd8498f39c fix #1287. Fix various small bugs and some small improvements 2012-06-29 16:48:30 +02:00
tim madden
51da342cdc harmonizing todo_tag_list and tag_list, using just the shorter tag_list 2012-06-27 13:56:56 -05:00
Reinier Balt
89f96da623 fix #1290. Actionize and alphabetize did not work for hidden projects 2012-06-27 14:40:20 +02:00
Devin Weaver
e71d23555e Fixes a crash when using the XML API 
The use of "http://localhost/projects.xml" would crash with missing
method 'all' for object 'Array'

This is because the variable @projects did not need to use all in the
XML formatting since it was already assigned above and is now an array.
 2012-06-07 15:55:26 -04:00
Devin Weaver
c2d627bb43 Removes redundent assignment of @new_project 2012-06-07 15:54:58 -04:00
Reinier Balt
436cc862d6 fix text feeds 2012-05-20 05:46:52 +02:00
Reinier Balt
5e477a4d25 first pass of all tests done 2012-05-18 15:33:47 +02:00
Reinier Balt
fc69c6cfbf get shared_add_new_todo feature to pass 2012-05-12 18:04:56 +02:00
Reinier Balt
901a5ff0d2 get project features to pass 2012-05-12 14:48:56 +02:00
Reinier Balt
005723cb4f get login, mobile and notes features passing 2012-05-12 13:37:36 +02:00
Reinier Balt
7c935652fb make search and feedlist pass 2012-05-03 23:23:31 +02:00
Reinier Balt
28b7df87a8 get edit a todo to pass 2012-05-01 17:25:45 +02:00
Reinier Balt
d7aebf03a0 get context, dependencies and admin scenarios running 2012-05-01 15:45:58 +02:00