Commit graph

1014 commits

Author SHA1 Message Date
tim madden
d11d56ec41 Fix recurring todo overlay z-index to be on top of topbar 2014-01-31 08:51:29 -06:00
Reinier Balt
13869edf8e update Gemset and fix deprecation warnings 2014-01-03 15:59:03 +01:00
Reinier Balt
b21697ed05 fix #1404. This error seems not to occur for master. 2014-01-03 15:58:22 +01:00
Reinier Balt
bd94135a5b Hopfully fix #1434 by updating selectors first. Same fix as #1431 but now for update 2013-09-05 20:09:39 +02:00
Reinier Balt
4e4c9a51af fix #1406. fix #1431. set recurring_period first before setting other attributes 2013-06-19 16:41:44 +02:00
Reinier Balt
85a41e8848 fix #1422. Changing default tags of a project is now remembered
when not updating the whole page
2013-06-04 10:49:27 +02:00
Reinier Balt
7959a4a069 fix #1419. A new todo with show_from set should not be added to the homepage 2013-06-04 10:28:29 +02:00
Reinier Balt
2dca8bc0bf fix #1417. We now handle unblocking a todo that is part of a hidden project or context 2013-06-04 10:07:40 +02:00
Reinier Balt
9a6ab05eef fix #1429 by correctly handling tags with dots
This was a very old regression. This used to work before the rails 3.2 upgrade... Added tests 
to prevent future unnoticed breakage
2013-06-03 15:17:38 +02:00
Reinier Balt
575341bf93 Introduce #onsite_redirect_to helper for onsite redirects
Prefer #onsite_redirect_to to #redirect_to when using untrusted input (e.g. cookies) in the redirect destination

Thanks @brynary
2013-05-07 09:44:32 +02:00
Reinier Balt
55cc030cb7 Do not symbolize arbitray locale params
* Validate locale is valid before assigning it
* Don't convert invalid locales to symbols (creates DoS risk)

thanks @brynary
2013-05-07 09:44:24 +02:00
Reinier Balt
858e197c51 Disable #yaml_import action for now
This was dead code anyway

thanks @brynary
2013-05-07 09:43:11 +02:00
Reinier Balt
86ceeca0ba add verbose action description to cache invariant to handle changes in this setting. fixes #1409 2013-04-29 09:58:21 +02:00
Reinier Balt
66f7fe9f2b remove caching from viewing dependencies
this causes stack overflow in some cases
2013-04-29 09:41:55 +02:00
Reinier Balt
61123ffa42 fix finding user in message_gateway 2013-04-29 09:40:53 +02:00
Dan Rice
7e432887dd Use default context sort order when returning autocomplete
Fixes #1403
2013-03-18 15:11:01 +02:00
Reinier Balt
1aafe82471 fix #1393 by calculating todo count for hidden projects too 2013-02-20 20:07:31 +01:00
Reinier Balt
7860edd369 fix #1397 by changing syntax to 1.8.7 compatible 2013-02-20 20:05:46 +01:00
Reinier Balt
fe31eb75a5 fix #1396 and add a test for it 2013-02-18 17:14:37 +01:00
Reinier Balt
28bfbe6f1d fix #1395 and speedup context.autocomplete a lot 2013-02-18 16:39:43 +01:00
Reinier Balt
1a82f68d4b fix updating dependency trees when changin a name. Including invalidating cache when
necessary
2013-02-17 17:37:15 +01:00
Reinier Balt
1d359b22d4 fix timing issues on failing scenarios. Fix deprecated jquery functions and update jqueryui
Signed-off-by: Reinier Balt <lrbalt@gmail.com>
2013-02-15 20:51:35 +01:00
Reinier Balt
e4cdf75f8c invalidate cache for both context when you drag-and-drop a todo from
one context to another
2013-02-13 09:07:52 +01:00
Reinier Balt
e59fa387fa fix regressions and use timecop to fix time in tests. Thanks Dan and Hans! 2013-01-06 16:01:53 +01:00
Reinier Balt
4b7bd1c414 include predecessors and successors in xml export of todos. Fixes #1377 2013-01-01 23:08:47 +01:00
Reinier Balt
2acfbd8f00 fix dependency features 2012-12-25 15:46:26 +01:00
Reinier Balt
b18b222834 another set of fixes for the cucumber scenario's 2012-12-24 15:36:47 +01:00
Reinier Balt
da2bee2e53 start fiingx failing cucumber scenario's and some small fixes
new capybara introduces some failing scenario's
2012-12-23 23:16:22 +01:00
Reinier Balt
bd656ee1c7 fix #1350 by removing admin_email from preferences model and add it as a site option in
site.yml.tmpl. This one needs running migrations
2012-12-23 21:03:37 +01:00
Reinier Balt
a32f928fc8 add tag_name to cache invariant 2012-12-16 17:03:23 +01:00
Reinier Balt
5454ba385f fix styling of error messages 2012-12-16 15:20:43 +01:00
Reinier Balt
9550b89b25 fix caching of todo where [C] and [P] were not part of the invariant
thus the first generated todo was cached, leading to invalid todo in other views
2012-12-05 16:38:39 +01:00
Dan Rice
268d37c02d Remove tab-indexes for recurring todo forms
Using the natural tab order makes the Create and Cancel buttons accessible.

Fixes #1371
2012-12-03 16:25:20 -05:00
Reinier Balt
b5d71190b5 Merge pull request #127 from zoombody/bug/1366-tab-order
Fix tab order when creating monthly recurring actions
2012-12-01 01:14:04 -08:00
Reinier Balt
f1006eff51 Merge pull request #126 from zoombody/fixes
Clean up HTML in mobile login
2012-12-01 01:08:21 -08:00
Reinier Balt
923cd70058 Merge pull request #125 from maddentim/fixes-recurring
Eliminating unneeded blank space character from show_date_tag
2012-12-01 01:07:50 -08:00
Dan Rice
41d8fe5550 Remove duplicate render_flash from mobile login
The flash is already rendered in the layout.

Fixes #1370
2012-11-30 23:27:54 -05:00
Dan Rice
c0056675be Fix tab order when creating monthly recurring actions
Fixes #1366
2012-11-30 23:14:36 -05:00
Dan Rice
f6d251d3a0 Fix stray HTML tags in mobile layout
Fixes #1369
2012-11-30 17:23:03 -05:00
tim madden
281cc51b3a Shrink add.png icon to be inline with other icons
Other icons are 16x16 with add.png is 32x32. This commit scales the
icon down to 16x16.

Closes #1367
2012-11-30 16:09:11 -06:00
tim madden
f7f8b79f5b Eliminating unneeded blank space character from show_date_tag
The space character causes the 'Show in x period' background color to
run into the todo description.

Closes #1368
2012-11-30 16:08:25 -06:00
Dan Rice
c838272622 Fix redirect to home page after open signup
Fixes #1349
2012-11-29 16:27:28 -05:00
Matt Rogers
4d2f25ab20 Refactor the fetching of done todos
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.

This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.

The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
2012-11-27 23:07:46 -06:00
Tim Madden
8cef2b41c1 Creating new todo link for context headers 2012-11-26 10:14:55 -06:00
Dan Rice
bdbb1dd29d Render collapse/expand buttons using CSS instead of JS
Fix #1354
Also clean up some dependent JS unused since c64e1bc
2012-11-14 22:01:43 -05:00
Dan Rice
504d03f989 Fix wrong page title when adding a user
Title still says "admin user" even though subsequent users are not admins.
Add a new string to correct this.
2012-10-26 17:19:40 -04:00
Dan Rice
beaa069340 Cleanup footer links
Minor fixes as a follow-up to #1340
* Assembla is HTTPS-only
* Mailing list is members-only, so link to the group instead and call it
  "mailing list" instead of "email"
* getontracks.org's canonical URL has no www
* Make the same changes to the mobile footer
* The forum is no longer referenced, so purge from translations
2012-10-26 17:04:56 -04:00
Dan Rice
53074136d3 Replace hard-coded footer link to mobile site 2012-10-25 21:52:09 -04:00
Dan Rice
ff4d639142 Fix visible HTML tags in mobile flash 2012-10-25 21:24:04 -04:00
Dan Rice
8c56444f96 Render task-complete checkbox for mobile
Fixes #1346
2012-10-25 21:15:35 -04:00