Commit graph

4324 commits

Author SHA1 Message Date
Matt Rogers
c3a13bca16
Fix the undefined reference to Staleness
Not sure what's going on with Rails' autoloading here, so fix it the
ruby way by using plain ol' `require`
2018-11-12 08:55:42 -06:00
Matt Rogers
c19be59ca5
Merge pull request #2136 from TracksApp/dependabot/bundler/rack-2.0.6
[Security] Bump rack from 2.0.5 to 2.0.6
2018-11-06 11:44:12 -06:00
dependabot[bot]
fa81c7afa0
[Security] Bump rack from 2.0.5 to 2.0.6
Bumps [rack](https://github.com/rack/rack) from 2.0.5 to 2.0.6. **This update includes security fixes.**
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/2.0.5...2.0.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-06 00:28:33 +00:00
Matt Rogers
7a94631a5c
Merge pull request #2135 from TracksApp/add-application-record
Convert to ApplicationRecord
2018-11-03 16:08:32 -05:00
Matt Rogers
0e21d64890
Convert to ApplicationRecord
Rails 5 requires the use of this superclass for all database backed
model objects now.
2018-11-03 15:57:14 -05:00
Matt Rogers
35e6384b95
Merge pull request #2134 from TracksApp/remove-rails-51-deprecations
Remove all the deprecations seen in the tests
2018-11-03 15:47:14 -05:00
Matt Rogers
6e5dcb082b
Remove raise_in_transactional_callbacks
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:30:14 -05:00
Matt Rogers
735c6848fc
Use hash style syntax to get errors
ActiveModel::Errors#get is deprecated, has no effect, and will be
removed without replacement.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:23:56 -05:00
Matt Rogers
6e48ce6594
Compare items of the same type
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:19:57 -05:00
Matt Rogers
908f021aa5
Stop using a deprecated method to reload an association
Use `reload` instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:16:00 -05:00
Matt Rogers
6d81e14b41
Use a non deprecated method to collect errors
Hash-based access to set an error is deprecated. Use
ActiveModel::Errors.add instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:12:27 -05:00
Matt Rogers
1eb892a473
Don't convert ActionController::Parameters to a hash
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:07 -05:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
Use a constant to look up a mime type is deprecated.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
2f85a42f91
Use the keyword args syntax for controller actions
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
dependabot[bot]
05ef3e56df
Bump bootstrap-sass from 3.3.3 to 3.3.7
Bumps [bootstrap-sass](https://github.com/twbs/bootstrap-sass) from 3.3.3 to 3.3.7.
- [Release notes](https://github.com/twbs/bootstrap-sass/releases)
- [Changelog](https://github.com/twbs/bootstrap-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twbs/bootstrap-sass/compare/v3.3.3...v3.3.7)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-02 05:38:55 +00:00
dependabot[bot]
289fdfc841
Bump factory_bot_rails from 4.10.0 to 4.11.1
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 4.10.0 to 4.11.1.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS)
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v4.10.0...v4.11.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-01 22:27:12 +00:00
Matt Rogers
755a7a1b80
Merge pull request #2122 from greysteil/dependabot/bundler/loofah-2.2.3
[Security] Bump loofah from 2.2.2 to 2.2.3
2018-11-01 17:25:36 -05:00
dependabot[bot]
510984e965
[Security] Bump loofah from 2.2.2 to 2.2.3
Bumps [loofah](https://github.com/flavorjones/loofah) from 2.2.2 to 2.2.3. **This update includes security fixes.**
- [Release notes](https://github.com/flavorjones/loofah/releases)
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md)
- [Commits](https://github.com/flavorjones/loofah/compare/v2.2.2...v2.2.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-30 14:08:24 +00:00
Matt Rogers
a3344026c9
Merge pull request #2121 from TracksApp/upgrade-to-rails-5-0
Upgrade to Rails 5.0
2018-10-27 13:48:40 -05:00
Matt Rogers
fd2f49596c
Update test with the proper param structure
Fixes the test failure we were seeing here.
2018-10-27 13:33:40 -05:00
Matt Rogers
36e59746ea
Add the environment setup for Rails 5 2018-10-27 12:28:29 -05:00
Matt Rogers
6e70fcbe5e
Update how the sorting is done in the User model
Use the `sort_by` method to do the sorting rather than converting to an
array and then calling `sort`

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:22 -05:00
Matt Rogers
859701a81f
Update configuration after the Rails upgrade
Ran `bin/rake rails:upgrade` and went through all the changes.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:07 -05:00
Matt Rogers
c7b9f008a6
Use puma instead of thin
Puma has become the default and has some really nice integration points
in Rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:26:48 -05:00
Matt Rogers
57ae87cccb
Initial gem update to Rails 5.x
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:26:44 -05:00
Matt Rogers
1d9c947705
Merge pull request #2120 from TracksApp/remove-testing-cruft
Update some testing practices to use more relevant methods
2018-10-21 13:45:11 -05:00
Matt Rogers
edd0559da1
Fix the mixed-indent in NotesControllerTest 2018-10-19 11:35:52 -05:00
Matt Rogers
71c95c0d01
Switch assert_not_equal to refute_equal
Preferring to use minitest methods here instead of test-unit.
2018-10-19 11:35:52 -05:00
Matt Rogers
dea3b1b58e
Update to a more performant random string implementation
Since `SecureRandom.alphanumeric` is Ruby 2.5 only, we can't use that
for now. Implement a new version until we can get Tracks updated to that
version.
2018-10-19 11:35:52 -05:00
Matt Rogers
bb8fd08685
Remove the assert_value_changed helper
It's only used in one place and it's easy enough to rewrite this into
something more straightforward and less clever.
2018-10-17 21:22:13 -05:00
Matt Rogers
cf6f9de377
Merge pull request #2115 from hewo/feature_search_in_navbar
Feature search in navbar
2018-09-23 13:55:26 -05:00
Matt Rogers
303bee0244
Merge pull request #2117 from TracksApp/rails-syntax-updates
Compatibility updates for newer versions of Rails
2018-09-23 13:55:08 -05:00
Matt Rogers
b5faedb4ff
Use reload to reload AR models
Passing a boolean to the model method will stop working in Rails 5.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:12:23 -05:00
Matt Rogers
506f3f991a
Convert render :nothing => true to head :ok
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:06:38 -05:00
Matt Rogers
17f704a074
Convert after_filter to after_action
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:04:46 -05:00
Matt Rogers
5805c511bb
Convert render :text to render :body
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter to before_action
`before_filter` has been removed in future versions of rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 12:55:27 -05:00
Heiner Wohner
4b8c66b1f9 Merge branch 'master' into feature_search_in_navbar 2018-09-17 18:00:22 +02:00
Matt Rogers
dab358cad0
Merge pull request #2116 from hewo/feature_rails_update_4_2_10
Feature rails update 4.2.10
2018-09-13 21:31:31 -05:00
Matt Rogers
e8acabcd8f
Merge pull request #2114 from greysteil/dependabot/bundler/rubyzip-1.2.2
Bump rubyzip from 1.2.1 to 1.2.2
2018-09-04 13:18:23 -05:00
Heiner Wohner
3786d12e5a removes bootstrap css class from main view 2018-09-03 13:30:48 +02:00
Heiner Wohner
5117ec7d99 add searchbar to navbar 2018-09-03 12:39:05 +02:00
dependabot[bot]
ef33f0d292
[Security] Bump rubyzip from 1.2.1 to 1.2.2
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.1 to 1.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.1...v1.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-31 18:01:59 +00:00
Heiner Wohner
edcef6c624 Merge branch 'master' of https://github.com/TracksApp/tracks 2018-08-30 17:29:18 +02:00
Heiner Wohner
9fa6f16895 updates Rails to 4.2.10 2018-08-30 16:22:35 +02:00
Matt Rogers
19220497db
Merge pull request #2113 from ericmoon/test-cleanup
Test cleanup
2018-08-04 13:31:35 -05:00
ericmoon
a92317f0b5 stupid typos 2018-08-02 11:58:56 -07:00
ericmoon
589ee75168 another assert_nil hack 2018-08-02 11:52:01 -07:00
ericmoon
04d5e764b2 typo fix 2018-08-02 11:43:48 -07:00
ericmoon
429a22778c hack to remove minitest deprecation warnings 2018-08-02 11:31:50 -07:00