Matt Rogers
32d267d6cd
Remove private variable usage from models
...
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
6e48ce6594
Compare items of the same type
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:19:57 -05:00
Matt Rogers
71c95c0d01
Switch assert_not_equal to refute_equal
...
Preferring to use minitest methods here instead of test-unit.
2018-10-19 11:35:52 -05:00
Matt Rogers
bb8fd08685
Remove the assert_value_changed helper
...
It's only used in one place and it's easy enough to rewrite this into
something more straightforward and less clever.
2018-10-17 21:22:13 -05:00
ericmoon
a92317f0b5
stupid typos
2018-08-02 11:58:56 -07:00
ericmoon
589ee75168
another assert_nil hack
2018-08-02 11:52:01 -07:00
ericmoon
04d5e764b2
typo fix
2018-08-02 11:43:48 -07:00
ericmoon
429a22778c
hack to remove minitest deprecation warnings
2018-08-02 11:31:50 -07:00
ericmoon
fa7f2a777b
assert_equal nil deprecated: replace with assert_nil
2018-08-02 10:57:11 -07:00
Carsten Otto
ed3bca22a4
Remove 'project_hidden' state
...
Compute it using project/context state
Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Jan-Yves Ruzicka
ccf13418f4
Extract rendering to helper method. Shift filename sanitization to controller.
2016-02-02 11:08:12 +00:00
Matt Rogers
42ab5e3000
Merge pull request #1951 from C-Otto/show_from_midnight
...
when recurring todos always use midnight for "show from"
2016-01-21 16:13:30 -06:00
Carsten Otto
b788194f8d
fix test
2015-12-13 16:12:45 +01:00
Carsten Otto
cd09cce7a4
when recurring todos always use midnight for "show from"
...
fixes #1940
2015-12-13 15:44:40 +01:00
Matt Rogers
3468d1ec13
Merge branch '2.3_branch'
2015-12-08 20:14:33 -06:00
Nascher
dd6698b8a1
Update the maximum password length
2015-08-29 23:58:02 +00:00
Reinier Balt
ddd9c07d3b
Fasterer: Use &:symbol is faster
...
Calling argumentless methods within blocks is slower than using
symbol to proc.
2015-08-19 14:48:31 +02:00
Carsten Otto
e0143cf435
move actual activation to model
...
fixes #1881
2015-08-09 13:47:17 +02:00
Matt Rogers
a9023960fc
Merge pull request #1848 from C-Otto/tracks-1847
...
Fix description of monthly recurring tests
2015-08-07 20:29:40 -04:00
Matt Rogers
f393afb69f
Merge branch '2.3_branch'
...
This brings the master branch up to date with the 2.3 release branch
2015-08-07 20:27:14 -04:00
Matt Rogers
efbf881742
Merge pull request #1872 from C-Otto/create-reviewed-2.3
...
(2.3) create projects as reviewed at creation time
2015-08-07 19:59:57 -04:00
Matt Rogers
1c0a70df75
Merge pull request #1903 from lrbalt/fix-test-errors
...
Fix failing tests for non-UTC timezones
2015-08-07 19:50:58 -04:00
Reinier Balt
2bd68fecb7
Create attachment model and hook it up to todo
...
An attachment has write permissions on group so that managing
attachments work from different users in same group, i.e. user apache
and user mail.
2015-08-05 16:05:19 +02:00
Reinier Balt
e58379e81f
This fixes failing tests when the timezone is different than utc
...
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
date verbatim
* calling a controller will set the timezone to the preference of the
current_user. So it could be changed while you do not realize this. I
fixed the failing test, but problems could be elsewhere
2015-08-05 11:50:33 +02:00
Carsten Otto
67ced62096
Projects with completed actions may be blocked
...
Currently, a project cannot be blocked if at least one completed
action exists. This was introduced in
acab98d4c7 ,
and I assume this change was not intended
2015-06-16 20:44:26 -04:00
Dan Rice
5bf60bb0e6
Merge pull request #1808 from C-Otto/blocked_projects
...
Projects with completed actions may be blocked
2015-06-16 20:44:17 -04:00
Carsten Otto
6014ce7a6f
create projects as reviewed at creation time
...
Fixes #1788
2015-05-22 23:12:45 +02:00
Carsten Otto
47d0364dbd
fix test
...
every_other3 encodes 1:first to 4:fourth and 5:last weekday of month
every_other2 encodes every nth month
2015-05-10 14:11:08 +02:00
Carsten Otto
a29009d3da
replace 'None' project by empty string, fix #440
2015-05-10 14:08:20 +02:00
Carsten Otto
cc88d24d79
Projects with completed actions may be blocked
...
Currently, a project cannot be blocked if at least one completed
action exists. This was introduced in
acab98d4c7 ,
and I assume this change was not intended
2015-04-15 20:46:53 +02:00
Dan Rice
1dbef179a7
Revert breaking commits
...
This reverts the following commits:
319d4b00cd
403cc1015e
37485013a0
d08ffb3806
2015-04-14 23:28:18 -04:00
Dan Rice
556c68c2e6
Revert breaking commits
...
This reverts the following commits:
c129b8a06f
c7c923a317
006c135a64
2015-04-14 22:26:07 -04:00
Reinier Balt
82cabf8aee
Merge pull request #1814 from C-Otto/tracks-1448
...
retain tags from action when transforming into project
2015-04-13 16:19:55 +02:00
Reinier Balt
319d4b00cd
fix failing tests with use of localtime
2015-04-13 15:57:57 +02:00
Reinier Balt
37485013a0
discard time in these tests since they are
...
irrelevant here
2015-04-13 15:43:32 +02:00
Reinier Balt
c7c923a317
discard time in these tests since they are
...
irrelevant here
2015-04-13 15:42:35 +02:00
Carsten Otto
12ee2ed5e3
typo
2015-04-13 14:38:09 +02:00
Carsten Otto
cec2e535b2
fix #1754
2015-04-13 14:37:12 +02:00
Carsten Otto
229c515e71
retain tags from action when transforming into project
2015-04-12 21:57:23 +02:00
Reinier Balt
17c5edd7ae
Merge pull request #1783 from C-Otto/bug-1778
...
do not activate already completed todos, fix #1778
2015-04-12 17:27:59 +02:00
Carsten Otto
1609546aa1
typo
2015-03-25 10:12:06 +01:00
Carsten Otto
0edc263c7e
fix #1754
2015-03-24 11:27:36 +01:00
Matteo Giaccone
d7fbcb10c4
Fix #1722
2015-02-22 17:04:46 -05:00
Matteo Giaccone
ed9063bffa
Fix #1722
2015-02-22 18:54:24 +00:00
Carsten Otto
dfe8735c0d
rename repeating -> recurring, repeat -> recurrence
2015-02-10 16:25:27 +01:00
Carsten Otto
d480569629
occurence -> occurrence
2015-02-10 15:49:13 +01:00
Carsten Otto
bef79d135a
fix test error message
2015-02-09 23:24:19 +01:00
Carsten Otto
705f307bfb
fix typos
2015-02-09 23:24:19 +01:00
Matteo Giaccone
13f8023ca0
Fix #1724
2015-01-01 18:16:40 -05:00
Matteo Giaccone
0d6e0efcee
Fix warnings for Ruby 2.2 update
2015-01-01 13:43:48 -05:00