Commit graph

2231 commits

Author SHA1 Message Date
Sebastian Fischmeister
725ff5e0fa don't execute a query when limit == 0 2012-02-14 10:16:29 -05:00
Matt Rogers
67b8a11600 Merge pull request #62 from Popsch/review_tests_rebase
cucumber tests for the review mode
2012-02-10 08:27:54 -08:00
Matt Rogers
e7268fbaa2 Remove the double-quote custom validation
Rails has had SQL injection prevention since at least 2009 so we don't
need our version of it anymore.

Fixes ticket #1237
2012-02-02 22:28:26 -06:00
Reinier Balt
71cd34a35f fix #1239. Context helper was missing in search controller
Conflicts:

	app/controllers/search_controller.rb
2012-01-31 12:12:58 +01:00
Sebastian Fischmeister
d14a2a808d cucumber tests for the review mode 2012-01-30 09:56:58 -05:00
Reinier Balt
8f5c04522e Merge pull request #56 from Popsch/update_template_script
updated the template script
2012-01-30 06:46:46 -08:00
Reinier Balt
e935066c18 fix #1181. The project listing now had the small drag handle and all the controls to the left. 2012-01-27 10:55:39 +01:00
Reinier Balt
8b13ee88ab fix #1234 by checking on :review source view 2012-01-23 12:27:49 +01:00
Reinier Balt
b7ee2f79f5 Fix #1030. add basic test for new chart. 2012-01-21 20:29:59 +01:00
Reinier Balt
1bce9a670d implement #1030. 2012-01-21 20:20:24 +01:00
Reinier Balt
bc7bf459db fix small regressions 2012-01-20 23:50:27 +01:00
Reinier Balt
7af2211479 finalize refactoring
finally done, now for ticket 1030 :-)
2012-01-20 23:35:01 +01:00
Reinier Balt
78a2bd7f49 further refactoring of stats controller and views 2012-01-20 23:35:00 +01:00
Reinier Balt
b948cc48b2 further refactoring and more tests 2012-01-20 23:35:00 +01:00
Reinier Balt
2349bee535 further refactorings and tests
one test is failing, will fix that next time
2012-01-20 23:34:59 +01:00
Reinier Balt
80d8d2b67a add tests 2012-01-20 23:34:59 +01:00
Reinier Balt
61624ed455 completed first pass of refactoring 2012-01-20 23:34:58 +01:00
Reinier Balt
f74370aab5 first refactoring of stats controller 2012-01-20 23:34:58 +01:00
Matt Rogers
4705aca8dc Merge pull request #59 from maddentim/mobile
DRY up the mobile interface handling by moving it back into toggle_check
2012-01-19 08:26:31 -08:00
tim madden
01f283bc31 Do not need this mobile_done in routes any longer. 2012-01-16 11:46:49 -06:00
tim madden
250e1d8fcc folding mobile_done method into original toggle_check method
the mobile_done method was created to test out a checkbox submit
the mobile interface. In the interests of DRY, this brings the new
mobile code into the original method,
2012-01-16 11:37:29 -06:00
Matt Rogers
27fb483485 Fix the failing mobile test after the updates
The editing an action of the mobile page scenario failed because of the
changes to the layout made by Tim Madden.
2012-01-13 21:28:32 -06:00
Matt Rogers
99707d7a69 fix this test.
the todo comparisons are case-sensitive.
2012-01-13 21:28:32 -06:00
Matt Rogers
1be7dab631 Merge branch 'master' of github.com:TracksApp/tracks 2012-01-10 11:23:52 -06:00
Matt Rogers
1ced030681 properly filter passwords in the users controller 2012-01-10 11:20:01 -06:00
Matt Rogers
bd10e61dbd Merge pull request #58 from maddentim/defer_options
Defer options
2012-01-09 19:49:43 -08:00
Reinier Balt
f7faef3c91 fix #1203. The fix of #1152 works for IE7 too. 2012-01-04 16:08:31 +01:00
Matt Rogers
ff16cb3051 Merge pull request #57 from maddentim/mobile
Mobile interface updates
2011-12-30 20:20:40 -08:00
tim madden
e9277676b2 updates to tests for changes to mobile interface
Updated mobile_add_action.feature with new navigation text
  Updated modile_edit_a_todo.feature to not look for removed 'done' checkbox in
  the edit form, but to use the previously created "mark complete" button.
  Added completed_container to mobile_actions so the test could find the
  completed todo that is no longer not visible
2011-12-20 10:35:21 -06:00
Sebastian Fischmeister
e0f7eec171 added verbose option 2011-12-20 10:27:56 -05:00
Tim Madden
c7cd46ee1d update to mobile todo edit view
removing the done checkout
   (with new intermediate mobile todo view with done button, this is
    needed)
rearranging fields to put the most important fields first
2011-12-19 21:14:38 -06:00
Tim Madden
eaa4a46359 theming mobile layout to mirror standard layout styling
the span with class m_t and m_t_d and its styling are no longer needed
  mobile todo lists need to be wrapped in ul element. fixing up missing or unclosed
2011-12-19 21:14:38 -06:00
Tim Madden
8ed13fc6c2 removing numbers and shortening nav links to stop wrapping 2011-12-19 21:14:38 -06:00
tim madden
d0e7264661 changes for done checkbox on mobile page
adding recent completed todos in case you accidentally tick one by mistake
2011-12-19 21:10:19 -06:00
tim madden
2904bc9532 Adding more options for deferring + shortening the one day so it stops wrapping 2011-12-19 21:07:35 -06:00
Matt Rogers
beb18ac1f4 Hidden projects are not stalled. Update the comment. 2011-12-19 12:30:51 -06:00
Craig Maloney
48de4b1b00 Keep hidden projects from showing up as stalled, since they're likely hidden for a reason. 2011-12-19 12:28:57 -06:00
Matt Rogers
70f06bd76e Align the actions for an action row to a common baseline.
This adds some margin to the top of the checkboxes in order to align the
star, checkbox, and pencil icons along the same baseline.

My eyes no longer hurt from the differences in alignment. :)
2011-12-19 12:18:34 -06:00
Matt Rogers
c8da3ddf88 Tiny formatting fix 2011-12-19 12:17:59 -06:00
Matt Rogers
f7875d57af Soften the UI a bit with some rounded edges.
The badge in the header are now rounded.

The corners of the groups in the project page are also now rounded.

The rounding is done with CSS3, with specific markup for Firefox and
Webkit-based browsers. IE versions less than 9 are not supported.
2011-12-19 12:10:18 -06:00
Sebastian Fischmeister
353c1b3dd1 updated the script 2011-12-17 12:56:39 -05:00
Matt Rogers
00e9cab309 The test is no longer a work in progress 2011-12-12 21:56:27 -06:00
Matt Rogers
c1e489a70e Fix up the step definitions so the test passes 2011-12-12 21:56:27 -06:00
Matt Rogers
b5c792ce83 Add step definitions for testing double project name editing
Some steps are still pending though.
2011-12-12 21:56:27 -06:00
Matt Rogers
3f64fc1bed Add a feature to prevent project editing in two places at once
Still marked as wip for the moment. Will unmark it after it passes.
2011-12-12 21:56:27 -06:00
Matt Rogers
6599b11628 Remove dead code.
This code is no longer used in the system.
2011-12-12 21:56:27 -06:00
Matt Rogers
64cf5336c1 Don't allow the project name to be edited in two places at once
When showing the project edit form, we disable the ability to edit the
project name in place. When the project edit form is saved or cancelled,
then we reenable the editing of the project name in place.

Fixes #1205
2011-12-12 21:56:27 -06:00
Matt Rogers
a2df36cf71 Hide the editor when the project name field loses focus
If the project name field is being edited and it loses focus, then we
remove the edit box and the buttons. This reduces the possibility to be
able to edit the project name from more than one place as in #1205.
2011-12-12 21:56:27 -06:00
Matt Rogers
b0a559d899 fixup some jslint errors 2011-12-12 21:56:27 -06:00
Matt Rogers
41934a3da6 Merge branch 'master' of github.com:TracksApp/tracks 2011-12-12 21:54:48 -06:00