Reinier Balt
|
0d0b36de29
|
remove duplication in feedlist controller
|
2013-05-11 10:49:38 +02:00 |
|
Reinier Balt
|
cdfb65d529
|
remove duplication of all_done_todos and done_todos in project and context container
|
2013-05-11 10:38:34 +02:00 |
|
Reinier Balt
|
101268f504
|
Introduce #onsite_redirect_to helper for onsite redirects
Prefer #onsite_redirect_to to #redirect_to when using untrusted input (e.g. cookies) in the redirect destination
Thanks @brynary
|
2013-05-07 09:41:48 +02:00 |
|
Reinier Balt
|
78f81ed29f
|
Do not symbolize arbitray locale params
* Validate locale is valid before assigning it
* Don't convert invalid locales to symbols (creates DoS risk)
thanks @brynary
|
2013-05-07 09:29:47 +02:00 |
|
Reinier Balt
|
0cc41bda87
|
Disable #yaml_import action for now
This was dead code anyway
thanks @brynary
|
2013-05-07 09:07:57 +02:00 |
|
Reinier Balt
|
7efb155928
|
fix regression
|
2013-05-05 20:54:12 +02:00 |
|
Reinier Balt
|
ccdaae038b
|
small refactorings
|
2013-05-05 20:32:32 +02:00 |
|
Reinier Balt
|
89cdfbc606
|
fix failing tests on ruby 1.9.3
funny, this is the first one not failing on 2.0.0 but failing on 1.9.3. Thanks for Travis!
|
2013-05-04 13:44:45 +02:00 |
|
Reinier Balt
|
5cfa115cdc
|
small refactorings
fix passing params in use of _collection
|
2013-05-03 21:54:03 +02:00 |
|
Reinier Balt
|
f891ee86fe
|
fix clearing show_from fails
caused by slightly different (better) workings of aasm
|
2013-05-03 19:28:26 +02:00 |
|
Matt Rogers
|
883ea2b968
|
Move Project#create_from_todo to its own class
The point of this is to keep as many things out of the ActiveRecord
objects as possible and use them as just a thin database abstraction
layer.
|
2013-05-02 22:30:24 -05:00 |
|
Matt Rogers
|
55eb7b818c
|
Revert "Use an attr_reader for attributes"
This reverts commit 6376bd7ef6.
|
2013-04-30 23:02:54 -05:00 |
|
Matt Rogers
|
49886b1bd3
|
Revert "Cache the project and context names"
This reverts commit 610152b8dd.
|
2013-04-30 23:01:46 -05:00 |
|
Matt Rogers
|
c1597a7751
|
Rename to_xml_params to todo_xml_params
|
2013-04-30 22:52:22 -05:00 |
|
Matt Rogers
|
8fe343cccc
|
Push to_xml_params down to ApplicationController
|
2013-04-30 22:50:32 -05:00 |
|
Matt Rogers
|
98b188d1df
|
Add tests for the ICS and XML views and fix them up
|
2013-04-30 20:38:10 -05:00 |
|
Matt Rogers
|
ebd182695d
|
remove the calendar from TodosController
|
2013-04-30 20:35:13 -05:00 |
|
Matt Rogers
|
83273ac342
|
add the before filter configuration back
|
2013-04-30 20:19:27 -05:00 |
|
Matt Rogers
|
d1ff0daf6f
|
Move the calendar to its own controller
|
2013-04-30 20:09:46 -05:00 |
|
Matt Rogers
|
610152b8dd
|
Cache the project and context names
|
2013-04-29 21:01:30 -05:00 |
|
Matt Rogers
|
6376bd7ef6
|
Use an attr_reader for attributes
|
2013-04-29 21:01:30 -05:00 |
|
Matt Rogers
|
1c2de3fd5a
|
Remove codejunk
Extra whitespace, explicit returns, and an extra begin/end pair are all
gone.
|
2013-04-29 21:01:21 -05:00 |
|
Matt Rogers
|
b1fb1dd326
|
Remove more duplication from Todos::Calendar.
|
2013-04-29 16:35:50 -05:00 |
|
Matt Rogers
|
fedfb55ff8
|
Remove extra whitespace
|
2013-04-29 15:24:32 -05:00 |
|
Reinier Balt
|
010d0e9ba0
|
refactor creating todos in todos_controller
|
2013-04-29 15:15:48 +02:00 |
|
Reinier Balt
|
5ed69fc1a2
|
update gems and fix failures from new aasm
I'm not sure the test failures caused by reload not working are caused by the new aasm,
perhaps the thread isolation is causing that...
|
2013-04-29 11:53:32 +02:00 |
|
Reinier Balt
|
93b0a2557c
|
add verbose action description to cache invariant to handle changes in this setting. fixes #1409
|
2013-04-29 09:58:54 +02:00 |
|
Reinier Balt
|
98f8cade5b
|
fix finding the used in the message_gateway
|
2013-04-29 09:38:34 +02:00 |
|
Matt Rogers
|
8db5793bf6
|
Merge pull request #178 from TracksApp/rename-has-next-todo
Rename RecurringTodo#has_next_todo
|
2013-04-27 09:52:58 -07:00 |
|
Matt Rogers
|
6b8e745234
|
Use Todos::Calendar in the view
|
2013-04-26 23:23:56 -05:00 |
|
Matt Rogers
|
fb71441436
|
Start using Todos::Calendar in the calendar action
Replaces the existing query logic in a lot of places
|
2013-04-26 23:09:47 -05:00 |
|
Matt Rogers
|
ba38277df8
|
Add a Todos::Calendar object
|
2013-04-26 23:08:56 -05:00 |
|
Matt Rogers
|
c4bcc0996f
|
Remove extra whitespace
|
2013-04-26 16:30:40 -05:00 |
|
Matt Rogers
|
88e7798db6
|
Rename RecurringTodo#has_next_todo to continues_recurring?
This clarifies the intent of the method.
|
2013-04-26 16:30:12 -05:00 |
|
Matt Rogers
|
036c34f266
|
Rename RecurringTodo#inc_occurences to increment_occurrences
This clarifies the method name and fixes a typo.
|
2013-04-26 16:20:42 -05:00 |
|
Matt Rogers
|
1431bef1a9
|
Use first_or_create to creating missing Tags
|
2013-04-26 08:46:06 -05:00 |
|
Matt Rogers
|
3425b3fa10
|
Remove duplication when setting up done by tag views
|
2013-04-26 08:40:24 -05:00 |
|
Matt Rogers
|
6af7fe0ab6
|
Remove unused method
|
2013-04-26 08:31:00 -05:00 |
|
Matt Rogers
|
56f366b432
|
Remove context_specified_by_name from TodosController
Use TodoCreateParamsHelper instead to remove the duplication
|
2013-04-26 08:04:22 -05:00 |
|
Matt Rogers
|
d5dc723ef0
|
Remove project_specified_by_name from TodoController
Use TodoCreateParamsHelper instead here and remove the duplication
|
2013-04-26 08:02:47 -05:00 |
|
Matt Rogers
|
445a0c7602
|
Remove trailing whitespace
|
2013-04-26 07:55:06 -05:00 |
|
Matt Rogers
|
a60b4389cd
|
Fix a bug when generating predecessor autocomplete data
|
2013-04-25 21:13:49 -05:00 |
|
Matt Rogers & Katrina Owen
|
a1b270699d
|
Extract creation of todos from recurrings todos
|
2013-04-25 20:45:14 -05:00 |
|
Reinier Balt
|
0607096e7c
|
add cucumber tests for tickler with group by project
|
2013-04-24 23:30:58 +02:00 |
|
Reinier Balt
|
a987ff3727
|
use size in stead of count to prevent unnecessary querying
|
2013-04-22 11:11:53 +02:00 |
|
Reinier Balt
|
caec4f214a
|
enable group by project for tickler
|
2013-04-20 20:20:57 +02:00 |
|
Reinier Balt
|
8b464112ad
|
further fixing regressions
|
2013-04-19 22:55:54 +02:00 |
|
Reinier Balt
|
d732779e14
|
#1411 also fails on project list page, so fix that too
|
2013-04-19 15:26:34 +02:00 |
|
Reinier Balt
|
549aa35e61
|
fix #1411 where the context list page was not adding new context on the page after the last was deleted.
|
2013-04-19 15:23:28 +02:00 |
|
Reinier Balt
|
9172d5e001
|
fix failing scenario
|
2013-04-17 23:26:46 +02:00 |
|