Commit graph

102 commits

Author SHA1 Message Date
lukemelia
06f14dd3b9 And here's the copy step.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@501 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-30 04:36:52 +00:00
lukemelia
c34d9faa38 Arg. Branching never seems to "just work". Going to delete and recopy. Here's the delete step.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@500 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-30 04:36:14 +00:00
lukemelia
8e719d9e9a Added message to contexts page when no contexts exist. Fixes #476.
Also tweaked a couple of selenium login tests to make them work properly if run alone.
 


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@488 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-28 05:08:55 +00:00
lukemelia
704d39add1 Blanking out a project name when editing a todo will now remove the todo from the project.
Also fixed the reference to test/selenium_helper.rb in the test/environment.rb to be pathed more reliably.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@487 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-28 04:45:39 +00:00
lukemelia
cd25d7e278 Added a set of Selenium helper classes and methods, to provide automatic login capabilities, to speed up selenium tests.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@482 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-23 06:08:36 +00:00
lukemelia
5a878b3e84 A few minor changes and bug fixes:
* On first user signup, the user no longer needs to login and after signing up. They are automatically logged in.
 * The Projects page was showing the name of the last project listed in the new project form. It is now appropriately blank.
 * When trying to create a new action, an error was occurring trying to update tags if the action failed to save. We now only try to update tags if the action saved. I wonder if we should be using some sort of ActiveRecord transaction here. If anyone knows about this, please contact me.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@481 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-22 04:37:20 +00:00
lukemelia
38b2e336a8 Implemented a feature that give a project and optional default context. When set,
this context will be pre-populated when creating an action from the project's page.
When creating an action from the home page, the context will be auto-selected when
the project is selected if the context field has not yet been entered.

This implementation is a combination of the great patch submitted by James Kebinger
(thanks James!) and some of my modifications and additions.

Don't forget to rake db:migrate.

Fixes #162, originally suggested by Rolf one year ago!

Also in this commit:

 * Tweaked selenium tags test
 * Tweaked formatting of next/previous project HTML
 * Implemented Null Object pattern for context to support
   a Project having no default context
 * Removed tickler.rhtml, no longer in use
 * applying z-index values to project sortable list items (otherwise context
   autocomplete was appearing below next list item)
 * Swapped order of project and context in new action form (setting default context
   makes more sense this way)
 * Removed CSS width of for form elements, so form could be used in content area
   without being too narrow
   


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@480 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-21 07:12:14 +00:00
lukemelia
11ed78abe2 Updated tests to pass even in the case of the weird schema (integer fields instead of booleans) that still pops up.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@479 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-20 05:06:37 +00:00
lukemelia
4c061508ce Removed test's reference to deleted FeedController class.
One thing I forgot to mention in the last commit is that the changes break feed links. If people think it's important to maintain them, we can use routes to accomplish that...

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@477 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-18 05:28:53 +00:00
lukemelia
106d5ee448 Made TodosController more RESTful and use it to fulfill all feeds, eliminating the need for the FeedController and it's helper and views. Also added an ATOM feed (not linked in the UI anywhere, just substitute .atom for .rss).
I also ran rcov on unit tests and added tests to improve test coverage, uncovering a couple of bugs along the way.

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@476 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-18 00:38:05 +00:00
lukemelia
84357b67d5 Apply Trevor Lovett's patch (#364)
"I kick off a lot of small projects, and I often want to add actions right when I create the project. This is a simple tweak that provides a check box that allows you to immediately go to the project page after creating a new project."

Thanks, Trevor. Sorry it took so long!



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@474 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-10 04:10:53 +00:00
lukemelia
85885f9b9b Add next-previous links to project detail pages. Closes #379
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@470 a4c988fc-2ded-0310-b66e-134b36920a42
2007-03-06 13:18:31 +00:00
lukemelia
1bada8f5a3 Introduced separation of projects by state (Active, Hidden, Completed) on the main Projects page. There are still some Ajax corner cases to work out, but it's perfectly usable. Closes #460.
I also refactored change password code.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@464 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-28 05:36:10 +00:00
lukemelia
0a01b138a0 The default values for Context#created_at and Project#created_at introduced in [440] were breaking rails' timestamp mixin and leaving created_at fields null. This changeset includes a migration to ensure that those columns contain no null values and backs out those changes. This fixes #454 but does risk reintroducing #438.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@461 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-27 04:07:22 +00:00
lukemelia
146c6a62f9 Added a preference for the date format of the big date at the top of each page. Fixes #348.
Remember to rake db:migrate.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@460 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-27 02:42:37 +00:00
lukemelia
139051f55f Tweak the context_listing/edit_then_delete test to run more reliably
More adjustments to the time zone calculations. Fixes #450
Add context and project finders as Association Extensions on the User model to simplify controllers and address the feed bug identified by Ryan. Fixes #446 and #444
Replaced usages of "uncompleted" with "incomplete"



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@454 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-23 13:38:36 +00:00
lukemelia
9e3f686f84 Added feed for active projects with no next actions. Closes #423.
Refactored ProjectsController#index and ContextsController#index to simplify them.
Tweak the taggings fixtures to fix broken tests.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@451 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-22 05:15:52 +00:00
lukemelia
10417aca20 Improve and clean up the Ajax interactions involved in deleting projects and contexts from their listing pages.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@449 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-21 14:12:54 +00:00
lukemelia
4c7d27004d Test and fix issue preventing editing the same context twice on the context listing page. Fixes #442
Remove unused edit_context partial.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@448 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-21 05:31:43 +00:00
bsag
341e1fa603 Altered /todo/tag so that it only finds active actions, not completed ones.
Fixes #448

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@447 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-20 20:05:34 +00:00
lukemelia
439f955d32 Introduced a user preference for redirecting to an action's project page when you mark it complete. Defaults to false (no change from the current behavior of Tracks.) The idea of this feature is to go to the project detail page so you can see or create the next action. I'm interested in feedback from people who try this out.
Remember to rake migrate after you update.

Fixes #38.

Also, I added a display of the user's formatted date and current local time to the preferences page.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@445 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-18 06:54:49 +00:00
lukemelia
48e9bcc33f Removed timezone adjustments from date parsing. It doesn't make sense to adjust a date, only a time. Thanks to the commenters on ticket #427.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@444 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-17 07:03:56 +00:00
lukemelia
3af574f76e Strip non-breaking space HTML entities from the text feeds. Fixes #443.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@441 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-17 06:01:54 +00:00
lukemelia
6aae34156e Broken project and context feeds were caused by NULL created_at/updated_at fields in the projects and contexts tables. This changeset makes the models user Time.now if those fields are nil. It would be best to set these fields to non-null values, but I'm not quite sure how to write that migration yet. Fixes #438.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@440 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-17 05:46:24 +00:00
bsag
da7408387d Added to todo controller tests to test adding and removing tags from a todo, and also finding todos tagged with a tag.
Also added a Selenium test for finding todos tagged with a tag.

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@436 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-10 19:11:22 +00:00
lukemelia
08290efdf5 Fixed #436 (Show from not working). While debugging this issue, I renamed a lot of usages of "item" to "todo" to make the code easier to understand.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@435 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-08 05:47:14 +00:00
lukemelia
3070d280ea * Apply unobtrusive javascript principles to _item partial, and reduce the amount of inline javascript throughout the app by a lot.
* Cleaned up the _item partial, moving logic into todo_helper methods.
* Patched the unobtrusive_javascript plugin to avoid overflow of the session storage. I've submitted this patch by email to Luke Redpath, and hopefully, the plugin will incorporate this or similar functionality in the future.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@433 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-06 05:42:40 +00:00
bsag
d0666038f2 Removed acts_as_taggable because it is deprecated and replaced with has_many_polymorphs:
<http://blog.evanweaver.com/articles/2006/06/02/has_many_polymorphs>

Also removed chronic because it is not currently used.

  * Tags are entered separated by commas, so tags with spaces are allowed
  * When you edit an action, whatever is submitted in the tags text field replaces existing tags: if you submit an empty field, tags are removed from the action
  * Clicking on a tag shows a page listing all the actions with that tag (/todo/tag/tag+name)

Todo:
  
  * Tests
  * RESTful routes for Tags (if it makes sense for tags - I haven't decided)
  * If you remove tags for an action, it removes the entries from the Taggings table, but it can leave an orphan Tag if there are no more Taggings for that Tag. One problem is that another user might have an identically-named Tag, so we don't want to remove their Tag, just because we have finished with it. I'm not sure how to arrange this yet.
  
Don't forget to rake db:migrate. There is also a change in config/environment.rb.tmpl, so remember to copy the changes to your copy.
 


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@425 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-04 15:33:24 +00:00
lukemelia
fcab16a5c2 The contexts controller gets more RESTy. It now supports XML, RSS, ATOM, HTML and plain text views of the contexts list.
Changes include:

    * Update the URL on the Feeds page to use /contexts.rss or /contexts.txt instead of FeedController? link
    * Add created_at and updated_at timestamps to contexts table to support ATOM feeds

    Notes:

    * This will break previous context listing feed subscriptions.
    


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@423 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-04 05:12:19 +00:00
lukemelia
6045a7a986 Fixes #432: Could not successfully set project to None while editing a Todo.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@422 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-04 04:16:50 +00:00
lukemelia
eb1709b053 Eliminated rails deprecation warnings originating from todo_list. The last warning left is from the acts_as_taggable plugin.
Also fixed a couple of ajax bugs with the badge_count on the Project detail page. Updated Selenium tests for regression testing of these bugs.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@421 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-02 06:50:19 +00:00
lukemelia
c72a72fe31 replace deprecated assertions
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@418 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-02 05:58:21 +00:00
lukemelia
d9d5ff4d06 The projects controller gets more RESTy. It now supports XML, RSS, ATOM, HTML and plain text views of the projects list.
Changes include:

 * Add assert_xml_select method for testing RSS and ATOM results (Thanks, Jamis! http://weblog.jamisbuck.org/2007/1/4/assert_xml_select)
 * Add resource_feeder plugin for generating RSS and ATOM feeds
 * Update the URL on the Feeds page to use /projects.rss or /projects.txt instead of FeedController link
 * Add created_at and updated_at timestamps to project table to support ATOM feeds
 * Added new filter to login_system "login_or_feed_token_required" to allow RSS, ATOM or text requests with token-based authentication 
 
Notes:
 * This will break previous project listing feed subscriptions.
 * RSS, ATOM & text feeds are available via session or HTTP_BASIC authentication, or by passing the user's token on the url; HTML and XML results are only available via session or HTTP_BASIC authentication
 


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@415 a4c988fc-2ded-0310-b66e-134b36920a42
2007-02-01 05:32:05 +00:00
lukemelia
ef2d93542e Make the UsersController more RESTy. It now supports retrieving a list of users or a particular as XML (available to admins only).
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@412 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-31 05:36:33 +00:00
lukemelia
b1b03b2c8a Restore functionality for creating an admin user on first run. Fixes #429.
Also improved the messaging in this situation.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@411 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-30 05:55:17 +00:00
lukemelia
ddc6d57c17 Make the UsersController more RESTful by moving actions that act on the Users resource from LoginController to UsersController.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@410 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-27 08:28:52 +00:00
lukemelia
109a1847fb Made the Users Controller RESTful. This obviated the need for the currently functionality of the AdminController, so I removed it and consolidated tests.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@409 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-26 06:37:44 +00:00
lukemelia
707b8cdf86 Add smoke tests for feeds. Fix bug in all projects feed.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@408 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-26 05:24:31 +00:00
lukemelia
fedf029764 Make Todo routes RESTful.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@406 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-25 07:07:10 +00:00
lukemelia
828ad592e2 Make the NotesController user RESTful routes.
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@403 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-15 07:50:54 +00:00
bsag
36fcfe5c59 Support for tagging of actions!
Made a start on tagging support. You can add tags via the action forms (just single word tags, separated by a space so far), update tags via the edit form (same limitations), and also search for all actions with a particular tag:

/todo/tag/[tag_name]

Tests for tagging are a bit rudimentary at the moment, and you can't as yet use tags consisting of multiple words, or search for conjunctions of tags (e.g. foo+bar), but I'm hoping to add these. Also no validation, so don't try anything funny!

I'm also planning on letting the user create custom links to /todo/tag pages, so that you can use a tag for inbox, someday/maybe, today, a meta-project, priority, or whatever you like.

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@400 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-14 19:29:01 +00:00
lukemelia
3fb15f81a5 Convert context_controller to use RESTful routes (required renaming contexts_controller -> contexts_controller per rails convention).
This change also changes context detail page URLs from /context/my_context to /contexts/my_context

    Add a database index on the projects and contexts tables, user_d + name, to speed the lookup used in urls
    Brought the URLs within various feeds up-to-date
    


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@399 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-14 19:18:07 +00:00
lukemelia
8b62e4c784 Convert project_controller to use RESTful routes (required renaming project_controller -> projects_controller per rails convention).
This change also changes project detail page URLs from /project/my_project to /projects/my_project
Benefits include
 * built-in enforcement of proper HTTP methods
 * simple named routes (e.g. project_url(project) instead of { :controller => "project", :action => "show", :url_friendly_name => project.url_friendly_name })
 * built-in routes for formats like .js and .xml
 
Also fixed a http basic authentication bug that I introduced a couple of days ago
Add a database index on the users table, login column, to speed authentication
Made more use of simply_helpful dom_id() method and simplified _project_listing.rhtml




git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@398 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-12 13:46:45 +00:00
lukemelia
ead9a4cfe9 Add a bold state to emphasize the project status on the project detail page.
The bold state changes once the ajax operation is complete.
Project status changes now also show a flash notice when the ajax operation completes.
Add a selenium test to confirm this behavior.
Fixed a bug where hiding a project would make deferred items hidden. Now we leave them deferred.
Added a little breathing room between the project status options.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@395 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-10 07:01:26 +00:00
lukemelia
f73401a850 Fix #422 by validating that project names do not contain commas. Thanks for the bug report, Stephen!
Added this validation to Contexts as well.
Introduced a new plugin to hold extra validations. The first one is validates_does_not_contain, which
DRYs up and cleans up the validations used to prohibit slashes and commas in Project and Context names.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@394 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-10 04:55:39 +00:00
bsag
12aa6cee41 Started adding facility for importing and exporting data - only export is available at the moment.
A new Data controller lets you export in a number of different formats: YAML, CSV and XML. All actions produce the appropriate format file for download.

git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@393 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-07 15:19:33 +00:00
lukemelia
2329cb8e1e Introduced user preference for time zone (migration, model and prefs forms)
Made all dates and times stored in UTC in the database and presented according to the User's preferred time zone.
Cleaned up old unused preference methods in UserController
Restored keyboard shortcuts for date field interaction
Aliased preference in User model to prefs for brevity

Don't forget to rake db:migrate for this update!

All tests pass, but there were a lot of little changes involved in this feature. Please help me test it thoroughly if you're using the trunk. 
 
Fixes #349



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@392 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-06 10:06:33 +00:00
lukemelia
bf22f7d49c rename a few selenium tests
git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@389 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-02 02:21:45 +00:00
lukemelia
10a4ead296 Reorganize Selenium tests into Test Suites and continue work on Ajax interactions for deferred actions section of Project Page.
Note that I'm currently only able to successfully run Seleniunm tests on Firefox (Mac & PC). I'm not successful on Safari or IE7.



git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@388 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-02 02:18:11 +00:00
lukemelia
bde8a0bde0 Introduce selenium tests to help get the ajax interactions correct and maintainable.
Start to improve the ajax interactions around the new deferred actions section on the project detail page
Add a README for developers describing how to run the selenium tests.


git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@387 a4c988fc-2ded-0310-b66e-134b36920a42
2007-01-02 00:19:57 +00:00