Commit graph

48 commits

Author SHA1 Message Date
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Carsten Otto
3327966af1 add target="_blank" for generated links
This causes the links to be opened in a new window/tab.
Existing (rendered) notes are not affected by this.

Fixes #1747
2016-01-27 21:26:27 +01:00
Carsten Otto
d2931ea7f0 sort current projects by last_reviewed date
fixes #1960
2016-01-21 22:30:48 +01:00
Reinier Balt
ddd9c07d3b Fasterer: Use &:symbol is faster
Calling argumentless methods within blocks is slower than using
symbol to proc.
2015-08-19 14:48:31 +02:00
Matt Rogers
1c0a70df75 Merge pull request #1903 from lrbalt/fix-test-errors
Fix failing tests for non-UTC timezones
2015-08-07 19:50:58 -04:00
Reinier Balt
5cabeca155 enhance MessageGateway to save email as attachment 2015-08-05 16:05:56 +02:00
Reinier Balt
e58379e81f This fixes failing tests when the timezone is different than utc
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
  date verbatim
* calling a controller will set the timezone to the preference of the
  current_user. So it could be changed while you do not realize this. I
  fixed the failing test, but problems could be elsewhere
2015-08-05 11:50:33 +02:00
Carsten Otto
a29009d3da replace 'None' project by empty string, fix #440 2015-05-10 14:08:20 +02:00
Dan Rice
1dbef179a7 Revert breaking commits
This reverts the following commits:
319d4b00cd
403cc1015e
37485013a0
d08ffb3806
2015-04-14 23:28:18 -04:00
Reinier Balt
319d4b00cd fix failing tests with use of localtime 2015-04-13 15:57:57 +02:00
Reinier Balt
403cc1015e fix a few more timezone issues with the use
of localtime
2015-04-13 15:52:54 +02:00
Reinier Balt
d08ffb3806 do not compare at_midnight in different timezones.
Use localtime to make sure both dates are in the
same timezone
2015-04-13 15:35:09 +02:00
Carsten Otto
cfdafc69e3 do not activate already completed todos, fix #1778 2015-03-24 11:27:17 +01:00
Matteo Giaccone
ed9063bffa Fix #1722 2015-02-22 18:54:24 +00:00
Carsten Otto
dfe8735c0d rename repeating -> recurring, repeat -> recurrence 2015-02-10 16:25:27 +01:00
Carsten Otto
d480569629 occurence -> occurrence 2015-02-10 15:49:13 +01:00
Carsten Otto
705f307bfb fix typos 2015-02-09 23:24:19 +01:00
Dan Rice
ea0d40060a Remove support for deprecated password-hashing algorithm
* Remove all methods implementing and checking for the old algorithm
* Document a pre-upgrade step to check for remaining obsolete passwords
* Remove config.salt
2014-11-15 10:28:29 -05:00
Reinier Balt
6c09fecd63 fix failing test 2014-07-01 22:45:04 +02:00
Dan Rice
9b92306252 Return a valid RecurringTodo after creation error
Fixes #1463
2014-06-19 01:17:15 -04:00
Dan Rice
2386e67dec Simplify requiring of test helpers 2014-05-16 18:03:13 -04:00
Dan Rice
d0cec167a8 Replace Timecop with new ActiveSupport helpers 2014-05-16 13:25:22 -04:00
Reinier Balt
776a046465 move mapping of form attributes to model attributes from pattern to builder to make
pattern independent of form
2014-03-31 09:43:39 +02:00
Reinier Balt
c2c67f1640 use new model to handle updating of recurring todos 2014-03-31 09:43:39 +02:00
Reinier Balt
78c07d52b7 Start major refactoring of recurring_todos. Started with creating new recurring todos.
All current and new tests pass
2014-03-31 09:43:39 +02:00
Reinier Balt
39c52e03b4 fix failing tests
the date in fixtures is not set by timecop. That doesn't help here
2014-02-23 14:03:57 +01:00
Reinier Balt
1649d95374 update gemfile again and fix failing test 2014-01-31 17:44:54 +01:00
Reinier Balt
17dca39d3a update gems and fix i18n and aasm deprecation warnings 2013-12-30 20:52:35 +01:00
Matt Rogers
9fd4b845de Don't depend on the environment in the test 2013-10-15 20:02:52 -05:00
Greg Sutcliffe
8a2da01d51 Add Mailgun endpoint for receiving email tasks via Mailgun 2013-09-21 12:43:22 +01:00
Ian Young
4cd8688d9a Fix failing test
As far as I can tell, this is how the test is intended to work, and how
it works in v2.2.2. If a recurring todo set to show on the date is
completed *on* the specified date, it will create a deferred one for the
*next* month.
2013-09-14 22:11:23 -07:00
Ian Young
a6c32889ce Bug repeating monthly recurring todos 2013-09-14 18:12:56 -07:00
Reinier Balt
0b38f3c43c clean up a rec todos test 2013-09-05 17:14:01 +02:00
Reinier Balt
cb46a8461e fix show_from not being clear when a todo comes from tickler 2013-09-05 12:21:43 +02:00
Matt Rogers
6681df9530 Merge pull request #202 from TracksApp/extract-extras-from-user
Extract time and date concerns from User
2013-08-01 14:59:17 -07:00
Matt Rogers
8512e8db3b rename DateUtils to UserTime 2013-07-29 21:51:15 -05:00
Matt Rogers
a1aaa283f1 Remove User#at_midnight
Replace it with a class called DateUtils with a method called
`#midnight_for` that takes a preference instance and date to convert to
midnight.
2013-07-29 16:34:23 -05:00
Don Cruse
8ed20b35f2 Fixing bug #1442
This bug was caused when the chart encountered data outside of its
visible range (i.e., the upper bound of the array size). A test was
added that inserts some data from 2 years and 16 months in the past.
The test failed on the old version, throwing exactly the error in bug
report #1442.

The fix is to check whether or not the value is within the array range
before sending the "+=" operator. With this change, the test passes.
2013-07-28 19:00:51 -05:00
Brett A. Rogers
f18f1c7345 Move calendar test down to unit tests
Remove tests that are specific to the calendar model from controller
test and move them to unit tests.
2013-07-19 17:27:38 -05:00
Brett A. Rogers
7a5374d567 Fix setup for calendar controller test
Ensure that the expected todos are actually due in the same month
2013-07-19 15:43:56 -05:00
Don Cruse
70f633c150 Shifting more instance variables to the controller
Also removing some instance variables that were never invoked in the
views. This sets up a future refactoring of the method of comptuting
rolling averages, which differs between the two types of "last year"
views being refactored.
2013-07-18 21:01:39 -05:00
Don Cruse
1493304fc1 Refactor last year chart
Pulled some instance variable assignment into the controller.

Also extracted a method regarding interpolated values for the present
month.
2013-07-18 16:17:30 -05:00
Reinier Balt
2daffef683 fix failing tests 2013-06-17 10:06:38 +02:00
Reinier Balt
4a485558e2 Merge branch 'master' into rails4
Conflicts:
	Gemfile.lock
	config/routes.rb
2013-06-17 09:25:02 +02:00
Reinier Balt
671f64b419 move to strong_parameters of rails4. 2013-05-27 12:44:31 +02:00
Reinier Balt
08498fee4f fix failing tests
Includes a monkey patch for Arel that may need to be removed when 4.0.0 final ships
2013-05-13 15:35:21 +02:00
Reinier Balt
80974fb0d5 empty non-saved project caused rss builder to fail 2013-05-13 12:50:10 +02:00
Reinier Balt
0bc9b0397a move tests to new directory 2013-05-11 23:13:16 +02:00