Commit graph

123 commits

Author SHA1 Message Date
Matt Rogers
5805c511bb
Convert render :text to render :body
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter to before_action
`before_filter` has been removed in future versions of rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 12:55:27 -05:00
ericmoon
6dcaa76f09 cucumber removal 2018-07-24 12:34:55 -07:00
Dan Rice
d7d86446c0 Upgrade to Rails 4.2
* Update boilerplate with `bin/rake rails:upgrade`
* Use test instead of test:all rake task
* Change stylesheet extensions from .css.scss to .scss
* Update docs to use localhost instead of 0.0.0.0 because Rails 4.2
  no longer listens on all addresses by default.
2016-05-22 21:58:52 -04:00
Dan Rice
a6f9be2d84 On Travis, restrict Cucumber tests to MySQL builds 2016-02-14 23:05:43 -05:00
Jan-Yves Ruzicka
ccf13418f4 Extract rendering to helper method. Shift filename sanitization to controller. 2016-02-02 11:08:12 +00:00
Carsten Otto
3327966af1 add target="_blank" for generated links
This causes the links to be opened in a new window/tab.
Existing (rendered) notes are not affected by this.

Fixes #1747
2016-01-27 21:26:27 +01:00
Matt Rogers
d9b78c4e1f Simplify the return values when using basic auth
Returning a hash with explicit keys isn't strictly necessary with the
access methods we're using to get the values for those keys out of the
hash. Return an empty hash instead, simplifying the code.

Also remove the early return statements within the conditional. Those
are also unneeded since this is the last expression that's run in the
method.
2015-11-02 22:05:29 -06:00
Reinier Balt
5092b388fe Fasterer: Parallel assignment is slower
Parallel assignment is slower than sequential assignment.
Only got the low hanging fruit. There are some functions that
have multiple return values. Fixing this needs more refactoring.
2015-08-19 15:12:52 +02:00
Reinier Balt
e58379e81f This fixes failing tests when the timezone is different than utc
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
  date verbatim
* calling a controller will set the timezone to the preference of the
  current_user. So it could be changed while you do not realize this. I
  fixed the failing test, but problems could be elsewhere
2015-08-05 11:50:33 +02:00
Carsten Otto
a29009d3da replace 'None' project by empty string, fix #440 2015-05-10 14:08:20 +02:00
Carsten Otto
229c515e71 retain tags from action when transforming into project 2015-04-12 21:57:23 +02:00
Dan Rice
4405015384 CI test on both MySQL and SQLite 2015-02-22 18:19:48 -05:00
Carsten Otto
d480569629 occurence -> occurrence 2015-02-10 15:49:13 +01:00
Dan Rice
ea0d40060a Remove support for deprecated password-hashing algorithm
* Remove all methods implementing and checking for the old algorithm
* Document a pre-upgrade step to check for remaining obsolete passwords
* Remove config.salt
2014-11-15 10:28:29 -05:00
Reinier Balt
cb8aba80ca fix #1462
I do not understand why this works for daily but not for weekly repeating todos
2014-07-01 22:38:23 +02:00
Reinier Balt
4dfcc182da update gems and migrate sanitize to newer version 2014-06-25 22:11:03 +02:00
Dan Rice
9469bacc2f Remove db:migrate from ci task
Rails 4.1 auto-manages the database using schema.rb
2014-06-10 15:57:29 -04:00
Reinier Balt
49a09f36e8 activerecord associations do not act like a collection anymore, so convert to array first
before using map, collect, etc.
2014-05-16 14:33:18 +02:00
Dan Rice
4a3d5a74e6 Require only stdlib for password reset rake task 2014-05-15 22:41:37 -04:00
Reinier Balt
5de96d7eda add some more tests 2014-03-31 09:43:39 +02:00
Reinier Balt
b23338eaa2 fix updating of recurring todo and create a form helper for filling the recurring todo edit
form
2014-03-31 09:43:39 +02:00
Reinier Balt
59a29c664a move form specific accessors out of model 2014-03-31 09:43:39 +02:00
Reinier Balt
78c07d52b7 Start major refactoring of recurring_todos. Started with creating new recurring todos.
All current and new tests pass
2014-03-31 09:43:39 +02:00
Dan Rice
1a593d9796 Add rake task to check for deprecated password hashes 2014-03-30 15:02:41 -04:00
Dan Rice
64fddeaf7a Rename the tracks rakefile to match the namespace 2014-03-30 14:41:37 -04:00
Reinier Balt
a67f88bcfa restore reset_password rake task 2014-02-09 14:56:05 +01:00
Reinier Balt
6238029b55 fix regressions 2014-01-11 14:33:14 +01:00
Reinier Balt
3b673f0838 fix some failing cucumber tests 2014-01-09 11:18:33 +01:00
Reinier Balt
11bc4294a8 add tests for done_todos 2013-09-25 15:08:25 +02:00
Reinier Balt
406eb47db7 move coverage to ci rake task 2013-09-24 09:48:21 +02:00
Reinier Balt
067db90d58 various small refactorings 2013-09-22 17:34:58 +02:00
Reinier Balt
bbf6cdf702 fix failing cucumber scenario's and update gems 2013-09-18 10:38:20 +02:00
Reinier Balt
a31c0a7a5d fix import for csv 2013-09-16 11:37:16 +02:00
Reinier Balt
eaa66be698 fix deprecation warnings 2013-09-13 16:44:59 +02:00
Reinier Balt
e2eb31cfcc Merge pull request #206 from mmozuras/refactor_unless_blanks_into_presents
Refactor unless blanks into presents
2013-09-13 06:08:16 -07:00
Mindaugas Mozūras
25e764b21a Refactor "unless blank?" into "if present?" 2013-09-13 15:40:09 +03:00
Mindaugas Mozūras
962b4fa5c9 Use respond_to { |format| format.any } to reduce duplication 2013-09-13 14:58:28 +03:00
Reinier Balt
fee1e3b504 fix failing test on timezones and remove debug message 2013-09-05 12:23:26 +02:00
Matt Rogers
96777c2e3a Replace User#time with UserTime#time 2013-07-30 16:21:04 -05:00
Matt Rogers
8512e8db3b rename DateUtils to UserTime 2013-07-29 21:51:15 -05:00
Matt Rogers
a1aaa283f1 Remove User#at_midnight
Replace it with a class called DateUtils with a method called
`#midnight_for` that takes a preference instance and date to convert to
midnight.
2013-07-29 16:34:23 -05:00
Matt Rogers
883ea2b968 Move Project#create_from_todo to its own class
The point of this is to keep as many things out of the ActiveRecord
objects as possible and use them as just a thin database abstraction
layer.
2013-05-02 22:30:24 -05:00
Matt Rogers
036c34f266 Rename RecurringTodo#inc_occurences to increment_occurrences
This clarifies the method name and fixes a typo.
2013-04-26 16:20:42 -05:00
Matt Rogers & Katrina Owen
a1b270699d Extract creation of todos from recurrings todos 2013-04-25 20:45:14 -05:00
Reinier Balt
85fc82d494 refactor done todos view and tests 2013-03-18 12:36:40 +01:00
Dan Rice
dc311221f1 Render notes using RedCloth without formatize
Removes the outdated bluecloth dependency
2013-03-13 17:03:58 +02:00
Matt Rogers
053e3fc8d6 Guard against the case days stale can be negative 2013-03-10 22:48:27 -05:00
Matt Rogers
43275e064e Refactor the calculation for staleness
Provide the number of days that the todo was stale instead of a class
name to use in the view.

We'll use the number of days stale in the helper to determine the class
name
2013-03-10 13:46:22 -05:00
Matt Rogers
ccf5323588 Encapsulate the concept of staleness into its own class
Extract it from a single helper method and wrap it in a method object.
This lets us add tests around it and then (later) split the domain
concerns from the view concerns.
2013-03-09 22:38:38 -06:00