Commit graph

402 commits

Author SHA1 Message Date
Matt Rogers
500892e1a4 Fix the top 10 longest running projects list
Sorting by running time without a reverse takes the shortest running
projects.
2017-06-13 17:12:15 -05:00
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Jan-Yves Ruzicka
ccf13418f4 Extract rendering to helper method. Shift filename sanitization to controller. 2016-02-02 11:08:12 +00:00
Matt Rogers
42ab5e3000 Merge pull request #1951 from C-Otto/show_from_midnight
when recurring todos always use midnight for "show from"
2016-01-21 16:13:30 -06:00
Carsten Otto
cd09cce7a4 when recurring todos always use midnight for "show from"
fixes #1940
2015-12-13 15:44:40 +01:00
Matt Rogers
3468d1ec13 Merge branch '2.3_branch' 2015-12-08 20:14:33 -06:00
Nascher
dd6698b8a1 Update the maximum password length 2015-08-29 23:58:02 +00:00
Nascher
4632208699 Increase the maximum password length 2015-08-29 18:36:12 +00:00
Reinier Balt
0602634ae3 Fasterer: Use #cover? instead of #include? on ranges 2015-08-19 15:42:14 +02:00
Reinier Balt
bb006f98c1 Using tr is faster than gsub
Using tr is faster than gsub when replacing a single character in
a string with another single character.

Also freeze constant strings
2015-08-19 15:24:35 +02:00
Reinier Balt
d3aa73f783 first select than sort
sorting on a smaller collection is faster
2015-08-19 15:21:11 +02:00
Reinier Balt
405ad5a79f Fasterer: Enumerable#sort is slower
Enumerable#sort is slower than Enumerable#sort_by
2015-08-19 15:19:47 +02:00
Reinier Balt
ddd9c07d3b Fasterer: Use &:symbol is faster
Calling argumentless methods within blocks is slower than using
symbol to proc.
2015-08-19 14:48:31 +02:00
Carsten Otto
e0143cf435 move actual activation to model
fixes #1881
2015-08-09 13:47:17 +02:00
Matt Rogers
a9023960fc Merge pull request #1848 from C-Otto/tracks-1847
Fix description of monthly recurring tests
2015-08-07 20:29:40 -04:00
Matt Rogers
f393afb69f Merge branch '2.3_branch'
This brings the master branch up to date with the 2.3 release branch
2015-08-07 20:27:14 -04:00
Matt Rogers
efbf881742 Merge pull request #1872 from C-Otto/create-reviewed-2.3
(2.3) create projects as reviewed at creation time
2015-08-07 19:59:57 -04:00
Matt Rogers
1c0a70df75 Merge pull request #1903 from lrbalt/fix-test-errors
Fix failing tests for non-UTC timezones
2015-08-07 19:50:58 -04:00
Reinier Balt
5cabeca155 enhance MessageGateway to save email as attachment 2015-08-05 16:05:56 +02:00
Reinier Balt
2bd68fecb7 Create attachment model and hook it up to todo
An attachment has write permissions on group so that managing
attachments work from different users in same group, i.e. user apache
and user mail.
2015-08-05 16:05:19 +02:00
Reinier Balt
e58379e81f This fixes failing tests when the timezone is different than utc
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
  date verbatim
* calling a controller will set the timezone to the preference of the
  current_user. So it could be changed while you do not realize this. I
  fixed the failing test, but problems could be elsewhere
2015-08-05 11:50:33 +02:00
Carsten Otto
67ced62096 Projects with completed actions may be blocked
Currently, a project cannot be blocked if at least one completed
action exists. This was introduced in
acab98d4c7,
and I assume this change was not intended
2015-06-16 20:44:26 -04:00
Carsten Otto
6014ce7a6f create projects as reviewed at creation time
Fixes #1788
2015-05-22 23:12:45 +02:00
Carsten Otto
72f7513650 fix #1847 2015-05-09 19:21:01 +02:00
Carsten Otto
cc88d24d79 Projects with completed actions may be blocked
Currently, a project cannot be blocked if at least one completed
action exists. This was introduced in
acab98d4c7,
and I assume this change was not intended
2015-04-15 20:46:53 +02:00
Dan Rice
1dbef179a7 Revert breaking commits
This reverts the following commits:
319d4b00cd
403cc1015e
37485013a0
d08ffb3806
2015-04-14 23:28:18 -04:00
Dan Rice
556c68c2e6 Revert breaking commits
This reverts the following commits:
c129b8a06f
c7c923a317
006c135a64
2015-04-14 22:26:07 -04:00
Reinier Balt
d08ffb3806 do not compare at_midnight in different timezones.
Use localtime to make sure both dates are in the
same timezone
2015-04-13 15:35:09 +02:00
Reinier Balt
006c135a64 do not compare at_midnight in different timezones.
Use localtime to make sure both dates are in the
same timezone
2015-04-13 15:33:22 +02:00
Carsten Otto
6017637abc do not activate already completed todos, fix #1778 2015-04-13 14:37:57 +02:00
Carsten Otto
cec2e535b2 fix #1754 2015-04-13 14:37:12 +02:00
Reinier Balt
17c5edd7ae Merge pull request #1783 from C-Otto/bug-1778
do not activate already completed todos, fix #1778
2015-04-12 17:27:59 +02:00
Carsten Otto
0edc263c7e fix #1754 2015-03-24 11:27:36 +01:00
Carsten Otto
cfdafc69e3 do not activate already completed todos, fix #1778 2015-03-24 11:27:17 +01:00
Carsten Otto
dfe8735c0d rename repeating -> recurring, repeat -> recurrence 2015-02-10 16:25:27 +01:00
Carsten Otto
d480569629 occurence -> occurrence 2015-02-10 15:49:13 +01:00
Dan Rice
7f1246f42f Make User.projects.actionize deterministic
Add project.id to the comparison to ensure consistent order when
counts are identical.
2015-01-03 18:12:11 -05:00
Matteo Giaccone
13f8023ca0 Fix #1724 2015-01-01 18:16:40 -05:00
Matteo Giaccone
0d6e0efcee Fix warnings for Ruby 2.2 update 2015-01-01 13:43:48 -05:00
Matteo Giaccone
2ca90537ae Fix #1724 2014-12-19 21:17:35 +00:00
Dan Rice
b9f3b9685f Merge pull request #1733 from dnrce/password-hashing
Remove support for deprecated password hashing algorithm
2014-12-14 14:35:32 -05:00
Dan Rice
ea0d40060a Remove support for deprecated password-hashing algorithm
* Remove all methods implementing and checking for the old algorithm
* Document a pre-upgrade step to check for remaining obsolete passwords
* Remove config.salt
2014-11-15 10:28:29 -05:00
Matt Rogers
8d24f5105a Add a Sidebar class to represent the side bar
Start using it throughout the rest of the app instead of the various
instance variables
2014-11-11 19:55:00 -06:00
Reinier Balt
166387f0be Statistics for longest running projects now includes completed and hidden projects. fixes #1725 2014-11-05 17:09:59 +01:00
Reinier Balt
2883d1b7f4 Statistics for longest running projects now includes completed and hidden projects. fixes #1725 2014-11-05 17:07:21 +01:00
Reinier Balt
18b7a467c1 fix #1400 where deleting a user will clean up tags and dependencies too 2014-09-23 16:35:45 +02:00
Matt Rogers
aa41e20e46 Remove trailing whitespace and tabs 2014-08-14 21:05:05 -05:00
Reinier Balt
ee3ba62152 fix #1712. Number of occurrences was not handled correctly 2014-08-06 14:40:30 +02:00
Reinier Balt
bafd55cf09 refactor due date tag on todo for mobile and non-mobile view 2014-07-17 13:56:08 +02:00
Reinier Balt
cb8aba80ca fix #1462
I do not understand why this works for daily but not for weekly repeating todos
2014-07-01 22:38:23 +02:00