Reinier Balt
4a485558e2
Merge branch 'master' into rails4
...
Conflicts:
Gemfile.lock
config/routes.rb
2013-06-17 09:25:02 +02:00
Reinier Balt
0a57a68a87
Project and context view can now be grouped by context and project (using view menu)
2013-06-11 11:12:21 +02:00
Reinier Balt
02d4afb724
fix #1429 by correctly handling tags with dots
...
This was a very old regression. This used to work before the rails 3.2 upgrade... Added tests
to prevent future unnoticed breakage
2013-06-03 15:20:13 +02:00
Reinier Balt
671f64b419
move to strong_parameters of rails4.
2013-05-27 12:44:31 +02:00
Reinier Balt
101268f504
Introduce #onsite_redirect_to helper for onsite redirects
...
Prefer #onsite_redirect_to to #redirect_to when using untrusted input (e.g. cookies) in the redirect destination
Thanks @brynary
2013-05-07 09:41:48 +02:00
Reinier Balt
f891ee86fe
fix clearing show_from fails
...
caused by slightly different (better) workings of aasm
2013-05-03 19:28:26 +02:00
Matt Rogers
883ea2b968
Move Project#create_from_todo to its own class
...
The point of this is to keep as many things out of the ActiveRecord
objects as possible and use them as just a thin database abstraction
layer.
2013-05-02 22:30:24 -05:00
Matt Rogers
c1597a7751
Rename to_xml_params to todo_xml_params
2013-04-30 22:52:22 -05:00
Matt Rogers
8fe343cccc
Push to_xml_params down to ApplicationController
2013-04-30 22:50:32 -05:00
Matt Rogers
ebd182695d
remove the calendar from TodosController
2013-04-30 20:35:13 -05:00
Reinier Balt
010d0e9ba0
refactor creating todos in todos_controller
2013-04-29 15:15:48 +02:00
Matt Rogers
8db5793bf6
Merge pull request #178 from TracksApp/rename-has-next-todo
...
Rename RecurringTodo#has_next_todo
2013-04-27 09:52:58 -07:00
Matt Rogers
6b8e745234
Use Todos::Calendar in the view
2013-04-26 23:23:56 -05:00
Matt Rogers
fb71441436
Start using Todos::Calendar in the calendar action
...
Replaces the existing query logic in a lot of places
2013-04-26 23:09:47 -05:00
Matt Rogers
88e7798db6
Rename RecurringTodo#has_next_todo to continues_recurring?
...
This clarifies the intent of the method.
2013-04-26 16:30:12 -05:00
Matt Rogers
1431bef1a9
Use first_or_create to creating missing Tags
2013-04-26 08:46:06 -05:00
Matt Rogers
3425b3fa10
Remove duplication when setting up done by tag views
2013-04-26 08:40:24 -05:00
Matt Rogers
6af7fe0ab6
Remove unused method
2013-04-26 08:31:00 -05:00
Matt Rogers
56f366b432
Remove context_specified_by_name from TodosController
...
Use TodoCreateParamsHelper instead to remove the duplication
2013-04-26 08:04:22 -05:00
Matt Rogers
d5dc723ef0
Remove project_specified_by_name from TodoController
...
Use TodoCreateParamsHelper instead here and remove the duplication
2013-04-26 08:02:47 -05:00
Matt Rogers
445a0c7602
Remove trailing whitespace
2013-04-26 07:55:06 -05:00
Matt Rogers
a60b4389cd
Fix a bug when generating predecessor autocomplete data
2013-04-25 21:13:49 -05:00
Matt Rogers & Katrina Owen
a1b270699d
Extract creation of todos from recurrings todos
2013-04-25 20:45:14 -05:00
Reinier Balt
0607096e7c
add cucumber tests for tickler with group by project
2013-04-24 23:30:58 +02:00
Reinier Balt
caec4f214a
enable group by project for tickler
2013-04-20 20:20:57 +02:00
Reinier Balt
9172d5e001
fix failing scenario
2013-04-17 23:26:46 +02:00
Reinier Balt
8641ecfc4e
add some project grouping scenarios to edit_a_todo and fix failures
...
also refactor step definitions
2013-04-17 22:11:24 +02:00
Reinier Balt
67247980ad
fix failing tests
2013-04-11 11:04:07 +02:00
Reinier Balt
9c0445fcb7
make adding of todos from sidebar work in context and project grouping
2013-04-11 10:53:35 +02:00
Reinier Balt
42566b6fee
add test for collapsing project containers
2013-04-06 12:57:53 +02:00
Reinier Balt
85fc82d494
refactor done todos view and tests
2013-03-18 12:36:40 +01:00
Reinier Balt
ede898120c
remove option to show empty containers and start fixing failing cucumber scenarios
2013-03-18 12:36:40 +01:00
Reinier Balt
22b371ef8c
do a big refactor of rendering collections of todos for home page, tag page, project page, context page
2013-03-18 12:36:40 +01:00
Reinier Balt
f22dfc1f9b
initial changes to add an option to select either context or project as grouping of todos on home or tag page
...
* new menu item in view menu
* js to toggle view
* store setting in cookie to keep de choice of view persistent
* refactor index and tag page of todos to look more alike
* refactor context and project partials to look more alike
2013-03-18 12:32:28 +01:00
Reinier Balt
1e84adc91b
get tests running and fix editing context state
2013-03-01 16:22:29 +01:00
Reinier Balt
48e47fc009
remove dynamic finders from cucumber scenarios
2013-02-27 20:02:01 +01:00
Reinier Balt
583664be36
remove some dynamic finders (they are deprecated for rails4) and add test for untested method of context.rb
2013-02-25 10:21:04 +01:00
Reinier Balt
6fa70db39e
fix updating dependency trees when changin a name. Including invalidating cache when
...
necessary
2013-02-17 17:37:44 +01:00
Reinier Balt
4b7bd1c414
include predecessors and successors in xml export of todos. Fixes #1377
2013-01-01 23:08:47 +01:00
Matt Rogers
4d2f25ab20
Refactor the fetching of done todos
...
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.
This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.
The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
2012-11-27 23:07:46 -06:00
Matt Rogers
306d501e20
remove duplication in mobile cookie handling
2012-08-15 22:14:00 -05:00
Matt Rogers
b01c7878d1
Push conversion of a todo to a project down.
...
Refactor the conversion of a todo to a project and move it from the
TodosController to the Project model.
2012-08-14 19:33:54 -05:00
Reinier Balt
a37d10f57a
fix #1314 . Fixed security issue too
2012-07-18 12:26:46 +02:00
Reinier Balt
4e29bf69f7
fix failing tests and small refactorings
2012-07-18 11:42:26 +02:00
Reinier Balt
7c1cd2a144
fix #1310 . Add test for this
...
Found that I had a lot of tests commented out. They have some regressions I will fix later
2012-07-15 21:28:42 +02:00
Reinier Balt
bd8498f39c
fix #1287 . Fix various small bugs and some small improvements
2012-06-29 16:48:30 +02:00
tim madden
51da342cdc
harmonizing todo_tag_list and tag_list, using just the shorter tag_list
2012-06-27 13:56:56 -05:00
Reinier Balt
436cc862d6
fix text feeds
2012-05-20 05:46:52 +02:00
Reinier Balt
fc69c6cfbf
get shared_add_new_todo feature to pass
2012-05-12 18:04:56 +02:00
Reinier Balt
005723cb4f
get login, mobile and notes features passing
2012-05-12 13:37:36 +02:00