refactor tag helpers

app/models/tag.rb

@@ -11,38 +11,41 @@ class Tag < ActiveRecord::Base
   # rescue the ActiveRecord database constraint errors instead.
   validates_presence_of :name
   validates_uniqueness_of :name, :case_sensitive => false
-  
+
   # Change this validation if you need more complex tag names.
   # validates_format_of :name, :with => /^[a-zA-Z0-9\_\-]+$/, :message => "can not contain special characters"
-  
+
   # Set up the polymorphic relationship.
-  has_many_polymorphs :taggables, 
-    :from => [:todos, :recurring_todos], 
-    :through => :taggings, 
+  has_many_polymorphs :taggables,
+    :from => [:todos, :recurring_todos],
+    :through => :taggings,
     :dependent => :destroy,
-    :skip_duplicates => false, 
+    :skip_duplicates => false,
     :parent_extend => proc {
     # Defined on the taggable models, not on Tag itself. Return the tagnames
     # associated with this record as a string.
     def to_s
       self.map(&:name).sort.join(Tag::JOIN_DELIMITER)
     end
+    def all_except_starred
+      self.reject{|tag| tag.name == Todo::STARRED_TAG_NAME}
+    end
   }
-    
+
   # Callback to strip extra spaces from the tagname before saving it. If you
   # allow tags to be renamed later, you might want to use the
   # <tt>before_save</tt> callback instead.
-  def before_create 
+  def before_create
     self.name = name.downcase.strip.squeeze(" ")
   end
 
   def on(taggable, user)
     taggings.create :taggable => taggable, :user => user
   end
-  
+
   # Tag::Error class. Raised by ActiveRecord::Base::TaggingExtensions if
   # something goes wrong.
   class Error < StandardError
   end
-    
+
 end

app/models/todo.rb

@@ -46,13 +46,14 @@ class Todo < ActiveRecord::Base
   STARRED_TAG_NAME = "starred"
   DEFAULT_INCLUDES = [ :project, :context, :tags, :taggings, :pending_successors, :uncompleted_predecessors, :recurring_todo ]
 
-  # regular expressions for dependencies
+  # regular expressions for dependencies. TODO: are these still used?
   RE_TODO = /[^']+/
   RE_CONTEXT = /[^']+/
   RE_PROJECT = /[^']+/
   RE_PARTS = /'(#{RE_TODO})'\s<'(#{RE_CONTEXT})';\s'(#{RE_PROJECT})'>/ # results in array
   RE_SPEC = /'#{RE_TODO}'\s<'#{RE_CONTEXT}';\s'#{RE_PROJECT}'>/ # results in string
 
+  # state machine
   include AASM
   aasm_column :state
   aasm_initial_state Proc.new { |t| (t.show_from && t.user && (t.show_from > t.user.date)) ? :deferred : :active}