From b932ac210fd1e0f2797fa917bf8eb7f0adc39fe0 Mon Sep 17 00:00:00 2001 From: tim madden Date: Sat, 28 Apr 2012 22:34:03 -0500 Subject: [PATCH] fix for mobile new todo tags no being saved the mobile interface shares the form for creating and updating todos. the todo controller was using different names for them. this change aligns them. --- app/controllers/todos_controller.rb | 4 ++-- app/views/todos/_edit_form.rhtml | 4 ++-- app/views/todos/_edit_mobile_form.rhtml | 4 ++-- public/stylesheets/mobile.css | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/controllers/todos_controller.rb b/app/controllers/todos_controller.rb index 19a05d3c..3ae8c5ed 100644 --- a/app/controllers/todos_controller.rb +++ b/app/controllers/todos_controller.rb @@ -1424,8 +1424,8 @@ class TodosController < ApplicationController end def update_tags - if params[:tag_list] - @todo.tag_with(params[:tag_list]) + if params[:todo_tag_list] + @todo.tag_with(params[:todo_tag_list]) @todo.tags(true) #force a reload for proper rendering end end diff --git a/app/views/todos/_edit_form.rhtml b/app/views/todos/_edit_form.rhtml index 9ffb3d39..9081ad16 100644 --- a/app/views/todos/_edit_form.rhtml +++ b/app/views/todos/_edit_form.rhtml @@ -23,8 +23,8 @@ form_for(todo, :html=> { :name=>'todo', :id => dom_id(@todo, 'form'), :class => - - <%= text_field_tag 'tag_list', tag_list_text, :id => dom_id(@todo, 'tag_list'), :size => 30, :tabindex => next_tab_index %> + + <%= text_field_tag 'todo_tag_list', tag_list_text, :id => dom_id(@todo, 'todo_tag_list'), :size => 30, :tabindex => next_tab_index %>
diff --git a/app/views/todos/_edit_mobile_form.rhtml b/app/views/todos/_edit_mobile_form.rhtml index df130e65..973dee68 100644 --- a/app/views/todos/_edit_mobile_form.rhtml +++ b/app/views/todos/_edit_mobile_form.rhtml @@ -6,8 +6,8 @@ <% this_year = current_user.time.to_date.strftime("%Y").to_i -%>

<%= text_field( "todo", "description", "tabindex" => 1, "maxlength" => 100, "size" => 50) %> -

-<%= text_field_tag "tag_list", @tag_list_text, :size => 50, :tabindex => 2 %> +

+<%= text_field_tag "todo_tag_list", @tag_list_text, :size => 50, :tabindex => 2 %>

<%= unless @mobile_from_context collection_select( "todo", "context_id", @contexts, "id", "name", {}, {"tabindex" => 3} ) diff --git a/public/stylesheets/mobile.css b/public/stylesheets/mobile.css index f10e5632..b43cdbf9 100644 --- a/public/stylesheets/mobile.css +++ b/public/stylesheets/mobile.css @@ -230,7 +230,7 @@ table.c { display:inline; } -input#todo_description, input#tag_list, textarea#todo_notes, select#todo_project_id, select#todo_context_id { +input#todo_description, input#todo_tag_list, textarea#todo_notes, select#todo_project_id, select#todo_context_id { width: 95%; }