Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2026-01-28 03:36:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix several issues with recurring todos

Browse source 
* fix case where some fields were not saved
* fix several fields that were not filled with the saved value when editing
* hide storage details of recurring_todo by adding public getters and refactoring view to use them in stead of database fields
This commit is contained in:
Reinier Balt 2008-07-27 22:13:54 +02:00
parent 726832880f
commit ed4ee1cc3f
6 changed files with 132 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/controllers/recurring_todos_controller.rb
View file

@ -30,9 +30,9 @@ class RecurringTodosController < ApplicationController
@original_item_context_id = @recurring_todo.context_id
@original_item_project_id = @recurring_todo.project_id
# we needed to rename the recurring_period selector in the edit form
# because the form for a new recurring todo and the edit form are on the
# same page. Same goes for start_from and end_date
# we needed to rename the recurring_period selector in the edit form because
# the form for a new recurring todo and the edit form are on the same page.
# Same goes for start_from and end_date
params['recurring_todo']['recurring_period']=params['recurring_edit_todo']['recurring_period']
params['recurring_todo']['end_date']=params['recurring_todo_edit_end_date']
params['recurring_todo']['start_from']=params['recurring_todo_edit_start_from']
@ -81,7 +81,7 @@ class RecurringTodosController < ApplicationController
end
def create
p = RecurringTodoCreateParamsHelper.new(params)
p = RecurringTodoCreateParamsHelper.new(params)
@recurring_todo = current_user.recurring_todos.build(p.attributes)
if p.project_specified_by_name?
@ -185,7 +185,17 @@ class RecurringTodosController < ApplicationController
def initialize(params)
@params = params['request'] || params
@attributes = params['request'] && params['request']['recurring_todo'] || params['recurring_todo']
attr = params['request'] && params['request']['recurring_todo'] || params['recurring_todo']
# make sure all selectors (recurring_period, recurrence_selector,
# daily_selector, monthly_selector and yearly_selector) are first in hash
# so that they are processed first by the model
@attributes = {
'recurring_period' => attr['recurring_period'],
'daily_selector' => attr['daily_selector'],
'monthly_selector' => attr['monthly_selector'],
'yearly_selector' => attr['yearly_selector']
}.merge(attr)
end
def attributes