restores sidebar and refactor sidebar

sidebar was not shown after rails upgrade

app/controllers/application.rb

@@ -230,6 +230,14 @@ class ApplicationController < ActionController::Base
   def init_data_for_sidebar
     @projects = @projects || current_user.projects.find(:all, :include => [:default_context ])
     @contexts = @contexts || current_user.contexts
+
+    @completed_projects = current_user.projects.completed
+    @hidden_projects = current_user.projects.hidden
+    @active_projects = current_user.projects.active
+
+    @active_contexts = current_user.contexts.active
+    @hidden_contexts = current_user.contexts.hidden
+
     init_not_done_counts
     if prefs.show_hidden_projects_in_sidebar
       init_project_hidden_todo_counts(['project'])

app/views/sidebar/sidebar.html.erb

@@ -1,30 +1,30 @@
 <div id="sidebar">
-        <% # show active items before hidden / completed items -%>
+    <% # show active items before hidden / completed items -%>
 
 	<%= render :partial => "sidebar/project_list",
 	           :locals => { :list_name => 'Active Projects',
-	           				:projects => @projects.select{|p| p.active? } } -%>
+	           				:projects => @active_projects } -%>
 	
 	<%= render :partial => "sidebar/context_list",
 	           :locals => { :list_name => 'Active Contexts',
-	           				:contexts => @contexts.reject{|c| c.hide? } } -%>
+	           				:contexts => @active_contexts } -%>
 
 	<% if prefs.show_hidden_projects_in_sidebar -%>
         <%= render :partial => "sidebar/project_list",
                    :locals => { :list_name => 'Hidden Projects',
-			 			  :projects => @projects.select{|p| p.hidden? } } -%>
+			 			  :projects => @hidden_projects } -%>
 	<% end -%>
 
 	<% if prefs.show_completed_projects_in_sidebar -%>
         <%= render :partial => "sidebar/project_list",
                    :locals => { :list_name => 'Completed Projects',
-             			  :projects => @projects.select{|p| p.completed? } } -%>
+             			  :projects => @completed_projects } -%>
 	<% end -%>
 
 	<% if prefs.show_hidden_contexts_in_sidebar -%>
 	<%= render :partial => "sidebar/context_list",
 	           :locals => { :list_name => 'Hidden Contexts',
-	           				:contexts => @contexts.select{|c| c.hide? } } -%>
+	           				:contexts => @hidden_contexts } -%>
 	<% end -%>
 	
 	<div class="integrations-link"><ul>

app/views/todos/index.html.erb

@@ -10,5 +10,7 @@
 
 <div id="input_box">
   <%= render :partial => "shared/add_new_item_form" %>
-  <%= render :template => "sidebar/sidebar" %>
+  <%- # TODO: this used to be render :template, but somehow it was not
+      #rendered after the rails2.2.2 upgrade -%>
+  <%= render :file => "sidebar/sidebar.html.erb" %>
 </div><!-- End of input box -->