From 11b9081064e62c7c6ed0ebbc35b31e366c771686 Mon Sep 17 00:00:00 2001 From: Matt Rogers Date: Sat, 4 May 2019 15:16:36 -0500 Subject: [PATCH] Use !exists? instead of empty? `exists?` issues a better SQL query than `empty?` --- app/models/project.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/project.rb b/app/models/project.rb index 091827f4..d10594a9 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -103,7 +103,7 @@ class Project < ApplicationRecord def stalled? # Stalled projects are active projects with no active next actions return false if self.completed? || self.hidden? - return self.todos.deferred_or_blocked.empty? && self.todos.active.empty? + return !self.todos.deferred_or_blocked.exists? && !self.todos.active.exists? end def shortened_name(length=40)