From ce2a9e227931bf5894d6d630ece276e9066579e9 Mon Sep 17 00:00:00 2001 From: lukemelia Date: Sun, 14 Jan 2007 19:33:11 +0000 Subject: [PATCH] Minor refactor to preare for arRESTing NoteController. Also fixed a recently introduced bug that caused projects or contexts with numbers in the name to fail to resolve properly by URL git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@401 a4c988fc-2ded-0310-b66e-134b36920a42 --- tracks/app/controllers/contexts_controller.rb | 2 +- tracks/app/controllers/note_controller.rb | 2 +- tracks/app/controllers/projects_controller.rb | 2 +- tracks/app/views/projects/show.rhtml | 2 +- tracks/config/routes.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tracks/app/controllers/contexts_controller.rb b/tracks/app/controllers/contexts_controller.rb index 5351fe7f..05fc3c5b 100644 --- a/tracks/app/controllers/contexts_controller.rb +++ b/tracks/app/controllers/contexts_controller.rb @@ -100,7 +100,7 @@ class ContextsController < ApplicationController def check_user_set_context if params['url_friendly_name'] @context = @user.contexts.find_by_url_friendly_name(params['url_friendly_name']) - elsif params['id'] && params['id'] =~ /\d+/ + elsif params['id'] && params['id'] =~ /^\d+$/ @context = @user.contexts.find(params['id']) elsif params['id'] @context = @user.contexts.find_by_url_friendly_name(params['id']) diff --git a/tracks/app/controllers/note_controller.rb b/tracks/app/controllers/note_controller.rb index 5614aafb..46c6bbbd 100644 --- a/tracks/app/controllers/note_controller.rb +++ b/tracks/app/controllers/note_controller.rb @@ -16,7 +16,7 @@ class NoteController < ApplicationController # Add a new note to this project # - def add + def create note = @user.notes.build note.attributes = params["new_note"] diff --git a/tracks/app/controllers/projects_controller.rb b/tracks/app/controllers/projects_controller.rb index f0f75431..b3f3dd8f 100644 --- a/tracks/app/controllers/projects_controller.rb +++ b/tracks/app/controllers/projects_controller.rb @@ -115,7 +115,7 @@ class ProjectsController < ApplicationController def check_user_set_project if params["url_friendly_name"] @project = @user.projects.find_by_url_friendly_name(params["url_friendly_name"]) - elsif params['id'] && params['id'] =~ /\d+/ + elsif params['id'] && params['id'] =~ /^\d+$/ @project = @user.projects.find(params["id"]) elsif params['id'] @project = @user.projects.find_by_url_friendly_name(params["id"]) diff --git a/tracks/app/views/projects/show.rhtml b/tracks/app/views/projects/show.rhtml index df4af22f..ff54f877 100644 --- a/tracks/app/views/projects/show.rhtml +++ b/tracks/app/views/projects/show.rhtml @@ -18,7 +18,7 @@