Merge pull request #193 from mattdbridges/extract-rich-message

Extract behavior from Todo.from_rich_message

test/models/rich_message_extractor_test.rb

@@ -0,0 +1,55 @@
+require 'test/unit'
+require 'active_support/core_ext/object/blank'
+require_relative '../../app/services/rich_message_extractor.rb'
+
+class RichMessageExtractorTest < Test::Unit::TestCase
+
+  def test_message_with_all_options
+    message = "ohai@some-context>in-this-project"
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "ohai", extractor.description
+    assert_equal "some-context", extractor.context
+    assert_equal "in-this-project", extractor.project
+  end
+
+  def test_message_without_project
+    message = "ohai @ some-context"
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "ohai", extractor.description
+    assert_equal "some-context", extractor.context
+    assert_equal nil, extractor.project
+  end
+
+  def test_message_without_project
+    message = " ohai @ some-context"
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "ohai", extractor.description
+    assert_equal "some-context", extractor.context
+    assert_equal nil, extractor.project
+  end
+
+  def test_message_without_project_or_context
+    message = "ohai"
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "ohai", extractor.description
+    assert_equal "", extractor.context
+    assert_equal nil, extractor.project
+  end
+
+  def test_message_without_anything
+    message = ""
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "", extractor.description
+    assert_equal "", extractor.context
+    assert_equal nil, extractor.project
+  end
+
+  def test_message_with_just_a_context
+    message = "@some-context"
+    extractor = RichMessageExtractor.new(message)
+    assert_equal "", extractor.description
+    assert_equal "some-context", extractor.context
+    assert_equal nil, extractor.project
+  end
+
+end

test/models/todo_from_rich_message_test.rb

@@ -0,0 +1,21 @@
+require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
+
+class TodoFromRichMessageTest < ActiveSupport::TestCase
+
+  def setup
+    @completed = Todo.find(8)
+  end
+
+  def test_from_rich_message_adds_to_default_context
+    user = @completed.user
+    default_context_id = @completed.context_id
+    builder = TodoFromRichMessage.new(user, default_context_id, "new todo", "notes")
+    new_todo = builder.construct
+
+    assert_not_nil new_todo
+    assert_equal "new todo", new_todo.description
+    assert_equal "notes", new_todo.notes
+    assert_equal default_context_id, new_todo.context_id
+  end
+
+end

test/models/todo_test.rb

@@ -477,15 +477,4 @@ class TodoTest < ActiveSupport::TestCase
     assert_equal "<p><strong>test</strong></p>", todo.rendered_notes
   end
 
-  def test_from_rich_message_adds_to_default_context
-    user = @completed.user
-    default_context_id = @completed.context_id
-    new_todo = Todo::from_rich_message(user, default_context_id, "new todo", "notes")
-
-    assert_not_nil new_todo
-    assert_equal "new todo", new_todo.description
-    assert_equal "notes", new_todo.notes
-    assert_equal default_context_id, new_todo.context_id
-  end
-  
 end