From c1a66cf4a9dda81e10b24f62e04495928a963a1e Mon Sep 17 00:00:00 2001 From: bsag Date: Sat, 4 Mar 2006 14:22:04 +0000 Subject: [PATCH] Improvements to the init method in todo_controller to avoid an uneccesary SQL query. Thanks Luke! Fixes #222. git-svn-id: http://www.rousette.org.uk/svn/tracks-repos/trunk@201 a4c988fc-2ded-0310-b66e-134b36920a42 --- tracks/app/controllers/todo_controller.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tracks/app/controllers/todo_controller.rb b/tracks/app/controllers/todo_controller.rb index 07a8cd72..3e367d6d 100644 --- a/tracks/app/controllers/todo_controller.rb +++ b/tracks/app/controllers/todo_controller.rb @@ -218,9 +218,7 @@ class TodoController < ApplicationController @projects = @user.projects @contexts = @user.contexts @todos = @user.todos - @done = Todo.find(:all, :conditions => ["todos.user_id = ? and todos.done = ?", @user.id, true], :include => [:project], :order => "completed DESC") - # for some reason, this generates an error about anil object under 0.14.2 - #@done = @todos.collect { |x| x.done? ? x:nil }.compact.sort! {|x,y| y.completed <=> x.completed } + @done = @todos.find_all { |x| x.done } end end