From faaecbae40cbe99e466edfc03275206433557e3f Mon Sep 17 00:00:00 2001 From: Matt Rogers Date: Sat, 17 Nov 2018 09:11:52 -0600 Subject: [PATCH 1/2] Remove `halt_callback_chains_on_return_false` It's deprecated in Rails 5.1 and will block the Rails 5.2 upgrade. --- config/initializers/new_framework_defaults.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/config/initializers/new_framework_defaults.rb b/config/initializers/new_framework_defaults.rb index cbf423a8..534a2396 100644 --- a/config/initializers/new_framework_defaults.rb +++ b/config/initializers/new_framework_defaults.rb @@ -20,6 +20,3 @@ ActiveSupport.to_time_preserves_timezone = false # Require `belongs_to` associations by default. Previous versions had false. Rails.application.config.active_record.belongs_to_required_by_default = false - -# Do not halt callback chains when a callback returns false. Previous versions had true. -ActiveSupport.halt_callback_chains_on_return_false = true From aca54f5aff534f0e71bc1eae390bc753f34b00eb Mon Sep 17 00:00:00 2001 From: Matt Rogers Date: Sat, 17 Nov 2018 09:15:49 -0600 Subject: [PATCH 2/2] Remove `raise_on_unfiltered_parameters` Deprecated and has no effect in Rails 5.1 --- config/initializers/new_framework_defaults.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/initializers/new_framework_defaults.rb b/config/initializers/new_framework_defaults.rb index 534a2396..a2bfed30 100644 --- a/config/initializers/new_framework_defaults.rb +++ b/config/initializers/new_framework_defaults.rb @@ -6,8 +6,6 @@ # # Read the Guide for Upgrading Ruby on Rails for more info on each option. -Rails.application.config.action_controller.raise_on_unfiltered_parameters = true - # Enable per-form CSRF tokens. Previous versions had false. Rails.application.config.action_controller.per_form_csrf_tokens = false