From a2f8327da4064cf5a74f8e5c3bd30b8390dd34e7 Mon Sep 17 00:00:00 2001 From: Eric Allen Date: Sun, 14 Mar 2010 12:29:43 -0400 Subject: [PATCH] Correct walking of entire predecessor tree Fixes #972 --- app/views/todos/add_predecessor.js.rjs | 7 ++++--- app/views/todos/remove_predecessor.js.rjs | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/views/todos/add_predecessor.js.rjs b/app/views/todos/add_predecessor.js.rjs index ee5715a4..40303398 100644 --- a/app/views/todos/add_predecessor.js.rjs +++ b/app/views/todos/add_predecessor.js.rjs @@ -9,10 +9,11 @@ if @saved # regenerate predecessor to add arrow page[@predecessor].replace_html :partial => 'todos/todo', :locals => { :todo => @predecessor, :parent_container_type => parent_container_type } - # regenerate predecessors of predecessor + # regenerate predecessor family parents = @predecessor.predecessors - parents.each do |parent| - puts parent.description + until parents.empty? + parent = parents.pop + parents += parent.predecessors page[parent].replace_html :partial => 'todos/todo', :locals => { :todo => parent, :parent_container_type => parent_container_type } end diff --git a/app/views/todos/remove_predecessor.js.rjs b/app/views/todos/remove_predecessor.js.rjs index 944a829b..07c89a84 100644 --- a/app/views/todos/remove_predecessor.js.rjs +++ b/app/views/todos/remove_predecessor.js.rjs @@ -6,10 +6,11 @@ if @removed page.replace dom_id(@predecessor), :partial => 'todos/todo', :locals => { :todo => @predecessor, :parent_container_type => parent_container_type } - # regenerate predecessors of predecessor + # regenerate predecessor family parents = @predecessor.predecessors - parents.each do |parent| - puts parent.description + until parents.empty? + parent = parents.pop + parents += parent.predecessors page[parent].replace_html :partial => 'todos/todo', :locals => { :todo => parent, :parent_container_type => parent_container_type } end