Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-18 16:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimalized mobile pages - span for empty tags is not included, divs around tr were against html specification and caused some mobiles render the page incorrectly.

Browse source
This commit is contained in:
Jakub A.Tesinsky 2008-12-02 02:22:36 +01:00
parent 229a114441
commit a0d2362953
4 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/helpers/todos_helper.rb
View file

@ -117,7 +117,7 @@ module TodosHelper
"<span class=\"tag\">" + "<span class=\"tag\">" +
link_to(t.name, {:action => "tag", :controller => "todos", :id => t.name+".m"}) + link_to(t.name, {:action => "tag", :controller => "todos", :id => t.name+".m"}) +
"</span>"}.join('') "</span>"}.join('')
"<span class=\"tags\">#{tag_list}</span>" if not tag_list.empty? then "<span class=\"tags\">#{tag_list}</span>" end
end end
def deferred_due_date def deferred_due_date

2
app/views/contexts/_mobile_context.rhtml
View file

@ -6,7 +6,7 @@ if not @not_done.empty?
# only show a context when there are actions in it # only show a context when there are actions in it
-%> -%>
<h2><%=mobile_context.name%></h2> <h2><%=mobile_context.name%></h2>
<table cellpadding="0" cellspacing="0" border="0"> <table cellpadding="0" cellspacing="0" border="0" class="c">
<%= render :partial => "todos/mobile_todo", <%= render :partial => "todos/mobile_todo",
:collection => @not_done, :collection => @not_done,
:locals => { :parent_container_type => "context" }-%> :locals => { :parent_container_type => "context" }-%>

5
app/views/todos/_mobile_todo.rhtml
View file

@ -4,8 +4,7 @@ if mobile_todo.starred?
else else
bullet = "<span class=r>&raquo;&nbsp;</span>" bullet = "<span class=r>&raquo;&nbsp;</span>"
end -%> end -%>
<div class="t" id="<%= dom_id(mobile_todo) %>"> <tr class="t" id="<%= dom_id(mobile_todo) %>" valign="top"><td><%= bullet %></td><td><%
<tr valign="top"><td><%= bullet %></td><td><%
if mobile_todo.completed? if mobile_todo.completed?
-%><span class="m_t_d"> -%><span class="m_t_d">
<% else <% else
@ -23,4 +22,4 @@ end -%>
")</span>" -%> ")</span>" -%>
<% end -%> <% end -%>
<%= tag_list_mobile -%> <%= tag_list_mobile -%>
</span></td></tr></div> </span></td></tr>

8
public/stylesheets/mobile.css
View file

@ -60,10 +60,6 @@ h4.notice {
color: #007E00; color: #007E00;
} }
div.t {
padding-left:5px;
}
span.tag { span.tag {
font-size: XX-small; font-size: XX-small;
background-color: #CCE7FF; background-color: #CCE7FF;
@ -126,3 +122,7 @@ span.prj, span.ctx{
.errors { .errors {
background: #FFC2C2; background: #FFC2C2;
} }
table.c {
margin-left: 5px;
}