From 9f9ae6f83665e283fd303bd38e5f94bd833f2763 Mon Sep 17 00:00:00 2001 From: sf Date: Tue, 27 Sep 2011 08:25:32 -0400 Subject: [PATCH] use select instead of iterating --- app/controllers/projects_controller.rb | 18 ++++++------------ public/stylesheets/standard.css | 3 ++- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb index b8437feb..821d1f79 100644 --- a/app/controllers/projects_controller.rb +++ b/app/controllers/projects_controller.rb @@ -35,22 +35,16 @@ class ProjectsController < ApplicationController def review ## select project that need reviewing - @projects_to_review = Array.new - current_user.projects.each do |project| - @projects_to_review.push project if project.needs_review?(current_user) - end + @projects_to_review = current_user.projects.select {|p| p.needs_review?(current_user)} ## select project that are stalled - @stalled_projects = Array.new - current_user.projects.each do |project| - @stalled_projects.push project if project.stalled? - end + @stalled_projects = current_user.projects.select {|p| p.stalled?} ## select project that are stalled - @blocked_projects = Array.new - current_user.projects.each do |project| - @blocked_projects.push project if project.blocked? - end + @blocked_projects = current_user.projects.select {|p| p.blocked?} + + + @contexts = current_user.contexts.all init_not_done_counts(['project']) diff --git a/public/stylesheets/standard.css b/public/stylesheets/standard.css index 2ed42663..36b21d4d 100644 --- a/public/stylesheets/standard.css +++ b/public/stylesheets/standard.css @@ -2,8 +2,9 @@ background: #ffC; } -.widgets a.reviewed, button.reviewed{ +.widgets a.reviewed, button.reviewed { float:right; +} div.depends_on label { float: left;