Extract pie chart data logic into model layer

Move most of the tests for this logic into the unit test layer.
This commit is contained in:
Katrina Owen 2013-03-17 20:02:16 -06:00
parent 9f3470f9dc
commit 961227da0c
5 changed files with 142 additions and 164 deletions

View file

@ -3,152 +3,32 @@ require File.expand_path(File.dirname(__FILE__) + '/../test_helper')
class ContextActionsDataTest < ActionController::TestCase
tests StatsController
def test_total_with_0_items
login_as(:admin_user)
Stats::TopContextsQuery.any_instance.stubs(:result).returns []
get :context_total_actions_data
assert_equal [], assigns[:actions_per_context]
end
def test_total_with_less_than_10_items
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_total_actions_data
assert_equal contexts, assigns[:actions_per_context]
end
def test_total_with_exactly_10_items
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6},
{'id' => 10, 'name' => 'ten', 'total' => 19}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_total_actions_data
assert_equal contexts, assigns[:actions_per_context]
end
def test_total_with_more_than_10_items
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6},
{'id' => 10, 'name' => 'ten', 'total' => 19},
{'id' => 11, 'name' => 'eleven', 'total' => 14}
{'id' => 3, 'name' => 'three', 'total' => 8}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_total_actions_data
contexts.pop
contexts[-1] = {'id' => -1, 'name' => '(others)', 'total' => 33}
assert_equal contexts, assigns[:actions_per_context]
assert_equal [47, 17, 34], assigns[:data].values
end
def test_running_with_0_items
login_as(:admin_user)
Stats::TopContextsQuery.any_instance.stubs(:result).returns []
get :context_running_actions_data
assert_equal [], assigns[:actions_per_context]
end
def test_running_with_less_than_10_items
def test_running_actions
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6}
{'id' => 3, 'name' => 'three', 'total' => 8}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_running_actions_data
assert_equal contexts, assigns[:actions_per_context]
end
def test_running_with_exactly_10_items
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6},
{'id' => 10, 'name' => 'ten', 'total' => 19}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_running_actions_data
assert_equal contexts, assigns[:actions_per_context]
end
def test_running_with_more_than_10_items
login_as(:admin_user)
contexts = [
{'id' => 1, 'name' => 'one', 'total' => 11},
{'id' => 2, 'name' => 'two', 'total' => 4},
{'id' => 3, 'name' => 'three', 'total' => 8},
{'id' => 4, 'name' => 'four', 'total' => 13},
{'id' => 5, 'name' => 'five', 'total' => 20},
{'id' => 6, 'name' => 'six', 'total' => 17},
{'id' => 7, 'name' => 'seven', 'total' => 5},
{'id' => 8, 'name' => 'eight', 'total' => 1},
{'id' => 9, 'name' => 'nine', 'total' => 6},
{'id' => 10, 'name' => 'ten', 'total' => 19},
{'id' => 11, 'name' => 'eleven', 'total' => 14}
]
Stats::TopContextsQuery.any_instance.stubs(:result).returns contexts
get :context_running_actions_data
contexts.pop
contexts[-1] = {'id' => -1, 'name' => '(others)', 'total' => 33}
assert_equal contexts, assigns[:actions_per_context]
assert_equal [47, 17, 34], assigns[:data].values
end
end