fix failing test and make sure that you can supply 'starred' tag. Refactor todo model

app/controllers/todos_controller.rb

@@ -90,7 +90,7 @@ class TodosController < ApplicationController
       end
 
       if @todo.errors.empty?
-        @todo.starred= (params[:new_todo_starred]||"").include? "true"
+        @todo.starred= (params[:new_todo_starred]||"").include? "true" if params[:new_todo_starred]
 
         @todo.add_predecessor_list(predecessor_list)
 
@@ -1516,6 +1516,13 @@ class TodosController < ApplicationController
       @params = params['request'] || params
       @prefs = prefs
       @attributes = params['request'] && params['request']['todo']  || params['todo']
+
+      if @attributes[:tags]
+        # the REST api may use <tags> which will collide with tags association, so rename tags to add_tags
+        add_tags = @attributes[:tags]
+        @attributes.delete :tags
+        @attributes[:add_tags] = add_tags
+      end
     end
 
     def attributes

app/models/todo.rb

@@ -353,22 +353,12 @@ class Todo < ActiveRecord::Base
     end
   end
 
-  def tags=(params)
-    value = params[:tag]
-    
-    if !value.nil?
-      if value.class == Array
-        value.each do |attrs|
-          tags.build(attrs)
-        end
-      else 
-        tags.build(value)
-      end
-    end
+  # used by the REST API. <tags> will also work, this is renamed to add_tags in TodosController::TodoCreateParamsHelper::initialize
+  def add_tags=(params)
+    tag_with params[:tag].inject([]) { |list, value| list << value[:name] } unless params[:tag].nil?
   end
 
   # Rich Todo API
-
   def self.from_rich_message(user, default_context_id, description, notes)
     fields = description.match(/([^>@]*)@?([^>]*)>?(.*)/)
     description = fields[1].strip

test/integration/todo_xml_api_test.rb

@@ -76,6 +76,7 @@ class TodoXmlApiTest < ActionController::IntegrationTest
   <project_id>#{projects(:timemachine).id}</project_id>
   <tags>
     <tag><name>starred</name></tag>
+    <tag><name>starred1</name></tag>
     <tag><name>starred2</name></tag>
   </tags>
 </todo>"
@@ -83,7 +84,8 @@ class TodoXmlApiTest < ActionController::IntegrationTest
     assert_response :success
     todo = @user.todos.find_by_description("this will succeed 3")
     assert_not_nil todo
-    assert !todo.starred?
+    assert_equal "starred, starred1, starred2", todo.tag_list
+    assert todo.starred?
   end
 
   def test_post_create_todo_with_new_context