Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-18 00:00:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing bug #1442

Browse source 
This bug was caused when the chart encountered data outside of its
visible range (i.e., the upper bound of the array size). A test was
added that inserts some data from 2 years and 16 months in the past.
The test failed on the old version, throwing exactly the error in bug
report #1442.

The fix is to check whether or not the value is within the array range
before sending the "+=" operator. With this change, the test passes.
This commit is contained in:
Don Cruse 2013-07-28 19:00:51 -05:00
parent 58e0393efa
commit 8ed20b35f2
2 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/controllers/stats_controller_test.rb
View file

@ -142,6 +142,28 @@ class StatsControllerTest < ActionController::TestCase
end
end
def test_empty_last12months_data
Timecop.travel(Time.local(2013, 1, 15)) do
login_as(:admin_user)
@current_user = User.find(users(:admin_user).id)
@current_user.todos.delete_all
given_todos_for_stats
get :actions_done_last12months_data
assert_response :success
end
end
def test_out_of_bounds_events_for_last12months_data
login_as(:admin_user)
@current_user = User.find(users(:admin_user).id)
@current_user.todos.delete_all
create_todo_in_past(2.years)
create_todo_in_past(15.months)
get :actions_done_last12months_data
assert_response :success
end
def test_actions_done_last30days_data
login_as(:admin_user)
@current_user = User.find(users(:admin_user).id)