mirror of
https://github.com/TracksApp/tracks.git
synced 2025-12-16 23:30:12 +01:00
fix corner case that were failing the cucumber tests. On the calendar page at the end of the month, a todo may occur twice on the page. This was not taken into account for update an destroy
This commit is contained in:
parent
0ccf42d08c
commit
7f27a6e2bd
6 changed files with 36 additions and 15 deletions
1
.gitignore
vendored
1
.gitignore
vendored
|
|
@ -2,6 +2,7 @@
|
||||||
*.tmproj
|
*.tmproj
|
||||||
.dotest
|
.dotest
|
||||||
/.emacs-project
|
/.emacs-project
|
||||||
|
/.redcar
|
||||||
config/database.yml
|
config/database.yml
|
||||||
config/site.yml
|
config/site.yml
|
||||||
config/deploy.rb
|
config/deploy.rb
|
||||||
|
|
|
||||||
|
|
@ -1279,6 +1279,16 @@ class TodosController < ApplicationController
|
||||||
true
|
true
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def determine_non_uniq_todo
|
||||||
|
# for calendar view. TODO: unused
|
||||||
|
all_list_uniq_ids = (@due_today.map(&:id) + @due_this_week.map(&:id) +
|
||||||
|
@due_next_week.map(&:id) + @due_this_month.map(&:id) + @due_after_this_month.map(&:id)).uniq
|
||||||
|
all_list_count = @due_today.count + @due_this_week.count +
|
||||||
|
@due_next_week.count + @due_this_month.count + @due_after_this_month.count
|
||||||
|
|
||||||
|
return !( all_list_uniq_ids.length == all_list_count )
|
||||||
|
end
|
||||||
|
|
||||||
class FindConditionBuilder
|
class FindConditionBuilder
|
||||||
|
|
||||||
def initialize
|
def initialize
|
||||||
|
|
|
||||||
|
|
@ -32,19 +32,24 @@ function show_empty_messages() {
|
||||||
|
|
||||||
function remove_todo_from_page() {
|
function remove_todo_from_page() {
|
||||||
<% if (@remaining_in_context == 0) && update_needs_to_hide_context
|
<% if (@remaining_in_context == 0) && update_needs_to_hide_context
|
||||||
# remove context with deleted todo
|
# remove context with deleted todo
|
||||||
-%>
|
-%>
|
||||||
$('#c<%=@todo.context_id%>').fadeOut(400, function() {
|
$('#c<%=@todo.context_id%>').fadeOut(400, function() {
|
||||||
$('#<%=dom_id(@todo)%>').remove();
|
$('#<%=dom_id(@todo)%>').remove();
|
||||||
});
|
});
|
||||||
<%= show_empty_message_in_source_container -%>
|
<%= show_empty_message_in_source_container -%>
|
||||||
<% else
|
<% else
|
||||||
# remove only the todo
|
# remove only the todo
|
||||||
-%>
|
-%>
|
||||||
<%= show_empty_message_in_source_container %>
|
<%= show_empty_message_in_source_container %>
|
||||||
$('#<%=dom_id(@todo)%>').slideUp(400, function() {
|
$('#<%=dom_id(@todo)%>').slideUp(400, function() {
|
||||||
$('#<%=dom_id(@todo)%>').remove();
|
$('#<%=dom_id(@todo)%>').remove();
|
||||||
});
|
<% if source_view_is :calendar
|
||||||
|
# in calendar view it is possible to have a todo twice on the page
|
||||||
|
-%>
|
||||||
|
$('#<%=dom_id(@todo)%>').remove();
|
||||||
|
<% end %>
|
||||||
|
});
|
||||||
<% end -%>
|
<% end -%>
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -27,6 +27,11 @@
|
||||||
function remove_todo(next_steps) {
|
function remove_todo(next_steps) {
|
||||||
$('#<%= dom_id(@todo) %>').fadeOut(400, function() {
|
$('#<%= dom_id(@todo) %>').fadeOut(400, function() {
|
||||||
$('#<%= dom_id(@todo) %>').remove();
|
$('#<%= dom_id(@todo) %>').remove();
|
||||||
|
<% if source_view_is :calendar
|
||||||
|
# in calendar view it is possible to have a todo twice on the page
|
||||||
|
-%>
|
||||||
|
$('#<%= dom_id(@todo) %>').remove();
|
||||||
|
<% end %>
|
||||||
<%= show_empty_message_in_source_container -%>
|
<%= show_empty_message_in_source_container -%>
|
||||||
next_steps.go();
|
next_steps.go();
|
||||||
});
|
});
|
||||||
|
|
|
||||||
|
|
@ -327,7 +327,7 @@ nl:
|
||||||
show_tomorrow: Toon morgen
|
show_tomorrow: Toon morgen
|
||||||
calendar:
|
calendar:
|
||||||
get_in_ical_format: Ontvang deze agenda in iCal-formaat
|
get_in_ical_format: Ontvang deze agenda in iCal-formaat
|
||||||
due_next_week: Deadline deze week
|
due_next_week: Deadline volgende week
|
||||||
due_this_week: Deadline in rest van deze week
|
due_this_week: Deadline in rest van deze week
|
||||||
no_actions_due_next_week: Geen acties met deadline in volgende week
|
no_actions_due_next_week: Geen acties met deadline in volgende week
|
||||||
due_today: Deadline vandaag
|
due_today: Deadline vandaag
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue