From 3d3646a1378c632ea9c891e044ca98bc64872492 Mon Sep 17 00:00:00 2001 From: sf Date: Sat, 8 Oct 2011 00:23:31 -0400 Subject: [PATCH 1/2] completed reviews no longer show up that they need a review --- app/models/project.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/models/project.rb b/app/models/project.rb index 9d26a26e..33814525 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -108,6 +108,7 @@ class Project < ActiveRecord::Base end def needs_review?(current_user) + return false if self.completed? return true if last_reviewed.nil? return (active? && (last_reviewed < current_user.time - current_user.prefs.review_period.days)) end From 90f9e41671890f5ba249da2cc20ef7b38cc1493e Mon Sep 17 00:00:00 2001 From: sf Date: Mon, 10 Oct 2011 05:36:56 -0400 Subject: [PATCH 2/2] changed the condition to increase readability --- app/models/project.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/models/project.rb b/app/models/project.rb index 33814525..f3f43d12 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -108,9 +108,8 @@ class Project < ActiveRecord::Base end def needs_review?(current_user) - return false if self.completed? - return true if last_reviewed.nil? - return (active? && (last_reviewed < current_user.time - current_user.prefs.review_period.days)) + return active? && ( last_reviewed.nil? || + (last_reviewed < current_user.time - current_user.prefs.review_period.days)) end def blocked?