From 66f7fe9f2befc41b5d88f57656243e2b4c24f4e0 Mon Sep 17 00:00:00 2001
From: Reinier Balt <lrbalt@gmail.com>
Date: Mon, 29 Apr 2013 09:41:55 +0200
Subject: [PATCH] remove caching from viewing dependencies

this causes stack overflow in some cases
---
 app/views/todos/_successor.html.erb | 49 ++++++++++++++---------------
 1 file changed, 23 insertions(+), 26 deletions(-)

diff --git a/app/views/todos/_successor.html.erb b/app/views/todos/_successor.html.erb
index 0b932012..44757c30 100644
--- a/app/views/todos/_successor.html.erb
+++ b/app/views/todos/_successor.html.erb
@@ -1,32 +1,29 @@
 <%
 @rec_depth ||= 0
-
-cache [successor, "successor"] do
 %>
-  <div id="<%= dom_id(successor, 'successor') %>" class="item-container">
-    <div id="<%= dom_id(successor, 'successor_line') %>">
-      <div class="description<%= staleness_class( successor ) %>" style="margin-left: 20px">
-        <span class="todo.descr"><%= h sanitize(successor.description) %></span>
-  
-        <%= remote_delete_dependency(successor, predecessor) %>
-  
-        <% unless successor.pending_successors.empty?
-          if @rec_depth < 8
-            @rec_depth+=1 %>
-            <div class="todo_successors" id="<%= dom_id(successor, 'successors') %>">
-              <%= render :partial => "todos/successor",
-                :collection => successor.pending_successors,
-                :locals => { :todo => successor,
-                :parent_container_type => parent_container_type,
-                :suppress_dependencies => true,
-                :predecessor => successor }
-              %>
-            </div>
-          <% else %>
-            <a title="There are more dependencies that are not shown">[...]</a>
-          <% end %>
+<div id="<%= dom_id(successor, 'successor') %>" class="item-container">
+  <div id="<%= dom_id(successor, 'successor_line') %>">
+    <div class="description<%= staleness_class( successor ) %>" style="margin-left: 20px">
+      <span class="todo.descr"><%= h sanitize(successor.description) %></span>
+
+      <%= remote_delete_dependency(successor, predecessor) %>
+
+      <% unless successor.pending_successors.empty?
+        if @rec_depth < 8
+          @rec_depth+=1 %>
+          <div class="todo_successors" id="<%= dom_id(successor, 'successors') %>">
+            <%= render :partial => "todos/successor",
+              :collection => successor.pending_successors,
+              :locals => { :todo => successor,
+              :parent_container_type => parent_container_type,
+              :suppress_dependencies => true,
+              :predecessor => successor }
+            %>
+          </div>
+        <% else %>
+          <a title="There are more dependencies that are not shown">[...]</a>
         <% end %>
-      </div>
+      <% end %>
     </div>
   </div>
-<% end %>
\ No newline at end of file
+</div>
\ No newline at end of file