fix #1406. fix #1431. set recurring_period first before setting other attributes

This commit is contained in:
Reinier Balt 2013-06-19 16:41:44 +02:00
parent 56b884055f
commit 64d3e802f2

View file

@ -101,7 +101,10 @@ class RecurringTodosController < ApplicationController
p.attributes['end_date']=parse_date_per_user_prefs(p.attributes['end_date'])
p.attributes['start_from']=parse_date_per_user_prefs(p.attributes['start_from'])
@recurring_todo = current_user.recurring_todos.build(p.selector_attributes)
# make sure we set :recurring_period first, since other setters depend on it being set
# TODO: move logic into model
@recurring_todo = current_user.recurring_todos.build(:recurring_period => params[:recurring_period])
@recurring_todo.assign_attributes(p.selector_attributes)
@recurring_todo.update_attributes(p.attributes)
if p.project_specified_by_name?