Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2026-01-16 22:25:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use the keyword args syntax for controller actions

Browse source 
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
This commit is contained in:
Matt Rogers 2018-11-03 11:00:27 -05:00
parent 755a7a1b80
commit 2f85a42f91
No known key found for this signature in database
GPG key ID: 605D017C07EB4316
19 changed files with 258 additions and 241 deletions
Download patch file Download diff file Expand all files Collapse all files

18
test/controllers/login_controller_test.rb
View file

@ -11,7 +11,7 @@ class LoginControllerTest < ActionController::TestCase
#============================================
def test_invalid_login
post :login, {:user_login => 'cracker', :user_password => 'secret', :user_noexpiry => 'on'}
post :login, params: {:user_login => 'cracker', :user_password => 'secret', :user_noexpiry => 'on'}
assert_response :success
assert(!session[:user_id])
assert_template "login"
@ -19,7 +19,7 @@ class LoginControllerTest < ActionController::TestCase
def test_login_with_valid_admin_user
@request.session['return-to'] = "/bogus/location"
post :login, {:user_login => 'admin', :user_password => 'abracadabra', :user_noexpiry => 'on'}
post :login, params: {:user_login => 'admin', :user_password => 'abracadabra', :user_noexpiry => 'on'}
user = User.find(session['user_id'])
assert_not_nil user
assert_equal user.id, session['user_id']
@ -30,7 +30,7 @@ class LoginControllerTest < ActionController::TestCase
end
def test_login_with_valid_standard_user
post :login, {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
post :login, params: {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
user = User.find(session['user_id'])
assert_not_nil user
assert_equal user.id, session['user_id']
@ -56,26 +56,26 @@ class LoginControllerTest < ActionController::TestCase
# Test login with a bad password for existing user
#
def test_login_bad_password
post :login, {:user_login => 'jane', :user_password => 'wrong', :user_noexpiry => 'on'}
post :login, params: {:user_login => 'jane', :user_password => 'wrong', :user_noexpiry => 'on'}
assert(!session[:user])
assert_equal "Login unsuccessful.", flash[:warning]
assert_response :success
end
def test_login_bad_login
post :login, {:user_login => 'blah', :user_password => 'sesame', :user_noexpiry => 'on'}
post :login, params: {:user_login => 'blah', :user_password => 'sesame', :user_noexpiry => 'on'}
assert(!session[:user])
assert_equal "Login unsuccessful.", flash[:warning]
assert_response :success
end
def test_should_remember_me
post :login, :user_login => 'jane', :user_password => 'sesame', :user_noexpiry => "on"
post :login, params: { :user_login => 'jane', :user_password => 'sesame', :user_noexpiry => "on" }
assert_not_nil @response.cookies["auth_token"]
end
def test_should_not_remember_me
post :login, :user_login => 'jane', :user_password => 'sesame', :user_noexpiry => "off"
post :login, params: { :user_login => 'jane', :user_password => 'sesame', :user_noexpiry => "off" }
assert_nil @response.cookies["auth_token"]
end
@ -113,7 +113,7 @@ class LoginControllerTest < ActionController::TestCase
end
def test_current_user_correct
post :login, {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
post :login, params: {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
assert_equal users(:other_user), @controller.current_user
end
@ -124,7 +124,7 @@ class LoginControllerTest < ActionController::TestCase
end
def test_prefs_correct
post :login, {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
post :login, params: {:user_login => 'jane', :user_password => 'sesame', :user_noexpiry => 'off'}
assert_equal users(:other_user).prefs, @controller.prefs
end