fix #1102 add spinner to autocomplete and...

* get public/local variables correct for all js
* get i18n string in toggle_star for todos

Signed-off-by: Reinier Balt <lrbalt@gmail.com>

app/views/projects/update_default_context.js.rjs

@@ -1,3 +1,5 @@
+# TODO: is this DEAD code?
+
 if @project.default_context.nil?
   page.notify :notice, t('projects.default_context_removed'), 5.0
 else

app/views/projects/update_default_tags.js.rjs

@@ -1,3 +1,4 @@
+# TODO: is this dead code?
 if @project.default_tags.nil?
   page.notify :notice, t('projects.default_tags_removed_notice'), 5.0
 else

app/views/projects/update_project_name.js.rjs

@@ -1,3 +1,4 @@
+#TODO: is this dead code?
 page['default_project_name_id'].value = @project.name
 page['todo_project_name'].value = @project.name
 

app/views/projects/update_status.js.rjs

@@ -1,3 +1,4 @@
+# TODO: is this dead code?
 page.select('#project_status .active span').each do |element|
   element.className = @project.current_state == :active ? 'active_state' : 'inactive_state'
 end

app/views/recurring_todos/toggle_star.js.erb

@@ -1,4 +1,4 @@
-<% if @saved -%>
+<%- if @saved -%>
   $('div#recurring_todo_<%= @recurring_todo.id %> a.star_item img').toggleClass('starred_todo').toggleClass('unstarred_todo');
 <%- else -%>
   TracksPages.page_notify('error', '<%= t('todos.error_starring_recurring', :description => @recurring_todo.description) %>', 8);

app/views/todos/toggle_star.js.erb

@@ -1,5 +1,5 @@
-<% if @saved -%>
+<%- if @saved -%>
   $('div#line_todo_<%= @todo.id %> a.star_item img').toggleClass('starred_todo').toggleClass('unstarred_todo');
-<% else -%>
-  TracksPages.page_notify('error', "Could not toggle the star of this todo", 5);
-<% end -%>
+<%- else -%>
+  TracksPages.page_notify('error', '<%= t('todos.error_starring', :description => @todo.description) %>', 8);
+<%- end -%>