Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-18 00:00:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use !exists? instead of empty?

Browse source 
`exists?` issues a better SQL query than `empty?`
This commit is contained in:
Matt Rogers 2019-05-04 15:16:36 -05:00
parent 996395cc80
commit 11b9081064
No known key found for this signature in database
GPG key ID: 605D017C07EB4316
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/project.rb
View file

@ -103,7 +103,7 @@ class Project < ApplicationRecord
def stalled? def stalled?
# Stalled projects are active projects with no active next actions # Stalled projects are active projects with no active next actions
return false if self.completed? || self.hidden? return false if self.completed? || self.hidden?
return self.todos.deferred_or_blocked.empty? && self.todos.active.empty? return !self.todos.deferred_or_blocked.exists? && !self.todos.active.exists?
end end
def shortened_name(length=40) def shortened_name(length=40)