Andreas/siyuan
1
0
Fork 0
mirror of https://github.com/siyuan-note/siyuan.git synced 2025-12-16 22:50:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

🐛 Nested lists cause hang after collapsing headings https://github.com/siyuan-note/siyuan/issues/15943

Browse source 
Signed-off-by: Daniel <845765@qq.com>
This commit is contained in:
Daniel 2025-09-27 19:29:40 +08:00
parent 4872eadf5d
commit dc7685a262
No known key found for this signature in database
GPG key ID: 86211BA83DF03017
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
kernel/model/transaction.go
View file

@ -439,6 +439,25 @@ func (tx *Transaction) doMove(operation *Operation) (ret *TxErr) {
return
}
if 0 < len(headingChildren) {
// 折叠标题再编辑形成外层列表（前面加上 * ）时，前端给的 tx 序列会形成死循环，在这里解开
// Nested lists cause hang after collapsing headings https://github.com/siyuan-note/siyuan/issues/15943
lastChild := headingChildren[len(headingChildren)-1]
if "1" == lastChild.IALAttr("heading-fold") && ast.NodeList == lastChild.Type &&
nil != lastChild.FirstChild && nil != lastChild.FirstChild.FirstChild && lastChild.FirstChild.FirstChild.ID == targetPreviousID {
ast.Walk(lastChild, func(n *ast.Node, entering bool) ast.WalkStatus {
if !entering || !n.IsBlock() {
return ast.WalkContinue
}
n.RemoveIALAttr("heading-fold")
n.RemoveIALAttr("fold")
return ast.WalkContinue
})
headingChildren = headingChildren[:len(headingChildren)-1]
}
}
for i := len(headingChildren) - 1; -1 < i; i-- {
c := headingChildren[i]
targetNode.InsertAfter(c)