From bbbdda7ef0cc975942b03a22b323805bd4d107b1 Mon Sep 17 00:00:00 2001 From: Daniel <845765@qq.com> Date: Fri, 10 Nov 2023 17:10:28 +0800 Subject: [PATCH] :art: Adding row overwriting data after enabling sort in database https://github.com/siyuan-note/siyuan/issues/9599 --- kernel/av/table.go | 5 ----- kernel/model/attribute_view.go | 5 ++++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/kernel/av/table.go b/kernel/av/table.go index 77f0cdf78..9efce576e 100644 --- a/kernel/av/table.go +++ b/kernel/av/table.go @@ -626,11 +626,6 @@ func (table *Table) SortRows() { } sort.Slice(table.Rows, func(i, j int) bool { - block := table.Rows[i].GetBlockValue() - if !block.IsInitialized && nil != block.Block && "" == block.Block.Content && block.IsDetached { - return false - } - for _, colIndexSort := range colIndexSorts { result := table.Rows[i].Cells[colIndexSort.Index].Value.Compare(table.Rows[j].Cells[colIndexSort.Index].Value) if 0 == result { diff --git a/kernel/model/attribute_view.go b/kernel/model/attribute_view.go index 7de99c1ea..f9fadfb9d 100644 --- a/kernel/model/attribute_view.go +++ b/kernel/model/attribute_view.go @@ -712,7 +712,10 @@ func addAttributeViewBlock(blockID string, operation *Operation, tree *parse.Tre return } } else { - blockID = ast.NewNodeID() + if "" == blockID { + blockID = ast.NewNodeID() + logging.LogWarnf("detached block id is empty, generate a new one [%s]", blockID) + } } attrView, err := av.ParseAttributeView(operation.AvID)