Andreas/siyuan
1
0
Fork 0
mirror of https://github.com/siyuan-note/siyuan.git synced 2025-12-31 05:48:49 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve the response status code of kernel API /api/file/getFile (#9075)

Browse source 
* 🎨 Improve the response status code of API `/api/file/getFile`

* refactor: change status code from `204` to `202`
This commit is contained in:
Yingyi / 颖逸 2023-08-30 23:45:24 +08:00 • committed by GitHub
parent dc3889b5b3
commit baa3ef0bb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
kernel/api/file.go
View file

@ -84,7 +84,7 @@ func getFile(c *gin.Context) {
ret := gulu.Ret.NewResult()
arg, ok := util.JsonArg(c, ret)
if !ok {
c.JSON(http.StatusOK, ret)
c.JSON(http.StatusAccepted, ret)
return
}
@ -93,21 +93,21 @@ func getFile(c *gin.Context) {
info, err := os.Stat(filePath)
if os.IsNotExist(err) {
ret.Code = 404
c.JSON(http.StatusOK, ret)
c.JSON(http.StatusAccepted, ret)
return
}
if nil != err {
logging.LogErrorf("stat [%s] failed: %s", filePath, err)
ret.Code = 500
ret.Msg = err.Error()
c.JSON(http.StatusOK, ret)
c.JSON(http.StatusAccepted, ret)
return
}
if info.IsDir() {
logging.LogErrorf("file [%s] is a directory", filePath)
ret.Code = 405
ret.Msg = "file is a directory"
c.JSON(http.StatusOK, ret)
c.JSON(http.StatusAccepted, ret)
return
}
@ -116,7 +116,7 @@ func getFile(c *gin.Context) {
logging.LogErrorf("read file [%s] failed: %s", filePath, err)
ret.Code = 500
ret.Msg = err.Error()
c.JSON(http.StatusOK, ret)
c.JSON(http.StatusAccepted, ret)
return
}