Andreas/siyuan
1
0
Fork 0
mirror of https://github.com/siyuan-note/siyuan.git synced 2025-12-16 22:50:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

🐛 Repeated escaping in preview area when searching for matching doc blocks https://github.com/siyuan-note/siyuan/issues/10219

Browse source
This commit is contained in:
Daniel 2024-01-19 17:53:21 +08:00
parent c68396a687
commit a9092ce18d
No known key found for this signature in database
GPG key ID: 86211BA83DF03017
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
kernel/model/search.go
View file

@ -1298,12 +1298,15 @@ func stringQuery(query string) string {
func markReplaceSpan(n *ast.Node, unlinks *[]*ast.Node, keywords []string, markSpanDataType string, luteEngine *lute.Lute) bool { func markReplaceSpan(n *ast.Node, unlinks *[]*ast.Node, keywords []string, markSpanDataType string, luteEngine *lute.Lute) bool {
text := n.Content() text := n.Content()
if ast.NodeText == n.Type { if ast.NodeText == n.Type {
text = util.EscapeHTML(text) escapedText := util.EscapeHTML(text)
escapedKeywords := make([]string, len(keywords)) escapedKeywords := make([]string, len(keywords))
for i, keyword := range keywords { for i, keyword := range keywords {
escapedKeywords[i] = util.EscapeHTML(keyword) escapedKeywords[i] = util.EscapeHTML(keyword)
} }
text = search.EncloseHighlighting(text, escapedKeywords, search.GetMarkSpanStart(markSpanDataType), search.GetMarkSpanEnd(), Conf.Search.CaseSensitive, false) hText := search.EncloseHighlighting(escapedText, escapedKeywords, search.GetMarkSpanStart(markSpanDataType), search.GetMarkSpanEnd(), Conf.Search.CaseSensitive, false)
if hText != escapedText {
text = hText
}
n.Tokens = gulu.Str.ToBytes(text) n.Tokens = gulu.Str.ToBytes(text)
if bytes.Contains(n.Tokens, []byte(search.MarkDataType)) { if bytes.Contains(n.Tokens, []byte(search.MarkDataType)) {
linkTree := parse.Inline("", n.Tokens, luteEngine.ParseOptions) linkTree := parse.Inline("", n.Tokens, luteEngine.ParseOptions)

6
kernel/util/misc.go
View file

@ -43,7 +43,11 @@ func RemoveElem[T any](s []T, index int) []T {
} }
func EscapeHTML(s string) string { func EscapeHTML(s string) string {
if strings.ContainsAny(s, "<>\"'") { if strings.Contains(s, "&amp;") {
return s
}
if strings.ContainsAny(s, "<>\"'&") {
return html.EscapeString(s) return html.EscapeString(s)
} }
return s return s