From 9567b24d76642d9b4f825d8f9819931ab01f14c3 Mon Sep 17 00:00:00 2001 From: Vanessa Date: Wed, 15 Mar 2023 12:04:51 +0800 Subject: [PATCH] =?UTF-8?q?:bug:=20PDF=20=E9=A1=B5=E7=AD=BE=E6=89=93?= =?UTF-8?q?=E5=BC=80=E8=BF=9B=E5=BA=A6=E5=92=8C=E7=99=BD=E8=BE=B9=E9=97=AE?= =?UTF-8?q?=E9=A2=98=20Fix=20https://github.com/siyuan-note/siyuan/issues/?= =?UTF-8?q?7671?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/src/asset/pdf/app.js | 3 ++- app/src/asset/pdf/ui_utils.js | 5 +++-- app/src/assets/scss/pdf/_pdf.scss | 3 +-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/app/src/asset/pdf/app.js b/app/src/asset/pdf/app.js index b39b87fc6..15103b089 100644 --- a/app/src/asset/pdf/app.js +++ b/app/src/asset/pdf/app.js @@ -665,7 +665,8 @@ class PDFViewerApplication { } get loadingBar () { - const bar = new ProgressBar('loadingBar') + // NOTE + const bar = new ProgressBar(this.appConfig.appContainer.querySelector("#loadingBar")) return shadow(this, 'loadingBar', bar) } diff --git a/app/src/asset/pdf/ui_utils.js b/app/src/asset/pdf/ui_utils.js index 381219f0c..848ed5577 100644 --- a/app/src/asset/pdf/ui_utils.js +++ b/app/src/asset/pdf/ui_utils.js @@ -699,8 +699,8 @@ class ProgressBar { #visible = true; - constructor(id) { - const bar = document.getElementById(id); + // NOTE + constructor(bar) { this.#classList = bar.classList; } @@ -738,6 +738,7 @@ class ProgressBar { this.#visible = false; // NOTE this.#classList.add("fn__hidden"); + docStyle.setProperty("--progressBar-percent", "0"); } show() { diff --git a/app/src/assets/scss/pdf/_pdf.scss b/app/src/assets/scss/pdf/_pdf.scss index 9e61c77ea..85a5f3b8f 100644 --- a/app/src/assets/scss/pdf/_pdf.scss +++ b/app/src/assets/scss/pdf/_pdf.scss @@ -248,7 +248,6 @@ position: absolute; height: 4px; background-color: var(--b3-theme-on-background); - border-bottom: 1px solid var(--b3-theme-surface-lighter); transition-duration: 200ms; transition-timing-function: ease; z-index: 1; @@ -273,7 +272,7 @@ position: absolute; top: 0; left: 0; - width: 0%; + width: var(--progressBar-percent); height: 100%; background-color: var(--b3-theme-primary-light); overflow: hidden;