From ebc248c362bac6b8c4d9d0a8135b96b2d454f34f Mon Sep 17 00:00:00 2001 From: Liang Ding Date: Wed, 29 Mar 2023 13:09:31 +0800 Subject: [PATCH 1/4] :octocat: English support https://github.com/siyuan-note/siyuan/issues/7758 --- .github/ISSUE_TEMPLATE/bug_report.yml | 37 ++++++++-------------- .github/ISSUE_TEMPLATE/feature_request.yml | 18 ++++------- 2 files changed, 20 insertions(+), 35 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 655f2398d..0e8178bcb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,67 +1,58 @@ -name: 🐛 缺陷报告 Bug Report -description: 报告缺陷以帮助我们进行改进 Report defects to help us improve -title: "请输入问题报告标题 Please enter the title of the bug report" +name: 🐛 Bug Report +description: Report defects to help us improve +title: "Please enter the title of the bug report" body: - type: checkboxes attributes: - label: 该问题是否已经被报告过了？ Is there an existing issue for this? + label: Is there an existing issue for this? description: | - 请搜索以查看你遇到的问题是否已经被报告过。 Please search to see if an issue already exists for the bug you encountered. options: - - label: | - 我已经搜索了 Issues，没有发现类似问题 + - label: | I have searched the existing issues required: true - type: checkboxes attributes: - label: 该问题是否能够在默认主题（daylight/midnight）下重现？ Can the issue be reproduced with the default theme (daylight/midnight)? + label: Can the issue be reproduced with the default theme (daylight/midnight)? description: | - 请确认该问题能够在默认主题下重现。 Please confirm that the issue can be reproduced with the default theme. options: - label: | - 我能够在默认主题下重现该问题 I was able to reproduce the issue with the default theme required: true - type: checkboxes attributes: - label: 该问题是否可能是由于扩展功能导致？ Could the issue be due to extensions? + label: Could the issue be due to extensions? description: | - 请注意主题、代码片段、挂件或者其他扩展功能可能会导致问题。 Be aware that themes, code snippets, widgets, or other extensions may cause problems. options: - label: | - 我已经排除了扩展导致问题的可能性 I've ruled out the possibility that the extension is causing the problem. required: true - type: textarea attributes: - label: 描述问题 Describe the problem + label: Describe the problem description: | - 请尽量清晰地描述你遇到的问题。 Please describe the problem you are experiencing as clearly as possible. validations: required: true - type: textarea attributes: - label: 期待的结果 Expected result + label: Expected result description: | - 请尽量清晰地描述你所期待的结果。 Please be as clear and accurate as possible to describe the results you are looking for. validations: required: true - type: textarea attributes: - label: 截屏或者录屏演示 Screenshot or screen recording presentation + label: Screenshot or screen recording presentation description: | - 请通过截屏或者录屏演示你碰到的问题。 Please try to attach screenshots or videos to describe the problem you are experiencing. validations: required: false - type: textarea attributes: - label: 版本环境 Version environment + label: Version environment value: | - Version: - Operating System: @@ -71,17 +62,15 @@ body: required: true - type: textarea attributes: - label: 日志文件 Log file + label: Log file description: | - 请提供内核日志 `工作空间/temp/siyuan.log` The program log file is located at `workspace/temp/siyuan.log` validations: required: true - type: textarea attributes: - label: 更多信息 More information + label: More information description: | - 请提供任何附加信息，以帮助我们更好地定位问题。 Please provide other additional information to help us diagnose the problem. validations: required: false \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index e94f60371..15caea7d1 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,36 +1,32 @@ -name: ✨ 特性提议 Request new features -description: 欢迎提出你所期待的新特性 Come up with the features you expected -title: "请输入特性提议标题 Please enter the title of the feature request" +name: ✨ Request new features +description: Come up with the features you expected +title: "Please enter the title of the feature request" body: - type: textarea attributes: - label: 在什么情况下你需要该特性？In what scenarios do you need this feature? + label: In what scenarios do you need this feature? description: | - 请尽量清晰地描述该特性的应用场景。 Please describe the functions and application scenarios you expect as clearly and accurately as possible. validations: required: true - type: textarea attributes: - label: 描述可能的最优解决方案 Describe the optimal solution + label: Describe the optimal solution description: | - 请描述你能想到的最优解决方案。也有有些类似软件已经实现了该特性，请列出以供我们参考。 Please try to describe the best solution. There may be similar software that implements this feature. Please also list it for our reference. validations: required: true - type: textarea attributes: - label: 描述候选的解决方案 Describe the candidate solution + label: Describe the candidate solution description: | - 请描述你能想到的候选解决方案。 Please describe the candidate solutions you can accept as clearly and accurately as possible. validations: required: false - type: textarea attributes: - label: 其他信息 Other information + label: Other information description: | - 请提供任何附加信息，以帮助我们更好地理解该特性和解决方案。 Please provide any additional information about this feature suggestion. validations: required: false \ No newline at end of file From f3bbfbe12572c6dd9e17520c2d25bd54d2875321 Mon Sep 17 00:00:00 2001 From: Liang Ding Date: Wed, 29 Mar 2023 13:11:57 +0800 Subject: [PATCH 2/4] :heart: Complete open source interface and kernel https://github.com/siyuan-note/siyuan/issues/5013 --- LICENSE | 1 + 1 file changed, 1 insertion(+) diff --git a/LICENSE b/LICENSE index be3f7b28e..2beb9e163 100644 --- a/LICENSE +++ b/LICENSE @@ -659,3 +659,4 @@ specific requirements. if any, to sign a "copyright disclaimer" for the program, if necessary. For more information on this, and how to apply and follow the GNU AGPL, see . + From cdb662f2bf3ae2d78446674707657952e66fce3a Mon Sep 17 00:00:00 2001 From: Liang Ding Date: Wed, 29 Mar 2023 13:12:01 +0800 Subject: [PATCH 3/4] :heart: Complete open source interface and kernel https://github.com/siyuan-note/siyuan/issues/5013 --- LICENSE | 1 - 1 file changed, 1 deletion(-) diff --git a/LICENSE b/LICENSE index 2beb9e163..be3f7b28e 100644 --- a/LICENSE +++ b/LICENSE @@ -659,4 +659,3 @@ specific requirements. if any, to sign a "copyright disclaimer" for the program, if necessary. For more information on this, and how to apply and follow the GNU AGPL, see . - From 574b7f39c9a52ed7684036e262edd178b9dc3b54 Mon Sep 17 00:00:00 2001 From: Liang Ding Date: Wed, 29 Mar 2023 13:26:00 +0800 Subject: [PATCH 4/4] :art: The reminder message will no longer pop up when the subscription expires for more than 2 days Fix https://github.com/siyuan-note/siyuan/issues/7816 --- app/appearance/langs/en_US.json | 4 ++-- app/appearance/langs/es_ES.json | 2 +- app/appearance/langs/fr_FR.json | 4 ++-- app/appearance/langs/zh_CHT.json | 2 +- app/appearance/langs/zh_CN.json | 2 +- kernel/model/liandi.go | 11 +++++++---- 6 files changed, 14 insertions(+), 11 deletions(-) diff --git a/app/appearance/langs/en_US.json b/app/appearance/langs/en_US.json index 36cb42ffc..c5282c5a4 100644 --- a/app/appearance/langs/en_US.json +++ b/app/appearance/langs/en_US.json @@ -101,7 +101,7 @@ "exportBySiYuan": "Export by SiYuan", "featureBetaStage": "This feature support is currently in the free public beta stage, and there is no clear charging plan yet, please know", "syncOfficialProviderIntro": "Currently selected is the cloud storage service officially provided by SiYuan, which only supports paid subscription users", - "syncThirdPartyProviderS3Intro": "The current selected is a third-party cloud storage service compatible with the Amazon S3 protocol (eg Qiniu, Aliyun OSS, Cloudflare R2)", + "syncThirdPartyProviderS3Intro": "The current selected is a third-party cloud storage service compatible with the Amazon S3 protocol (eg Qiniu, Aliyun OSS, Cloudflare R2)", "syncThirdPartyProviderWebDAVIntro": "The currently selected is a third-party cloud storage service with the WebDAV protocol. Due to the poor performance and insufficient stability of this protocol, it is recommended to choose the S3 service first", "syncThirdPartyProviderTip": "Before using this feature, please pay attention to the technical limitations and billing items of the third-party cloud storage service:
  • Technical limitations such as interface calling frequency and bandwidth
  • Billing items such as storage space and traffic
  • Terms of use and availability guarantee
Disclaimer: For details, please refer to the relevant terms in the open source license AGPLv3 used by SiYuan", "syncProvider": "Cloud Storage Service Provider", @@ -1078,7 +1078,7 @@ "125": "Auto sync failed too many times, please try to manually trigger sync, if there is still a problem, please report it via GitHub Issues", "126": "Bookmark cannot be empty", "127": "There are [%d] days left before the subscription expires, after which the cloud data will be completely deleted. Please visit Here, if you don't need to renew, please log out of your account to close the reminder", - "128": "Subscription has expired, cloud data will be completely deleted after expiration. To renew, please visit here , if you don't need to renew, please log out of your account to close the reminder", + "128": "The subscription has expired. After the expiration, the cloud data will be completely deleted. The reminder will no longer pop up two days after the subscription expires. To renew, please visit here", "129": "Cloud data has been corrupted, please refer to here to resolve the issue", "130": "Starting new version installer...", "131": "This operation is not supported, please go to the cloud storage provider management console to operate", diff --git a/app/appearance/langs/es_ES.json b/app/appearance/langs/es_ES.json index 57817172a..6db3e5b93 100644 --- a/app/appearance/langs/es_ES.json +++ b/app/appearance/langs/es_ES.json @@ -1078,7 +1078,7 @@ "125": "La sincronización automática ha fallado demasiadas veces, por favor intente activar la sincronización manualmente, si todavía hay un problema, por favor infórmelo a través de Problemas GitHub", "126": "El marcador no puede estar vacío", "127": "There are [%d] days left before the subscription expires, after which the cloud data will be completely deleted. Please visit Aquí para la renovación, si no necesita renovar, salga de su cuenta para cerrar el recordatorio", - "128": "La suscripción ha caducado, los datos de la nube se eliminarán completamente después de la expiración. Para renovar, visite Aquí, si no necesita renovar, salga de su cuenta para cerrar el recordatorio", + "128": "La suscripción caducó. Después de la caducidad, los datos de la nube se eliminarán por completo. El recordatorio ya no aparecerá dos días después de que caduque la suscripción. Para renovar, visite aquí", "129": "Los datos de la nube se han dañado, consulte aquí para resolver el problema", "130": "Iniciando instalador de nueva versión...", "131": "Esta solicitud no es compatible, vaya a la consola de administración del proveedor de almacenamiento en la nube para operar", diff --git a/app/appearance/langs/fr_FR.json b/app/appearance/langs/fr_FR.json index c787eb614..6867cd17c 100644 --- a/app/appearance/langs/fr_FR.json +++ b/app/appearance/langs/fr_FR.json @@ -1077,8 +1077,8 @@ "124": "Veuillez activer la synchronisation cloud dans [Paramètres - Activer la synchronisation cloud]", "125": "Il y a trop d'échecs de téléchargement dans la synchronisation automatique. Veuillez essayer de déclencher manuellement la synchronisation. Si le problème persiste, veuillez le signaler via GitHub Issues", "126": "Les signets ne peuvent pas être vides", - "127": "Il reste [%d] jours avant l'expiration de l'abonnement, après quoi les données cloud seront complètement supprimées. Veuillez visiter ici, si vous n'avez pas besoin de renouveler, veuillez vous déconnecter de votre compte pour fermer le rappel", - "128": "L'abonnement a expiré, les données cloud seront complètement supprimées après l'expiration. Pour renouveler, veuillez visiter ici , si vous n'avez pas besoin de renouveler, veuillez vous déconnecter de votre compte pour fermer le rappel", + "127": "Il reste [%d] jours avant l'expiration de l'abonnement, après quoi les données cloud seront complètement supprimées. Veuillez visiter ici, si vous n'avez pas besoin de renouveler, veuillez vous déconnecter de votre compte pour fermer le rappel", + "128": "L'abonnement a expiré. Après l'expiration, les données cloud seront complètement supprimées. Le rappel ne s'affichera plus deux jours après l'expiration de l'abonnement. Pour renouveler, veuillez visiter ici", "129": "Les données cloud ont été corrompues, veuillez vous référer à ici pour résoudre le problème", "130": "Démarrage du programme d'installation de la nouvelle version...", "131": "Cette opération n'est pas prise en charge, veuillez vous rendre sur la console de gestion du fournisseur de stockage cloud pour opérer", diff --git a/app/appearance/langs/zh_CHT.json b/app/appearance/langs/zh_CHT.json index 898b19b89..7c7e4861a 100644 --- a/app/appearance/langs/zh_CHT.json +++ b/app/appearance/langs/zh_CHT.json @@ -1078,7 +1078,7 @@ "125": "自動同步下載失敗次數過多，請嘗試手動觸發同步，如果還有問題請回饋", "126": "書籤不能為空", "127": "訂閱距過期還剩 [%d] 天，過期後雲端數據會被徹底刪除。續訂請訪問這裡，如果不需要續訂，請登出賬號關閉該提醒", - "128": "訂閱已經過期，過期後雲端數據會被徹底刪除。續訂請訪問這裡，如果不需要續訂，請登出賬號關閉該提醒", + "128": "訂閱已經過期，過期後雲端數據會被徹底刪除，訂閱過期兩天后不再彈出該提醒，續訂請訪問這裡", "129": "雲端數據已經損壞，請參考這裡解決該問題", "130": "正在啟動新版本安裝程式...", "131": "不支持該操作，請到雲端存儲提供商管理控制台進行操作", diff --git a/app/appearance/langs/zh_CN.json b/app/appearance/langs/zh_CN.json index afb4bd2ff..ad611e7f7 100644 --- a/app/appearance/langs/zh_CN.json +++ b/app/appearance/langs/zh_CN.json @@ -1078,7 +1078,7 @@ "125": "自动同步下载失败次数过多，请尝试手动触发同步，如果还有问题请反馈", "126": "书签不能为空", "127": "订阅距过期还剩 [%d] 天，过期后云端数据会被彻底删除。续订请访问这里，如果不需要续订，请登出账号关闭该提醒", - "128": "订阅已经过期，过期后云端数据会被彻底删除。续订请访问这里，如果不需要续订，请登出账号关闭该提醒", + "128": "订阅已经过期，过期后云端数据会被彻底删除，订阅过期两天后不再弹出该提醒，续订请访问这里", "129": "云端数据已经损坏，请参考这里解决该问题", "130": "正在启动新版本安装程序...", "131": "不支持该操作，请到云端存储提供商管理控制台进行操作", diff --git a/kernel/model/liandi.go b/kernel/model/liandi.go index e5279926e..f2d2f45c6 100644 --- a/kernel/model/liandi.go +++ b/kernel/model/liandi.go @@ -227,12 +227,15 @@ func refreshSubscriptionExpirationRemind() { } if IsSubscriber() && -1 != Conf.User.UserSiYuanProExpireTime { expired := int64(Conf.User.UserSiYuanProExpireTime) - if time.Now().UnixMilli() >= expired { // 已经过期 - time.Sleep(time.Second * 30) - util.PushErrMsg(Conf.Language(128), 0) + now := time.Now().UnixMilli() + if now >= expired { // 已经过期 + if now-expired <= 1000*60*60*24*2 { // 2 天内提醒 https://github.com/siyuan-note/siyuan/issues/7816 + time.Sleep(time.Second * 30) + util.PushErrMsg(Conf.Language(128), 0) + } return } - remains := int((expired - time.Now().UnixMilli()) / 1000 / 60 / 60 / 24) + remains := int((expired - now) / 1000 / 60 / 60 / 24) expireDay := 15 // 付费订阅提前 15 天提醒 if 2 == Conf.User.UserSiYuanSubscriptionPlan { expireDay = 3 // 试用订阅提前 3 天提醒