Andreas/siyuan
1
0
Fork 0
mirror of https://github.com/siyuan-note/siyuan.git synced 2025-12-22 09:30:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

🎨 fix https://github.com/siyuan-note/siyuan/issues/8454

Browse source
This commit is contained in:
Vanessa 2023-06-05 11:30:58 +08:00
parent 5c641120ae
commit 82ce65fa7e
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/plugin/index.ts
View file

@ -73,6 +73,10 @@ export class Plugin {
position?: "right" | "left", position?: "right" | "left",
callback: (evt: MouseEvent) => void callback: (evt: MouseEvent) => void
}) { }) {
if (!options.icon.startsWith("icon") && !options.icon.startsWith("<svg")) {
console.error(`plugin ${this.name} addTopBar error: icon must be svg id or svg tag`);
return;
}
const iconElement = document.createElement("div"); const iconElement = document.createElement("div");
iconElement.setAttribute("data-menu", "true"); iconElement.setAttribute("data-menu", "true");
iconElement.addEventListener("click", options.callback); iconElement.addEventListener("click", options.callback);

2
app/src/plugin/loader.ts
View file

@ -39,7 +39,7 @@ const loadPluginJS = async (app: App, item: IPluginData) => {
try { try {
runCode(item.js, "plugin:" + encodeURIComponent(item.name))(getObject, moduleObj, exportsObj); runCode(item.js, "plugin:" + encodeURIComponent(item.name))(getObject, moduleObj, exportsObj);
} catch (e) { } catch (e) {
console.error(`eval plugin ${item.name} error:`, e); console.error(`plugin ${item.name} run error:`, e);
return; return;
} }
const pluginClass = (moduleObj.exports || exportsObj).default || moduleObj.exports; const pluginClass = (moduleObj.exports || exportsObj).default || moduleObj.exports;