From 57ade08618a4d01f9726f519c6694a56abeea617 Mon Sep 17 00:00:00 2001 From: Vanessa Date: Thu, 24 Oct 2024 17:30:46 +0800 Subject: [PATCH] :art: https://github.com/siyuan-note/siyuan/issues/12347 --- app/src/assets/scss/business/_history.scss | 12 +++---- app/src/assets/scss/component/_dialog.scss | 4 +++ app/src/assets/scss/util/_responsive.scss | 3 +- app/src/dialog/index.ts | 5 +-- app/src/history/diff.ts | 19 +++++++---- app/src/history/doc.ts | 26 ++++++++------- app/src/history/history.ts | 24 +++++++------- app/src/history/keydown.ts | 6 ++-- app/src/history/resizeSide.ts | 38 ++++++++++++++++++++++ app/src/protyle/util/compatibility.ts | 2 +- 10 files changed, 95 insertions(+), 44 deletions(-) create mode 100644 app/src/history/resizeSide.ts diff --git a/app/src/assets/scss/business/_history.scss b/app/src/assets/scss/business/_history.scss index afe8a15ef..bdd8db552 100644 --- a/app/src/assets/scss/business/_history.scss +++ b/app/src/assets/scss/business/_history.scss @@ -10,7 +10,6 @@ } &__repo { - background-color: var(--b3-theme-background); display: flex; flex-direction: column; height: 100%; @@ -25,16 +24,17 @@ background: var(--b3-theme-background); } - &__diff { + &__side { width: 256px; - border-right: 1px solid var(--b3-border-color); padding: 8px 0; overflow: auto; user-select: none; } - &__panel > .b3-list { - width: 256px; - user-select: none; + &__resize { + cursor: col-resize; + box-shadow: 2px 0 0 0 var(--b3-theme-background) inset, 3px 0 0 0 var(--b3-border-color) inset; + width: 5px; + margin-left: -2px; } } diff --git a/app/src/assets/scss/component/_dialog.scss b/app/src/assets/scss/component/_dialog.scss index 59445d509..e0331db9a 100644 --- a/app/src/assets/scss/component/_dialog.scss +++ b/app/src/assets/scss/component/_dialog.scss @@ -47,6 +47,10 @@ opacity: 0; transition: opacity 75ms linear, transform 150ms 0ms cubic-bezier(0, 0, .2, 1); border: 1px solid var(--b3-theme-surface-lighter); + + &--theme { + background-color: var(--b3-theme-background); + } } &__header { diff --git a/app/src/assets/scss/util/_responsive.scss b/app/src/assets/scss/util/_responsive.scss index f681bae84..454c5e74a 100644 --- a/app/src/assets/scss/util/_responsive.scss +++ b/app/src/assets/scss/util/_responsive.scss @@ -71,8 +71,7 @@ &__panel { flex-direction: column; - & > .b3-list, - & > .history__diff { + & > .history__side { height: 40%; overflow: auto; padding-bottom: 8px; diff --git a/app/src/dialog/index.ts b/app/src/dialog/index.ts index 966d5d4e0..0e1712dc3 100644 --- a/app/src/dialog/index.ts +++ b/app/src/dialog/index.ts @@ -26,7 +26,8 @@ export class Dialog { disableClose?: boolean, hideCloseIcon?: boolean, disableAnimation?: boolean, - resizeCallback?: (type: string) => void + resizeCallback?: (type: string) => void, + containerClassName?: string }) { this.disableClose = options.disableClose; this.id = genUUID(); @@ -49,7 +50,7 @@ export class Dialog { } this.element.innerHTML = `
-
+
${options.title || ""}
${options.content}
diff --git a/app/src/history/diff.ts b/app/src/history/diff.ts index c33ae0d50..314dbd118 100644 --- a/app/src/history/diff.ts +++ b/app/src/history/diff.ts @@ -10,6 +10,7 @@ import {isMobile} from "../util/functions"; import {App} from "../index"; import {pathPosix} from "../util/pathName"; import {renderAssetsPreview} from "../asset/renderAssets"; +import {resizeSide} from "./resizeSide"; const genItem = (data: [], data2?: { title: string, fileID: string }[]) => { if (!data || data.length === 0) { @@ -31,7 +32,7 @@ const genItem = (data: [], data2?: { title: string, fileID: string }[]) => { let leftEditor: Protyle; let rightEditor: Protyle; const renderCompare = (app: App, element: HTMLElement) => { - const listElement = hasClosestByClassName(element, "history__diff"); + const listElement = hasClosestByClassName(element, "history__side"); if (!listElement) { return; } @@ -39,8 +40,9 @@ const renderCompare = (app: App, element: HTMLElement) => { if (!dialogContainerElement) { return; } - const leftElement = listElement.nextElementSibling.firstElementChild; - const rightElement = listElement.nextElementSibling.lastElementChild; + const editorsElement = dialogContainerElement.querySelector('[data-type="editors"]'); + const leftElement = editorsElement.firstElementChild; + const rightElement = editorsElement.lastElementChild; if (!leftEditor) { leftEditor = new Protyle(app, leftElement.lastElementChild as HTMLElement, { blockId: "", @@ -154,6 +156,7 @@ export const showDiff = (app: App, data: { id: string, time: string }[]) => { content: "", width: isMobile() ? "92vw" : "90vw", height: "80vh", + containerClassName: "b3-dialog__container--theme", destroyCallback() { leftEditor = undefined; rightEditor = undefined; @@ -162,7 +165,7 @@ export const showDiff = (app: App, data: { id: string, time: string }[]) => { dialog.element.setAttribute("data-key", Constants.DIALOG_HISTORYCOMPARE); dialog.element.addEventListener("click", (event) => { if (typeof event.detail === "string") { - renderCompare(app, dialog.element.querySelector(".history__diff .b3-list-item--focus")); + renderCompare(app, dialog.element.querySelector(".history__side .b3-list-item--focus")); event.stopPropagation(); event.preventDefault(); return; @@ -179,7 +182,7 @@ export const showDiff = (app: App, data: { id: string, time: string }[]) => { if (target.classList.contains("b3-list-item--focus")) { return; } - dialog.element.querySelector(".history__diff .b3-list-item--focus")?.classList.remove("b3-list-item--focus"); + dialog.element.querySelector(".history__side .b3-list-item--focus")?.classList.remove("b3-list-item--focus"); target.classList.add("b3-list-item--focus"); renderCompare(app, target); event.preventDefault(); @@ -223,7 +226,7 @@ const genHTML = (left: string, right: string, dialog: Dialog, direct: string) =>
`; headElement.nextElementSibling.innerHTML = `
-
+
  • @@ -255,7 +258,8 @@ const genHTML = (left: string, right: string, dialog: Dialog, direct: string) =>
      ${genItem(response.data.removesRight)}
-
+
+
${dayjs(response.data.left.created).format("YYYY-MM-DD HH:mm")}
@@ -270,5 +274,6 @@ const genHTML = (left: string, right: string, dialog: Dialog, direct: string) =>
`; + resizeSide(dialog.element.querySelector(".history__resize"), dialog.element.querySelector(".history__side"), "sideDiffWidth"); }); }; diff --git a/app/src/history/doc.ts b/app/src/history/doc.ts index 3226a0f43..fbcf98f45 100644 --- a/app/src/history/doc.ts +++ b/app/src/history/doc.ts @@ -7,6 +7,7 @@ import * as dayjs from "dayjs"; import {fetchPost} from "../util/fetch"; import {isMobile} from "../util/functions"; import {App} from "../index"; +import {resizeSide} from "./resizeSide"; let historyEditor: Protyle; let isLoading = false; @@ -60,8 +61,16 @@ export const openDocHistory = (options: { notebookId: string, pathString: string }) => { - const contentHTML = `
-
+ const contentHTML = `
+
    +
  • ${window.siyuan.languages.emptyContent}
    • +
+
+ +
+
`; + const dialog = new Dialog({ + title:`
${isMobile() ? "" : options.pathString}
@@ -82,19 +91,11 @@ export const openDocHistory = (options: { 1/1 ${isMobile() ? '' : ""} -
-
-
    -
  • ${window.siyuan.languages.emptyContent}
    • -
- -
-
-
`; - const dialog = new Dialog({ +
`, content: contentHTML, width: isMobile() ? "100vw" : "90vw", height: isMobile() ? "100vh" : "80vh", + containerClassName: "b3-dialog__container--theme", destroyCallback() { historyEditor = undefined; } @@ -182,6 +183,7 @@ export const openDocHistory = (options: { target = target.parentElement; } }); + resizeSide(dialog.element.querySelector(".history__resize"), dialog.element.querySelector(".history__side"), "sideDocWidth"); }; const getHistoryPath = (target: Element, op: string, id: string, cb: (item: any) => void) => { diff --git a/app/src/history/history.ts b/app/src/history/history.ts index 787195af3..70bf30e41 100644 --- a/app/src/history/history.ts +++ b/app/src/history/history.ts @@ -14,6 +14,7 @@ import {setStorageVal} from "../protyle/util/compatibility"; import {openModel} from "../mobile/menu/model"; import {closeModel} from "../mobile/util/closePanel"; import {App} from "../index"; +import {resizeSide} from "./resizeSide"; let historyEditor: Protyle; @@ -65,11 +66,9 @@ const renderDoc = (element: HTMLElement, currentPage: number) => { opElement.querySelector('option[value="replace"]').classList.remove("fn__none"); opElement.querySelector('option[value="outline"]').classList.remove("fn__none"); } - window.siyuan.storage[Constants.LOCAL_HISTORY] = { - notebookId: notebookElement.value, - type: parseInt(typeElement.value), - operation: opElement.value - }; + window.siyuan.storage[Constants.LOCAL_HISTORY].notebookId = notebookElement.value + window.siyuan.storage[Constants.LOCAL_HISTORY].type = parseInt(typeElement.value) + window.siyuan.storage[Constants.LOCAL_HISTORY].operation = opElement.value setStorageVal(Constants.LOCAL_HISTORY, window.siyuan.storage[Constants.LOCAL_HISTORY]); fetchPost("/api/history/searchHistory", { notebook: notebookElement.value, @@ -276,7 +275,7 @@ const renderRepo = (element: Element, currentPage: number) => { previousElement.setAttribute("disabled", "disabled"); } nextElement.setAttribute("disabled", "disabled"); - fetchPost(`/api/repo/${selectValue}`, { page: currentPage }, (response) => { + fetchPost(`/api/repo/${selectValue}`, {page: currentPage}, (response) => { selectElement.disabled = false; if (currentPage < response.data.pageCount) { nextElement.removeAttribute("disabled"); @@ -355,7 +354,7 @@ export const openHistory = (app: App) => {
-
+
@@ -394,9 +393,10 @@ export const openHistory = (app: App) => {
-
    +
    • ${window.siyuan.languages.emptyContent}
    +
    @@ -450,12 +450,14 @@ export const openHistory = (app: App) => { content: contentHTML, width: "90vw", height: "80vh", + containerClassName: "b3-dialog__container--theme", destroyCallback() { historyEditor = undefined; } }); dialog.element.setAttribute("data-key", Constants.DIALOG_HISTORY); bindEvent(app, dialog.element, dialog); + resizeSide(dialog.element.querySelector(".history__resize"), dialog.element.querySelector(".history__side"), "sideWidth"); } }; @@ -666,7 +668,7 @@ const bindEvent = (app: App, element: Element, dialog?: Dialog) => { target.parentElement.querySelector(`.b3-list-item[data-id="${idJSON.splice(0, 1)[0].id}"]`)?.classList.remove("b3-list-item--focus"); } } - idJSON.push({ id, time: target.querySelector('[data-type="hCreated"]').textContent }); + idJSON.push({id, time: target.querySelector('[data-type="hCreated"]').textContent}); } if (idJSON.length === 2) { @@ -738,7 +740,7 @@ const bindEvent = (app: App, element: Element, dialog?: Dialog) => { genRepoDialog.destroy(); }); btnsElement[1].addEventListener("click", () => { - fetchPost("/api/repo/createSnapshot", { memo: textareaElement.value }, () => { + fetchPost("/api/repo/createSnapshot", {memo: textareaElement.value}, () => { renderRepo(repoElement, 1); }); genRepoDialog.destroy(); @@ -749,7 +751,7 @@ const bindEvent = (app: App, element: Element, dialog?: Dialog) => { } else if (type === "removeRepoTagSnapshot" || type === "removeCloudRepoTagSnapshot") { const tag = target.parentElement.getAttribute("data-tag"); confirmDialog(window.siyuan.languages.deleteOpConfirm, `${window.siyuan.languages.confirmDelete} ${tag}?`, () => { - fetchPost("/api/repo/" + type, { tag }, () => { + fetchPost("/api/repo/" + type, {tag}, () => { renderRepo(repoElement, 1); }); }); diff --git a/app/src/history/keydown.ts b/app/src/history/keydown.ts index 5d9d37475..975f30f7b 100644 --- a/app/src/history/keydown.ts +++ b/app/src/history/keydown.ts @@ -1,8 +1,8 @@ import {Dialog} from "../dialog"; export const historyKeydown = (event: KeyboardEvent, dialog: Dialog) => { - let currentItem = dialog.element.querySelector(".history__diff .b3-list-item--focus"); - const items = Array.from(dialog.element.querySelectorAll(".history__diff .b3-list-item[data-id]")); + let currentItem = dialog.element.querySelector(".history__side .b3-list-item--focus"); + const items = Array.from(dialog.element.querySelectorAll(".history__side .b3-list-item[data-id]")); if (items.length < 2) { return; } @@ -41,7 +41,7 @@ export const historyKeydown = (event: KeyboardEvent, dialog: Dialog) => { currentItem.parentElement.previousElementSibling.querySelector("svg").classList.add("b3-list-item__arrow--open"); } const currentItemRect = currentItem.getBoundingClientRect(); - const historyDiffElement = dialog.element.querySelector(".history__diff"); + const historyDiffElement = dialog.element.querySelector(".history__side"); const historyDiffRect = historyDiffElement.getBoundingClientRect(); if (currentItemRect.bottom > historyDiffRect.bottom) { currentItem.scrollIntoView(false); diff --git a/app/src/history/resizeSide.ts b/app/src/history/resizeSide.ts new file mode 100644 index 000000000..c5c0afc8a --- /dev/null +++ b/app/src/history/resizeSide.ts @@ -0,0 +1,38 @@ +import {Constants} from "../constants"; +import {setStorageVal} from "../protyle/util/compatibility"; +import {hasClosestByClassName} from "../protyle/util/hasClosest"; + +export const resizeSide = (targetElement: HTMLElement, element: HTMLElement, key:string) => { + targetElement.addEventListener("mousedown", (event: MouseEvent & { target: HTMLElement }) => { + const dialogBodyElement = hasClosestByClassName(element, "b3-dialog__body"); + if (!dialogBodyElement) { + return; + } + dialogBodyElement.style.userSelect = "none"; + + const documentSelf = document; + documentSelf.ondragstart = () => false; + + const x = event.clientX; + const width = element.clientWidth; + const maxWidth = dialogBodyElement.clientWidth - 256; + documentSelf.onmousemove = (moveEvent: MouseEvent) => { + const newWidth = width + (moveEvent.clientX - x); + if (newWidth < 256 || newWidth > maxWidth) { + return; + } + element.style.width = newWidth + "px"; + }; + + documentSelf.onmouseup = () => { + dialogBodyElement.style.userSelect = "auto"; + documentSelf.onmousemove = null; + documentSelf.onmouseup = null; + documentSelf.ondragstart = null; + documentSelf.onselectstart = null; + documentSelf.onselect = null; + window.siyuan.storage[Constants.LOCAL_HISTORY][key] = element.clientWidth + "px"; + setStorageVal(Constants.LOCAL_HISTORY, window.siyuan.storage[Constants.LOCAL_HISTORY]); + }; + }); +}; diff --git a/app/src/protyle/util/compatibility.ts b/app/src/protyle/util/compatibility.ts index 402a45c6d..345412167 100644 --- a/app/src/protyle/util/compatibility.ts +++ b/app/src/protyle/util/compatibility.ts @@ -206,7 +206,7 @@ export const getLocalStorage = (cb: () => void) => { defaultStorage[Constants.LOCAL_FILEPOSITION] = {}; // {id: IScrollAttr} defaultStorage[Constants.LOCAL_DIALOGPOSITION] = {}; // {id: IPosition} defaultStorage[Constants.LOCAL_HISTORY] = { - notebookId: "%", type: 0, operation: "all" + notebookId: "%", type: 0, operation: "all", sideWidth: "256px", sideDocWidth: "256px", sideDiffWidth: "256px", }; defaultStorage[Constants.LOCAL_FLASHCARD] = { fullscreen: false