From 2ae3371674c11ec4a3435cc7a0c4245a7ffdaeb6 Mon Sep 17 00:00:00 2001 From: Daniel <845765@qq.com> Date: Mon, 10 Jul 2023 11:56:55 +0800 Subject: [PATCH] :art: Add multi-select type column to Attribute View https://github.com/siyuan-note/siyuan/issues/8695 --- kernel/model/attribute_view.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/model/attribute_view.go b/kernel/model/attribute_view.go index eab38bbec..01b1e18db 100644 --- a/kernel/model/attribute_view.go +++ b/kernel/model/attribute_view.go @@ -337,9 +337,10 @@ func updateAttributeViewColumnOption(operation *Operation) (err error) { colIndex = i existOpt := false - for _, opt := range col.Options { + for j, opt := range col.Options { if opt.Name == newName { existOpt = true + col.Options = append(col.Options[:j], col.Options[j+1:]...) break } } @@ -358,8 +359,8 @@ func updateAttributeViewColumnOption(operation *Operation) (err error) { } for _, row := range attrView.Rows { - for k, cell := range row.Cells { - if colIndex != k || nil == cell.Value { + for i, cell := range row.Cells { + if colIndex != i || nil == cell.Value { continue } @@ -371,9 +372,10 @@ func updateAttributeViewColumnOption(operation *Operation) (err error) { } } else if nil != cell.Value.MSelect { existInMSelect := false - for _, opt := range cell.Value.MSelect { + for j, opt := range cell.Value.MSelect { if opt.Content == newName { existInMSelect = true + cell.Value.MSelect = append(cell.Value.MSelect[:j], cell.Value.MSelect[j+1:]...) break } }