From 24c59dd0956874df7f5d7e8aa057896f296d8290 Mon Sep 17 00:00:00 2001
From: Daniel <845765@qq.com>
Date: Wed, 27 Mar 2024 20:42:09 +0800
Subject: [PATCH] :bug: Fix insertBlock API argument check
 https://ld246.com/article/1711525429788

---
 kernel/api/block_op.go | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/kernel/api/block_op.go b/kernel/api/block_op.go
index 051e03ae5..829c266a0 100644
--- a/kernel/api/block_op.go
+++ b/kernel/api/block_op.go
@@ -222,13 +222,13 @@ func moveBlock(c *gin.Context) {
 	var parentID, previousID string
 	if nil != arg["parentID"] {
 		parentID = arg["parentID"].(string)
-		if util.InvalidIDPattern(parentID, ret) {
+		if "" != parentID && util.InvalidIDPattern(parentID, ret) {
 			return
 		}
 	}
 	if nil != arg["previousID"] {
 		previousID = arg["previousID"].(string)
-		if util.InvalidIDPattern(previousID, ret) {
+		if "" != previousID && util.InvalidIDPattern(previousID, ret) {
 			return
 		}
 
@@ -364,26 +364,20 @@ func insertBlock(c *gin.Context) {
 	var parentID, previousID, nextID string
 	if nil != arg["parentID"] {
 		parentID = arg["parentID"].(string)
-		if "" != parentID {
-			if util.InvalidIDPattern(parentID, ret) {
-				return
-			}
+		if "" != parentID && util.InvalidIDPattern(parentID, ret) {
+			return
 		}
 	}
 	if nil != arg["previousID"] {
 		previousID = arg["previousID"].(string)
-		if "" != previousID {
-			if util.InvalidIDPattern(previousID, ret) {
-				return
-			}
+		if "" != previousID && util.InvalidIDPattern(parentID, ret) {
+			return
 		}
 	}
 	if nil != arg["nextID"] {
 		nextID = arg["nextID"].(string)
-		if "" != nextID {
-			if util.InvalidIDPattern(nextID, ret) {
-				return
-			}
+		if "" != nextID && util.InvalidIDPattern(parentID, ret) {
+			return
 		}
 	}