From 06c39771ce5ee3a3e4215a03335f90c5347083cb Mon Sep 17 00:00:00 2001 From: Daniel <845765@qq.com> Date: Thu, 7 Nov 2024 17:43:44 +0800 Subject: [PATCH] :lock: SQL injection security vulnerabilities https://github.com/siyuan-note/siyuan/issues/13077 https://github.com/siyuan-note/siyuan/issues/13057 --- kernel/model/history.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/kernel/model/history.go b/kernel/model/history.go index fe6d318fa..c747c07ce 100644 --- a/kernel/model/history.go +++ b/kernel/model/history.go @@ -448,6 +448,13 @@ func FullTextSearchHistoryItems(created, query, box, op string, typ int) (ret [] table := "histories_fts_case_insensitive" stmt := "SELECT * FROM " + table + " WHERE " stmt += buildSearchHistoryQueryFilter(query, op, box, table, typ) + + _, parseErr := strconv.Atoi(created) + if nil != parseErr { + ret = []*HistoryItem{} + return + } + stmt += " AND created = '" + created + "' ORDER BY created DESC LIMIT " + fmt.Sprintf("%d", fileHistoryPageSize) sqlHistories := sql.SelectHistoriesRawStmt(stmt) ret = fromSQLHistories(sqlHistories)