From bb4bf77ceb06816befb2a9b74aff66e93050fd71 Mon Sep 17 00:00:00 2001
From: Vladimir Lugovsky <lugovsky.v@gmail.com>
Date: Thu, 27 Oct 2016 16:28:02 +0300
Subject: [PATCH] fix(sidebar): add href attribute to placeholder links in
 sidebar and pageTop (#377)

---
 .../components/baMenu/components/baMenuItem/baMenuItem.html     | 2 +-
 src/app/theme/components/baPageTop/baPageTop.component.ts       | 1 +
 src/app/theme/components/baPageTop/baPageTop.html               | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/app/theme/components/baMenu/components/baMenuItem/baMenuItem.html b/src/app/theme/components/baMenu/components/baMenuItem/baMenuItem.html
index 737aecc2..b741dd9b 100644
--- a/src/app/theme/components/baMenu/components/baMenuItem/baMenuItem.html
+++ b/src/app/theme/components/baMenu/components/baMenuItem/baMenuItem.html
@@ -8,7 +8,7 @@
     <i *ngIf="menuItem.icon" class="{{ menuItem.icon }}"></i><span>{{ menuItem.title }}</span>
   </a>
 
-  <a *ngIf="menuItem.children" (mouseenter)="onHoverItem($event, item)" (click)="onToggleSubMenu($event, menuItem)" class="al-sidebar-list-link">
+  <a *ngIf="menuItem.children" (mouseenter)="onHoverItem($event, item)" href (click)="onToggleSubMenu($event, menuItem)" class="al-sidebar-list-link">
     <i *ngIf="menuItem.icon" class="{{ menuItem.icon }}"></i><span>{{ menuItem.title }}</span>
     <b class="fa fa-angle-down" [ngClass]="{'fa-angle-up': menuItem.expanded}"></b>
   </a>
diff --git a/src/app/theme/components/baPageTop/baPageTop.component.ts b/src/app/theme/components/baPageTop/baPageTop.component.ts
index 82f690cd..e20d38a7 100644
--- a/src/app/theme/components/baPageTop/baPageTop.component.ts
+++ b/src/app/theme/components/baPageTop/baPageTop.component.ts
@@ -22,6 +22,7 @@ export class BaPageTop {
   public toggleMenu() {
     this.isMenuCollapsed = !this.isMenuCollapsed;
     this._state.notifyDataChanged('menu.isCollapsed', this.isMenuCollapsed);
+    return false;
   }
 
   public scrolledChanged(isScrolled) {
diff --git a/src/app/theme/components/baPageTop/baPageTop.html b/src/app/theme/components/baPageTop/baPageTop.html
index c899c7ca..1c6b660d 100644
--- a/src/app/theme/components/baPageTop/baPageTop.html
+++ b/src/app/theme/components/baPageTop/baPageTop.html
@@ -1,7 +1,7 @@
 <div class="page-top clearfix" baScrollPosition maxHeight="50" (scrollChange)="scrolledChanged($event)"
      [ngClass]="{scrolled: isScrolled}">
   <a routerLink="/pages/dashboard" class="al-logo clearfix"><span>ng2-</span>admin</a>
-  <a (click)="toggleMenu()" class="collapse-menu-link ion-navicon"></a>
+  <a href (click)="toggleMenu()" class="collapse-menu-link ion-navicon"></a>
 
   <div class="search">
     <i class="ion-ios-search-strong" ng-click="startSearch()"></i>