fix(sidebar): toggle performance issues (#5658)

* refactor: improve observable layout change sharing
* feat: add safe delayed event of layout change
* fix: replace change layout with safe change
* fix: limit front card width to prevent map overflow before repaint
This commit is contained in:
Sasha Verbilo 2020-04-15 16:18:29 +03:00 committed by GitHub
parent 5cc4c19cee
commit 9eaf0bb005
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 35 additions and 23 deletions

View file

@ -1,20 +1,26 @@
import { Injectable } from '@angular/core';
import { Observable, Subject } from 'rxjs';
import { delay, share } from 'rxjs/operators';
import { delay, shareReplay, debounceTime } from 'rxjs/operators';
@Injectable()
export class LayoutService {
protected layoutSize$ = new Subject();
protected layoutSizeChange$ = this.layoutSize$.pipe(
shareReplay({ refCount: true }),
);
changeLayoutSize() {
this.layoutSize$.next();
}
onChangeLayoutSize(): Observable<any> {
return this.layoutSize$.pipe(
share(),
delay(1),
return this.layoutSizeChange$.pipe(delay(1));
}
onSafeChangeLayoutSize(): Observable<any> {
return this.layoutSizeChange$.pipe(
debounceTime(350),
);
}
}

View file

@ -27,7 +27,7 @@ export class ElectricityChartComponent implements AfterViewInit, OnDestroy {
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -26,7 +26,7 @@ export class TrafficChartComponent implements AfterViewInit, OnDestroy {
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -35,7 +35,7 @@ export class OrdersChartComponent implements AfterViewInit, OnDestroy, OnChanges
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -24,7 +24,7 @@ export class ProfitChartComponent implements AfterViewInit, OnDestroy, OnChanges
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -33,7 +33,7 @@ export class CountryOrdersChartComponent implements AfterViewInit, OnDestroy, On
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -23,7 +23,7 @@ export class EarningLiveUpdateChartComponent implements AfterViewInit, OnDestroy
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -24,7 +24,7 @@ export class StatsAreaChartComponent implements AfterViewInit, OnDestroy {
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -27,7 +27,7 @@ export class StatsBarAnimationChartComponent implements AfterViewInit, OnDestroy
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -10,16 +10,22 @@
cursor: pointer;
}
::ng-deep .flipped {
.back-container {
.flip-icon {
transform: scaleX(-1);
}
::ng-deep {
.front-container {
max-width: 100%;
}
.front-container {
.flip-icon {
display: none;
.flipped {
.back-container {
.flip-icon {
transform: scaleX(-1);
}
}
.front-container {
.flip-icon {
display: none;
}
}
}
}

View file

@ -28,7 +28,7 @@ export class TrafficBarChartComponent implements AfterViewInit, OnDestroy, OnCha
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -31,7 +31,7 @@ export class ECommerceVisitorsAnalyticsChartComponent implements AfterViewInit,
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)

View file

@ -21,7 +21,7 @@ export class ECommerceVisitorsStatisticsComponent implements AfterViewInit, OnDe
constructor(private theme: NbThemeService,
private layoutService: LayoutService) {
this.layoutService.onChangeLayoutSize()
this.layoutService.onSafeChangeLayoutSize()
.pipe(
takeWhile(() => this.alive),
)