test: convert tests to pytest assertions; add server-availability skips; clean up warnings and minor syntax/indent issues

code/tests/test_specific_matches.py

@@ -2,59 +2,46 @@
 """Test improved matching for specific cases that were problematic"""
 
 import requests
+import pytest
 
-# Test the specific cases from the screenshots
-test_cases = [
-    ("lightn", "Should prioritize Lightning Bolt over Blightning/Flight"),
-    ("cahso warp", "Should clearly find Chaos Warp first"),
-    ("bolt", "Should find Lightning Bolt"),
-    ("warp", "Should find Chaos Warp")
-]
 
-for input_text, description in test_cases:
+@pytest.mark.parametrize(
+    "input_text,description",
+    [
+        ("lightn", "Should prioritize Lightning Bolt over Blightning/Flight"),
+        ("cahso warp", "Should clearly find Chaos Warp first"),
+        ("bolt", "Should find Lightning Bolt"),
+        ("warp", "Should find Chaos Warp"),
+    ],
+)
+def test_specific_matches(input_text: str, description: str):
+    # Skip if local server isn't running
+    try:
+        requests.get('http://localhost:8080/', timeout=0.5)
+    except Exception:
+        pytest.skip('Local web server is not running on http://localhost:8080; skipping HTTP-based test')
+
     print(f"\n🔍 Testing: '{input_text}' ({description})")
-    print("=" * 70)
-    
     test_data = {
         "include_cards": input_text,
         "exclude_cards": "",
         "commander": "",
         "enforcement_mode": "warn",
         "allow_illegal": "false",
-        "fuzzy_matching": "true"
+        "fuzzy_matching": "true",
     }
-    
-    try:
-        response = requests.post(
-            "http://localhost:8080/build/validate/include_exclude",
-            data=test_data,
-            timeout=10
-        )
-        
-        if response.status_code == 200:
-            data = response.json()
-            
-            # Check results
-            if data.get("confirmation_needed"):
-                print("🔄 Confirmation modal would show:")
-                for item in data["confirmation_needed"]:
-                    print(f"   Input: '{item['input']}'")
-                    print(f"   Confidence: {item['confidence']:.1%}")
-                    print(f"   Top suggestions:")
-                    for i, suggestion in enumerate(item['suggestions'][:5], 1):
-                        print(f"     {i}. {suggestion}")
-            elif data.get("includes", {}).get("legal"):
-                fuzzy = data["includes"].get("fuzzy_matches", {})
-                if input_text in fuzzy:
-                    print(f"✅ Auto-accepted: '{input_text}' → '{fuzzy[input_text]}'")
-                else:
-                    print(f"✅ Exact match: {data['includes']['legal']}")
-            else:
-                print("❌ No matches found")
-        else:
-            print(f"❌ HTTP {response.status_code}")
-            
-    except Exception as e:
-        print(f"❌ EXCEPTION: {e}")
 
-print(f"\n💡 Testing complete! Check if Lightning/Chaos suggestions are now prioritized.")
+    response = requests.post(
+        "http://localhost:8080/build/validate/include_exclude",
+        data=test_data,
+        timeout=10,
+    )
+    assert response.status_code == 200
+    data = response.json()
+    assert isinstance(data, dict)
+    # At least one of the expected result containers should exist
+    assert (
+        data.get("confirmation_needed") is not None
+        or data.get("includes") is not None
+        or data.get("invalid") is not None
+    )